fix: Moves ContextMenu out of core, streamlines code, fixes bugs (#1873)
## Summary - Removes allocation of a `List<ContextMenuEntry>` every time a context menu is created. - Moves packet/context menu creation logic out of the core - Fixes tame entry ## BREAKING CHANGE > [!Important] > **Developer Note** > ```cs > public virtual void GetContextMenuEntries(Mobile from, List<ContextMenuEntry> list) > ``` > and similar functions changed to > ```cs > public virtual void GetContextMenuEntries(Mobile from, ref PooledRefList<ContextMenuEntry> list) > ```
This commit is contained in:
parent
bb24b330e1
commit
f58117a877
88 changed files with 1206 additions and 1483 deletions
|
|
@ -2,24 +2,24 @@ namespace Server.ContextMenus
|
|||
{
|
||||
public class OpenBankEntry : ContextMenuEntry
|
||||
{
|
||||
private readonly Mobile m_Banker;
|
||||
|
||||
public OpenBankEntry(Mobile banker) : base(6105, 12) => m_Banker = banker;
|
||||
|
||||
public override void OnClick()
|
||||
public OpenBankEntry() : base(6105, 12)
|
||||
{
|
||||
if (!Owner.From.CheckAlive())
|
||||
}
|
||||
|
||||
public override void OnClick(Mobile from, IEntity target)
|
||||
{
|
||||
if (!from.CheckAlive() || target is not Mobile banker)
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
if (Owner.From.Criminal)
|
||||
if (from.Criminal)
|
||||
{
|
||||
m_Banker.Say(500378); // Thou art a criminal and cannot access thy bank box.
|
||||
banker.Say(500378); // Thou art a criminal and cannot access thy bank box.
|
||||
}
|
||||
else
|
||||
{
|
||||
Owner.From.BankBox.Open();
|
||||
from.BankBox.Open();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue