fix: Moves ContextMenu out of core, streamlines code, fixes bugs (#1873)

## Summary
- Removes allocation of a `List<ContextMenuEntry>` every time a context menu is created.
- Moves packet/context menu creation logic out of the core
- Fixes tame entry

## BREAKING CHANGE
> [!Important]
> **Developer Note**
> ```cs
> public virtual void GetContextMenuEntries(Mobile from, List<ContextMenuEntry> list)
> ```
> and similar functions changed to
> ```cs
> public virtual void GetContextMenuEntries(Mobile from, ref PooledRefList<ContextMenuEntry> list)
> ```
This commit is contained in:
Kamron Batman 2024-07-20 21:33:23 -07:00 • committed by GitHub
parent bb24b330e1
commit f58117a877
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
88 changed files with 1206 additions and 1483 deletions

View file

@ -2,24 +2,24 @@ namespace Server.ContextMenus
{
public class OpenBankEntry : ContextMenuEntry
{
private readonly Mobile m_Banker;
public OpenBankEntry(Mobile banker) : base(6105, 12) => m_Banker = banker;
public override void OnClick()
public OpenBankEntry() : base(6105, 12)
{
if (!Owner.From.CheckAlive())
}
public override void OnClick(Mobile from, IEntity target)
{
if (!from.CheckAlive() || target is not Mobile banker)
{
return;
}
if (Owner.From.Criminal)
if (from.Criminal)
{
m_Banker.Say(500378); // Thou art a criminal and cannot access thy bank box.
banker.Say(500378); // Thou art a criminal and cannot access thy bank box.
}
else
{
Owner.From.BankBox.Open();
from.BankBox.Open();
}
}
}