fix: Moves ContextMenu out of core, streamlines code, fixes bugs (#1873)

## Summary
- Removes allocation of a `List<ContextMenuEntry>` every time a context menu is created.
- Moves packet/context menu creation logic out of the core
- Fixes tame entry

## BREAKING CHANGE
> [!Important]
> **Developer Note**
> ```cs
> public virtual void GetContextMenuEntries(Mobile from, List<ContextMenuEntry> list)
> ```
> and similar functions changed to
> ```cs
> public virtual void GetContextMenuEntries(Mobile from, ref PooledRefList<ContextMenuEntry> list)
> ```
This commit is contained in:
Kamron Batman 2024-07-20 21:33:23 -07:00 • committed by GitHub
parent bb24b330e1
commit f58117a877
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
88 changed files with 1206 additions and 1483 deletions

View file

@ -1,34 +1,25 @@
using Server.Mobiles;
using Server.Network;
namespace Server.ContextMenus
{
public class TeachEntry : ContextMenuEntry
{
private readonly Mobile m_From;
private readonly BaseCreature m_Mobile;
private readonly SkillName m_Skill;
private readonly SkillName _skill;
public TeachEntry(SkillName skill, BaseCreature m, Mobile from, bool enabled) : base(6000 + (int)skill)
public TeachEntry(SkillName skill, bool enabled) : base(6000 + (int)skill)
{
m_Skill = skill;
m_Mobile = m;
m_From = from;
if (!enabled)
{
Flags |= CMEFlags.Disabled;
}
_skill = skill;
Enabled = enabled;
}
public override void OnClick()
public override void OnClick(Mobile from, IEntity target)
{
if (!m_From.CheckAlive())
if (!from.CheckAlive() || target is not BaseCreature bc)
{
return;
}
m_Mobile.Teach(m_Skill, m_From, 0, false);
bc.Teach(_skill, from, 0, false);
}
}
}