warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Moves ContextMenu out of core, streamlines code, fixes bugs (#1873)

Browse source 
## Summary
- Removes allocation of a `List<ContextMenuEntry>` every time a context menu is created.
- Moves packet/context menu creation logic out of the core
- Fixes tame entry

## BREAKING CHANGE
> [!Important]
> **Developer Note**
> ```cs
> public virtual void GetContextMenuEntries(Mobile from, List<ContextMenuEntry> list)
> ```
> and similar functions changed to
> ```cs
> public virtual void GetContextMenuEntries(Mobile from, ref PooledRefList<ContextMenuEntry> list)
> ```
This commit is contained in:
Kamron Batman 2024-07-20 21:33:23 -07:00 • committed by GitHub
parent bb24b330e1
commit f58117a877
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
88 changed files with 1206 additions and 1483 deletions
Download patch file Download diff file Expand all files Collapse all files

56
Projects/UOContent/Engines/ConPVP/TournamentController.cs
View file

@ -1,4 +1,5 @@
using System.Collections.Generic;
using Server.Collections;
using Server.ContextMenus;
using Server.Gumps;
@ -46,17 +47,17 @@ namespace Server.Engines.ConPVP
public override string DefaultName => "tournament controller";
public override void GetContextMenuEntries(Mobile from, List<ContextMenuEntry> list)
public override void GetContextMenuEntries(Mobile from, ref PooledRefList<ContextMenuEntry> list)
{
base.GetContextMenuEntries(from, list);
base.GetContextMenuEntries(from, ref list);
if (from.AccessLevel >= AccessLevel.GameMaster && Tournament != null)
{
list.Add(new EditEntry(Tournament));
list.Add(new EditEntry());
if (Tournament.CurrentStage == TournamentStage.Inactive)
{
list.Add(new StartEntry(Tournament));
list.Add(new StartEntry());
}
}
}
@ -107,35 +108,42 @@ namespace Server.Engines.ConPVP
private class EditEntry : ContextMenuEntry
{
private readonly Tournament m_Tournament;
public EditEntry(Tournament tourney) : base(5101) => m_Tournament = tourney;
public override void OnClick()
public EditEntry() : base(5101)
{
Owner.From.SendGump(new PropertiesGump(Owner.From, m_Tournament));
}
public override void OnClick(Mobile from, IEntity target)
{
if (target is not TournamentController controller)
{
return;
}
from.SendGump(new PropertiesGump(from, controller.Tournament));
}
}
private class StartEntry : ContextMenuEntry
{
private readonly Tournament m_Tournament;
public StartEntry(Tournament tourney) : base(5113) => m_Tournament = tourney;
public override void OnClick()
public StartEntry() : base(5113)
{
if (m_Tournament.Stage == TournamentStage.Inactive)
}
public override void OnClick(Mobile from, IEntity target)
{
if (target is not TournamentController controller || controller.Tournament.Stage != TournamentStage.Inactive)
{
m_Tournament.SignupStart = Core.Now;
m_Tournament.Stage = TournamentStage.Signup;
m_Tournament.Participants.Clear();
m_Tournament.Pyramid.Levels.Clear();
m_Tournament.Alert(
"Hear ye! Hear ye!",
"Tournament signup has opened. You can enter by signing up with the registrar."
);
return;
}
controller.Tournament.SignupStart = Core.Now;
controller.Tournament.Stage = TournamentStage.Signup;
controller.Tournament.Participants.Clear();
controller.Tournament.Pyramid.Levels.Clear();
controller.Tournament.Alert(
"Hear ye! Hear ye!",
"Tournament signup has opened. You can enter by signing up with the registrar."
);
}
}
}