warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Moves ContextMenu out of core, streamlines code, fixes bugs (#1873)

Browse source 
## Summary
- Removes allocation of a `List<ContextMenuEntry>` every time a context menu is created.
- Moves packet/context menu creation logic out of the core
- Fixes tame entry

## BREAKING CHANGE
> [!Important]
> **Developer Note**
> ```cs
> public virtual void GetContextMenuEntries(Mobile from, List<ContextMenuEntry> list)
> ```
> and similar functions changed to
> ```cs
> public virtual void GetContextMenuEntries(Mobile from, ref PooledRefList<ContextMenuEntry> list)
> ```
This commit is contained in:
Kamron Batman 2024-07-20 21:33:23 -07:00 • committed by GitHub
parent bb24b330e1
commit f58117a877
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
88 changed files with 1206 additions and 1483 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Projects/UOContent/Engines/Party/RemoveFromParty.cs
View file

@ -4,31 +4,26 @@ namespace Server.ContextMenus
{
public class RemoveFromPartyEntry : ContextMenuEntry
{
private readonly Mobile m_From;
private readonly Mobile m_Target;
public RemoveFromPartyEntry(Mobile from, Mobile target) : base(0198, 12)
public RemoveFromPartyEntry() : base(0198, 12)
{
m_From = from;
m_Target = target;
}
public override void OnClick()
public override void OnClick(Mobile from, IEntity target)
{
var p = Party.Get(m_From);
var p = Party.Get(from);
if (p == null || p.Leader != m_From || !p.Contains(m_Target))
if (target is not Mobile mobile || p == null || p.Leader != from || !p.Contains(mobile))
{
return;
}
if (m_From == m_Target)
if (from == mobile)
{
m_From.SendLocalizedMessage(1005446); // You may only remove yourself from a party if you are not the leader.
from.SendLocalizedMessage(1005446); // You may only remove yourself from a party if you are not the leader.
}
else
{
p.Remove(m_Target);
p.Remove(mobile);
}
}
}