warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Moves ContextMenu out of core, streamlines code, fixes bugs (#1873)

Browse source 
## Summary
- Removes allocation of a `List<ContextMenuEntry>` every time a context menu is created.
- Moves packet/context menu creation logic out of the core
- Fixes tame entry

## BREAKING CHANGE
> [!Important]
> **Developer Note**
> ```cs
> public virtual void GetContextMenuEntries(Mobile from, List<ContextMenuEntry> list)
> ```
> and similar functions changed to
> ```cs
> public virtual void GetContextMenuEntries(Mobile from, ref PooledRefList<ContextMenuEntry> list)
> ```
This commit is contained in:
Kamron Batman 2024-07-20 21:33:23 -07:00 • committed by GitHub
parent bb24b330e1
commit f58117a877
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
88 changed files with 1206 additions and 1483 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Projects/UOContent/Mobiles/PlayerMobile.cs
View file

@ -1855,13 +1855,18 @@ namespace Server.Mobiles
}
}
public override void GetContextMenuEntries(Mobile from, List<ContextMenuEntry> list)
public override void GetContextMenuEntries(Mobile from, ref PooledRefList<ContextMenuEntry> list)
{
base.GetContextMenuEntries(from, list);
base.GetContextMenuEntries(from, ref list);
if (from == this)
{
Quest?.GetContextMenuEntries(list);
if (Alive && Backpack != null && CanSee(Backpack))
{
list.Add(new OpenBackpackEntry());
}
Quest?.GetContextMenuEntries(ref list);
if (Alive)
{
@ -1945,17 +1950,17 @@ namespace Server.Mobiles
if (theirParty == null && ourParty == null)
{
list.Add(new AddToPartyEntry(from, this));
list.Add(new AddToPartyEntry());
}
else if (theirParty != null && theirParty.Leader == from)
{
if (ourParty == null)
{
list.Add(new AddToPartyEntry(from, this));
list.Add(new AddToPartyEntry());
}
else if (ourParty == theirParty)
{
list.Add(new RemoveFromPartyEntry(from, this));
list.Add(new RemoveFromPartyEntry());
}
}
}
@ -1965,7 +1970,7 @@ namespace Server.Mobiles
if (curhouse != null && Alive && Core.Expansion >= Expansion.AOS && curhouse.IsAosRules &&
curhouse.IsFriend(from))
{
list.Add(new EjectPlayerEntry(from, this));
list.Add(new EjectPlayerEntry());
}
}
}
@ -4649,7 +4654,7 @@ namespace Server.Mobiles
public CallbackEntry(int number, int range, ContextCallback callback) : base(number, range) =>
m_Callback = callback;
public override void OnClick()
public override void OnClick(Mobile from, IEntity target)
{
m_Callback?.Invoke();
}