d8a64f3316
## Summary Removes the dated `DynamicJson` JSON helper and migrates spawner JSON (de)serialization to a polymorphic `record SpawnerDto` hierarchy. `DynamicJson` was the last remaining consumer (regions moved off it in #1400). The key correctness improvement: **System.Text.Json deserializes plain DTO records, never a live `Item`.** Previously, deserializing directly into an `Item` meant STJ constructed world-registered objects *before* the data was validated — a malformed/hand-edited spawn file could leave orphaned spawner Items in the world save. Now a parse failure is GC-only; `dto.ToSpawner()` constructs the spawner only from a fully-validated DTO and self-cleans on failure. ## What changed - **New:** `SpawnerDto` (abstract) + `SpawnerDataDto` / `RegionSpawnerDto` / `ProximitySpawnerDto`, each marked with a reusable `[JsonDiscoverableType]` opt-in attribute. Auto-discovered at the `Configure` phase — no manual registration list (avoids the regions `Register<T>()` footgun), open to custom spawner subtypes. - **Symmetric mapping:** `BaseSpawner.ToDto()` (export) ⇄ `SpawnerDto.ToSpawner()` (import). `ToSpawner()` deletes-and-rethrows on any failure, so the importer can never orphan an Item. - **`SpawnerJsonSerializer`** wires `$type` polymorphism on the `SpawnerDto` root with loud collision/constructibility validation. - **Import/export commands** rewired to the typed DTO path (reflection `FindTypeByName`/`CreateInstance` removed). - **Data migration:** the 109 `Distribution/Data/Spawns/**` files moved from `"type"`→`"$type"` and legacy `homeRange`→`spawnBounds`. The runtime still *reads* legacy `homeRange` for external files. The `homeRange→spawnBounds` formula is proven equivalent to the runtime conversion (`BoundsEquivalenceTests`, hr=0/1/3/7). - **Deleted:** `Projects/Server/Json/DynamicJson.cs`. Sparse export output matches the legacy `ToJson` (nullable DTO properties + `WhenWritingNull`). Binary world-save serialization is untouched. ## Tests - DTO round-trip per spawner type; sparse-default omission; legacy `homeRange` read; export/import file round-trip. - `Import_MalformedFile_LeaksNoWorldItems` — proves a mid-array parse failure constructs zero world Items. - `AllSpawnFilesLoadTests` — every migrated spawn file deserializes and builds. - Duplicate-discriminator validation. - UOContent.Tests 485/485, Server.Tests 710/710, build clean. ## Follow-up (not in this PR) `Rectangle3DConverter.Write` (in `Projects/Server/`) omits `z1/z2` when `Start.Z == -128`, so a future server-side export of a `homeRange`-style spawner round-trips depth 256→255. Pre-existing and out of scope here (Server change); the migrated data reads correctly. Worth a separate small converter PR.
151 lines
4.4 KiB
JSON
151 lines
4.4 KiB
JSON
[
|
|
{
|
|
"$type": "Spawner",
|
|
"guid": "163c83bd-e63d-4654-8c0e-231486150f45",
|
|
"name": "Spawner (201)",
|
|
"location": [6540, 872, 0],
|
|
"map": "Felucca",
|
|
"count": 1,
|
|
"minDelay": "00:05:00",
|
|
"maxDelay": "00:10:00",
|
|
"team": 0,
|
|
"homeRange": 5,
|
|
"walkingRange": 5,
|
|
"entries": [
|
|
{ "name": "InsaneDryad", "maxCount": 1, "probability": 100 }
|
|
]
|
|
},
|
|
{
|
|
"$type": "Spawner",
|
|
"guid": "196961bc-de35-4e5c-9fbf-079ab5092d5f",
|
|
"name": "Spawner (201)",
|
|
"location": [6518, 879, 0],
|
|
"map": "Felucca",
|
|
"count": 1,
|
|
"minDelay": "00:05:00",
|
|
"maxDelay": "00:10:00",
|
|
"team": 0,
|
|
"homeRange": 5,
|
|
"walkingRange": 5,
|
|
"entries": [
|
|
{ "name": "InsaneDryad", "maxCount": 1, "probability": 100 }
|
|
]
|
|
},
|
|
{
|
|
"$type": "Spawner",
|
|
"guid": "3bd66ec7-4d6b-46cb-8913-5c62344510c0",
|
|
"name": "Spawner (201)",
|
|
"location": [6507, 843, 0],
|
|
"map": "Felucca",
|
|
"count": 8,
|
|
"minDelay": "00:05:00",
|
|
"maxDelay": "00:10:00",
|
|
"team": 0,
|
|
"homeRange": 10,
|
|
"walkingRange": 10,
|
|
"entries": [
|
|
{ "name": "Tangle", "maxCount": 8, "probability": 100 },
|
|
{ "name": "Bogling", "maxCount": 8, "probability": 100 },
|
|
{ "name": "Alligator", "maxCount": 8, "probability": 100 },
|
|
{ "name": "Reaper", "maxCount": 8, "probability": 100 },
|
|
{ "name": "Corpser", "maxCount": 8, "probability": 100 },
|
|
{ "name": "Changeling", "maxCount": 8, "probability": 100 },
|
|
{ "name": "WhippingVine", "maxCount": 8, "probability": 100 }
|
|
]
|
|
},
|
|
{
|
|
"$type": "Spawner",
|
|
"guid": "687f8c07-43c4-4724-8ede-078862373736",
|
|
"name": "Spawner (201)",
|
|
"location": [6535, 848, 0],
|
|
"map": "Felucca",
|
|
"count": 4,
|
|
"minDelay": "00:05:00",
|
|
"maxDelay": "00:10:00",
|
|
"team": 0,
|
|
"homeRange": 10,
|
|
"walkingRange": 10,
|
|
"entries": [
|
|
{ "name": "Abscess", "maxCount": 4, "probability": 100 },
|
|
{ "name": "Hydra", "maxCount": 4, "probability": 100 },
|
|
{ "name": "BogThing", "maxCount": 4, "probability": 100 }
|
|
]
|
|
},
|
|
{
|
|
"$type": "Spawner",
|
|
"guid": "9b045049-0b03-4f18-9148-b0bd1fa3600b",
|
|
"name": "Spawner (201)",
|
|
"location": [6489, 897, 0],
|
|
"map": "Felucca",
|
|
"count": 1,
|
|
"minDelay": "00:05:00",
|
|
"maxDelay": "00:10:00",
|
|
"team": 0,
|
|
"homeRange": 5,
|
|
"walkingRange": 5,
|
|
"entries": [
|
|
{ "name": "InsaneDryad", "maxCount": 1, "probability": 100 }
|
|
]
|
|
},
|
|
{
|
|
"$type": "Spawner",
|
|
"guid": "c6dedce5-b3a9-4510-b8a4-4e1be285305c",
|
|
"name": "Spawner (201)",
|
|
"location": [6513, 871, 0],
|
|
"map": "Felucca",
|
|
"count": 17,
|
|
"minDelay": "00:05:00",
|
|
"maxDelay": "00:10:00",
|
|
"team": 0,
|
|
"homeRange": 35,
|
|
"walkingRange": 35,
|
|
"entries": [
|
|
{ "name": "GiantSerpent", "maxCount": 17, "probability": 100 },
|
|
{ "name": "GiantToad", "maxCount": 17, "probability": 100 },
|
|
{ "name": "Harpy", "maxCount": 17, "probability": 100 },
|
|
{ "name": "SilverSerpent", "maxCount": 17, "probability": 100 },
|
|
{ "name": "Snake", "maxCount": 17, "probability": 100 },
|
|
{ "name": "Bogling", "maxCount": 17, "probability": 100 }
|
|
]
|
|
},
|
|
{
|
|
"$type": "Spawner",
|
|
"guid": "d4583e64-cac2-49f5-bb09-86c9481e0147",
|
|
"name": "Spawner (201)",
|
|
"location": [6518, 870, 0],
|
|
"map": "Felucca",
|
|
"count": 9,
|
|
"minDelay": "00:05:00",
|
|
"maxDelay": "00:10:00",
|
|
"team": 0,
|
|
"homeRange": 40,
|
|
"walkingRange": 40,
|
|
"entries": [
|
|
{ "name": "Thrasher", "maxCount": 9, "probability": 100 },
|
|
{ "name": "SwampTentacle", "maxCount": 9, "probability": 100 },
|
|
{ "name": "Reaper", "maxCount": 9, "probability": 100 },
|
|
{ "name": "Bogling", "maxCount": 9, "probability": 100 },
|
|
{ "name": "Alligator", "maxCount": 9, "probability": 100 },
|
|
{ "name": "Coil", "maxCount": 9, "probability": 100 },
|
|
{ "name": "WhippingVine", "maxCount": 9, "probability": 100 }
|
|
]
|
|
},
|
|
{
|
|
"$type": "Spawner",
|
|
"guid": "f708c05a-1da4-4452-8d8b-1965849d6e39",
|
|
"name": "Spawner (201)",
|
|
"location": [6585, 878, 0],
|
|
"map": "Felucca",
|
|
"count": 7,
|
|
"minDelay": "00:05:00",
|
|
"maxDelay": "00:10:00",
|
|
"team": 0,
|
|
"homeRange": 10,
|
|
"walkingRange": 10,
|
|
"entries": [
|
|
{ "name": "Harpy", "maxCount": 7, "probability": 100 },
|
|
{ "name": "Saliva", "maxCount": 7, "probability": 100 },
|
|
{ "name": "Changeling", "maxCount": 7, "probability": 100 }
|
|
]
|
|
}
|
|
]
|