c7aaf33de9
## Summary Phase #3b (final roadmap item), stacked on #2470. Compacts the index trailer from 20 to 8 bytes/chunk. Trammel: 19.2 MB → 17.9 MB. Roadmap total: 565 MB → 17.9 MB (−96.8%). ## Details - Trailer stores `{ u32 packedKey = (ChunkX << 16) | ChunkY, u32 recordLength }` per chunk, in record write order; the file offset is dropped and reconstructed by cumulative recordLength from HeaderSize. - No record reordering, no varint; fixed-stride, TryReadChunk unchanged. - Also simplifies the accumulated `.swb` code comments across the stack. - Format v8; v7 files rejected and re-baked once. ## Tests v8 multi-chunk round-trip (cumulative offset reconstruction) + the v6/v7 suite; full pathfinding suite green; Release build clean.
581 lines
16 KiB
C#
581 lines
16 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
using System.Runtime.CompilerServices;
|
|
using Server.Items;
|
|
using Server.Mobiles;
|
|
|
|
namespace Server.Movement;
|
|
|
|
public class MovementImpl : IMovementImpl
|
|
{
|
|
private const int PersonHeight = 16;
|
|
private const int StepHeight = 2;
|
|
|
|
private const TileFlag ImpassableSurface = TileFlag.Impassable | TileFlag.Surface;
|
|
|
|
private static Point3D _goal;
|
|
|
|
public static void Configure()
|
|
{
|
|
Movement.Impl = new MovementImpl();
|
|
}
|
|
|
|
private readonly List<Mobile>[] _mobPools = { new(), new(), new() };
|
|
|
|
private readonly List<Item>[] _pools = { new(), new(), new(), new() };
|
|
|
|
private MovementImpl()
|
|
{
|
|
}
|
|
|
|
public static bool AlwaysIgnoreDoors { get; set; }
|
|
public static bool IgnoreMovableImpassables { get; set; }
|
|
|
|
public static Point3D Goal
|
|
{
|
|
get => _goal;
|
|
set => _goal = value;
|
|
}
|
|
|
|
public bool CheckMovement(Mobile m, Map map, Point3D loc, Direction d, out int newZ)
|
|
{
|
|
if (map == null || map == Map.Internal)
|
|
{
|
|
newZ = 0;
|
|
return false;
|
|
}
|
|
|
|
var xStart = loc.X;
|
|
var yStart = loc.Y;
|
|
|
|
int xForward = xStart, yForward = yStart;
|
|
int xRight = xStart, yRight = yStart;
|
|
int xLeft = xStart, yLeft = yStart;
|
|
|
|
var checkDiagonals = ((int)d & 0x1) == 0x1;
|
|
|
|
Movement.Offset(d, ref xForward, ref yForward);
|
|
Movement.Offset((Direction)(((int)d - 1) & 0x7), ref xLeft, ref yLeft);
|
|
Movement.Offset((Direction)(((int)d + 1) & 0x7), ref xRight, ref yRight);
|
|
|
|
if (xForward < 0 || yForward < 0 || xForward >= map.Width || yForward >= map.Height)
|
|
{
|
|
newZ = 0;
|
|
return false;
|
|
}
|
|
|
|
var itemsStart = _pools[0];
|
|
var itemsForward = _pools[1];
|
|
var itemsLeft = _pools[2];
|
|
var itemsRight = _pools[3];
|
|
|
|
var ignoreMovableImpassables = IgnoreMovableImpassables;
|
|
var reqFlags = ImpassableSurface;
|
|
|
|
if (m.CanSwim)
|
|
{
|
|
reqFlags |= TileFlag.Wet;
|
|
}
|
|
|
|
var mobsForward = _mobPools[0];
|
|
var mobsLeft = _mobPools[1];
|
|
var mobsRight = _mobPools[2];
|
|
|
|
var checkMobs = (m as BaseCreature)?.Controlled == false && (xForward != _goal.X || yForward != _goal.Y);
|
|
|
|
if (checkMobs)
|
|
{
|
|
foreach (var mob in map.GetMobilesInRange(loc, 1))
|
|
{
|
|
if (mob.AtPoint(xForward, yForward))
|
|
{
|
|
mobsForward.Add(mob);
|
|
}
|
|
else if (checkDiagonals && mob.AtPoint(xLeft, yLeft))
|
|
{
|
|
mobsLeft.Add(mob);
|
|
}
|
|
else if (checkDiagonals && mob.AtPoint(xRight, yRight))
|
|
{
|
|
mobsRight.Add(mob);
|
|
}
|
|
}
|
|
}
|
|
|
|
foreach (var item in map.GetItemsInRange(loc, 1))
|
|
{
|
|
if (ignoreMovableImpassables && item.Movable && item.ItemData.ImpassableSurface)
|
|
{
|
|
continue;
|
|
}
|
|
|
|
if (!item.ItemData[reqFlags] || item.ItemID > TileData.MaxItemValue || item.Parent != null)
|
|
{
|
|
continue;
|
|
}
|
|
|
|
if (item is BaseMulti)
|
|
{
|
|
continue;
|
|
}
|
|
|
|
if (item.AtPoint(xStart, yStart))
|
|
{
|
|
itemsStart.Add(item);
|
|
}
|
|
else if (item.AtPoint(xForward, yForward))
|
|
{
|
|
itemsForward.Add(item);
|
|
}
|
|
else if (checkDiagonals && item.AtPoint(xLeft, yLeft))
|
|
{
|
|
itemsLeft.Add(item);
|
|
}
|
|
else if (checkDiagonals && item.AtPoint(xRight, yRight))
|
|
{
|
|
itemsRight.Add(item);
|
|
}
|
|
}
|
|
|
|
GetStartZ(m, map, loc, itemsStart, out var startZ, out var startTop);
|
|
|
|
var moveIsOk = Check(map, m, itemsForward, mobsForward, xForward, yForward, startTop, startZ, out newZ);
|
|
|
|
if (moveIsOk && checkDiagonals)
|
|
{
|
|
if (m.Player && m.AccessLevel < AccessLevel.GameMaster)
|
|
{
|
|
if (!Check(map, m, itemsLeft, mobsLeft, xLeft, yLeft, startTop, startZ, out _) ||
|
|
!Check(map, m, itemsRight, mobsRight, xRight, yRight, startTop, startZ, out _))
|
|
{
|
|
moveIsOk = false;
|
|
}
|
|
}
|
|
else
|
|
{
|
|
if (!Check(map, m, itemsLeft, mobsLeft, xLeft, yLeft, startTop, startZ, out _) &&
|
|
!Check(map, m, itemsRight, mobsRight, xRight, yRight, startTop, startZ, out _))
|
|
{
|
|
moveIsOk = false;
|
|
}
|
|
}
|
|
}
|
|
|
|
for (int i = 0, c = checkDiagonals ? 4 : 2; i < c; ++i)
|
|
{
|
|
_pools[i].Clear();
|
|
}
|
|
|
|
for (int i = 0, c = checkDiagonals ? 3 : 1; i < c; ++i)
|
|
{
|
|
_mobPools[i].Clear();
|
|
}
|
|
|
|
if (!moveIsOk)
|
|
{
|
|
newZ = startZ;
|
|
}
|
|
|
|
return moveIsOk;
|
|
}
|
|
|
|
[MethodImpl(MethodImplOptions.AggressiveInlining)]
|
|
public bool CheckMovement(Mobile m, Direction d, out int newZ) => CheckMovement(m, m.Map, m.Location, d, out newZ);
|
|
|
|
private static bool IsOk(
|
|
bool ignoreDoors, bool ignoreSpellFields, int ourZ, int ourTop, Map map, int x, int y, List<Item> items
|
|
)
|
|
{
|
|
foreach (var check in map.Tiles.GetStaticAndMultiTiles(x, y))
|
|
{
|
|
var itemData = TileData.ItemTable[check.ID & TileData.MaxItemValue];
|
|
|
|
if (itemData.ImpassableSurface)
|
|
{
|
|
var checkZ = check.Z;
|
|
var checkTop = checkZ + itemData.CalcHeight;
|
|
|
|
if (checkTop > ourZ && ourTop > checkZ)
|
|
{
|
|
return false;
|
|
}
|
|
}
|
|
}
|
|
|
|
for (var i = 0; i < items.Count; ++i)
|
|
{
|
|
var item = items[i];
|
|
var itemID = item.ItemID & TileData.MaxItemValue;
|
|
var itemData = TileData.ItemTable[itemID];
|
|
|
|
if (itemData.ImpassableSurface)
|
|
{
|
|
if (ignoreDoors && (itemData.Door || itemID is 0x692 or 0x846 or 0x873 || itemID >= 0x6F5 && itemID <= 0x6F6))
|
|
{
|
|
continue;
|
|
}
|
|
|
|
if (ignoreSpellFields && itemID is 0x82 or 0x3946 or 0x3956)
|
|
{
|
|
continue;
|
|
}
|
|
|
|
var checkZ = item.Z;
|
|
var checkTop = checkZ + itemData.CalcHeight;
|
|
|
|
if (checkTop > ourZ && ourTop > checkZ)
|
|
{
|
|
return false;
|
|
}
|
|
}
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
private static bool Check(
|
|
Map map,
|
|
Mobile m,
|
|
List<Item> items,
|
|
List<Mobile> mobiles,
|
|
int x,
|
|
int y,
|
|
int startTop,
|
|
int startZ,
|
|
out int newZ
|
|
)
|
|
{
|
|
newZ = 0;
|
|
|
|
var cantWalk = m.CantWalk;
|
|
var canSwim = m.CanSwim;
|
|
var landTile = map.Tiles.GetLandTile(x, y);
|
|
var flags = TileData.LandTable[landTile.ID & TileData.MaxLandValue].Flags;
|
|
var impassable = (flags & TileFlag.Impassable) != 0;
|
|
|
|
// Impassable + swim on water is ok, otherwise block if cannot walk or impassable
|
|
var landBlocks = (cantWalk || impassable) && !(impassable && canSwim && (flags & TileFlag.Wet) != 0);
|
|
|
|
var considerLand = !landTile.Ignored;
|
|
|
|
map.GetAverageZ(x, y, out var landZ, out var landCenter, out _);
|
|
|
|
var moveIsOk = false;
|
|
|
|
var stepTop = startTop + StepHeight;
|
|
var checkTop = startZ + PersonHeight;
|
|
|
|
var ignoreDoors = AlwaysIgnoreDoors || !m.Alive || m.Body.BodyID == 0x3DB || m.IsDeadBondedPet;
|
|
var ignoreSpellFields = m is PlayerMobile && map != Map.Felucca;
|
|
|
|
int testTop;
|
|
|
|
foreach (var tile in map.Tiles.GetStaticAndMultiTiles(x, y))
|
|
{
|
|
var itemData = TileData.ItemTable[tile.ID & TileData.MaxItemValue];
|
|
|
|
if (m.Flying && itemData.Name.InsensitiveEquals("hover over"))
|
|
{
|
|
newZ = tile.Z;
|
|
return true;
|
|
}
|
|
|
|
// Stygian Dragon
|
|
if (m.Body == 826 && map == Map.TerMur)
|
|
{
|
|
if (x is >= 307 and <= 354 && y is >= 126 and <= 192)
|
|
{
|
|
if (tile.Z > newZ)
|
|
{
|
|
newZ = tile.Z;
|
|
}
|
|
|
|
moveIsOk = true;
|
|
}
|
|
else if (x is >= 42 and <= 89 && y is >= 333 and <= 399 or >= 531 and <= 597 or >= 739 and <= 805)
|
|
{
|
|
if (tile.Z > newZ)
|
|
{
|
|
newZ = tile.Z;
|
|
}
|
|
|
|
moveIsOk = true;
|
|
}
|
|
}
|
|
|
|
var notWater = !itemData.Wet;
|
|
|
|
/*
|
|
* To move we must satisfy the following:
|
|
* 1. Item is a _passable_ surface and Mob can walk -or-
|
|
* 2. Item is water and Mob can swim
|
|
*/
|
|
if (
|
|
(!itemData.Surface || itemData.Impassable) && (!canSwim || notWater) ||
|
|
cantWalk && notWater
|
|
)
|
|
{
|
|
continue;
|
|
}
|
|
|
|
var itemZ = tile.Z;
|
|
var itemTop = itemZ;
|
|
var ourZ = itemZ + itemData.CalcHeight;
|
|
testTop = checkTop;
|
|
|
|
if (moveIsOk)
|
|
{
|
|
var cmp = (ourZ - m.Z).Abs() - (newZ - m.Z).Abs();
|
|
|
|
if (cmp > 0 || cmp == 0 && ourZ > newZ)
|
|
{
|
|
continue;
|
|
}
|
|
}
|
|
|
|
if (ourZ + PersonHeight > testTop)
|
|
{
|
|
testTop = ourZ + PersonHeight;
|
|
}
|
|
|
|
if (!itemData.Bridge)
|
|
{
|
|
itemTop += itemData.Height;
|
|
}
|
|
|
|
if (stepTop < itemTop)
|
|
{
|
|
continue;
|
|
}
|
|
|
|
var landCheck = itemZ + Math.Min(itemData.Height, StepHeight);
|
|
|
|
if (considerLand && landCheck < landCenter && landCenter > ourZ && testTop > landZ)
|
|
{
|
|
continue;
|
|
}
|
|
|
|
if (IsOk(ignoreDoors, ignoreSpellFields, ourZ, testTop, map, x, y, items))
|
|
{
|
|
newZ = ourZ;
|
|
moveIsOk = true;
|
|
}
|
|
}
|
|
|
|
for (var i = 0; i < items.Count; ++i)
|
|
{
|
|
var item = items[i];
|
|
var itemData = item.ItemData;
|
|
|
|
if (m.Flying && itemData.Name.InsensitiveEquals("hover over"))
|
|
{
|
|
newZ = item.Z;
|
|
return true;
|
|
}
|
|
|
|
var notWater = !itemData.Wet;
|
|
|
|
/*
|
|
* To move we must satisfy the following:
|
|
* 1. Item is not movable
|
|
* 2. Item is a _passable_ surface and Mob can walk -or-
|
|
* Item is water and Mob can swim
|
|
*/
|
|
if (
|
|
item.Movable ||
|
|
(!itemData.Surface || itemData.Impassable) && (!canSwim || notWater) ||
|
|
cantWalk && notWater
|
|
)
|
|
{
|
|
continue;
|
|
}
|
|
|
|
var itemZ = item.Z;
|
|
var itemTop = itemZ;
|
|
var ourZ = itemZ + itemData.CalcHeight;
|
|
testTop = checkTop;
|
|
|
|
if (moveIsOk)
|
|
{
|
|
var cmp = (ourZ - m.Z).Abs() - (newZ - m.Z).Abs();
|
|
|
|
if (cmp > 0 || cmp == 0 && ourZ > newZ)
|
|
{
|
|
continue;
|
|
}
|
|
}
|
|
|
|
if (ourZ + PersonHeight > testTop)
|
|
{
|
|
testTop = ourZ + PersonHeight;
|
|
}
|
|
|
|
if (!itemData.Bridge)
|
|
{
|
|
itemTop += itemData.Height;
|
|
}
|
|
|
|
if (stepTop < itemTop)
|
|
{
|
|
continue;
|
|
}
|
|
|
|
var landCheck = itemZ + Math.Min(itemData.Height, StepHeight);
|
|
|
|
if (considerLand && landCheck < landCenter && landCenter > ourZ && testTop > landZ)
|
|
{
|
|
continue;
|
|
}
|
|
|
|
if (IsOk(ignoreDoors, ignoreSpellFields, ourZ, testTop, map, x, y, items))
|
|
{
|
|
newZ = ourZ;
|
|
moveIsOk = true;
|
|
}
|
|
}
|
|
|
|
if (!considerLand || landBlocks || stepTop < landZ)
|
|
{
|
|
return moveIsOk;
|
|
}
|
|
|
|
testTop = checkTop;
|
|
|
|
if (landCenter + PersonHeight > testTop)
|
|
{
|
|
testTop = landCenter + PersonHeight;
|
|
}
|
|
|
|
var shouldCheck = true;
|
|
|
|
if (moveIsOk)
|
|
{
|
|
var cmp = (landCenter - m.Z).Abs() - (newZ - m.Z).Abs();
|
|
|
|
if (cmp > 0 || cmp == 0 && landCenter > newZ)
|
|
{
|
|
shouldCheck = false;
|
|
}
|
|
}
|
|
|
|
if (shouldCheck && IsOk(ignoreDoors, ignoreSpellFields, landCenter, testTop, map, x, y, items))
|
|
{
|
|
newZ = landCenter;
|
|
moveIsOk = true;
|
|
}
|
|
|
|
if (moveIsOk)
|
|
{
|
|
for (var i = 0; moveIsOk && i < mobiles.Count; ++i)
|
|
{
|
|
var mob = mobiles[i];
|
|
|
|
if (mob != m && mob.Z + 15 > newZ && newZ + 15 > mob.Z && !CanMoveOver(m, mob))
|
|
{
|
|
moveIsOk = false;
|
|
}
|
|
}
|
|
}
|
|
|
|
return moveIsOk;
|
|
}
|
|
|
|
[MethodImpl(MethodImplOptions.AggressiveInlining)]
|
|
private static bool CanMoveOver(Mobile m, Mobile t) =>
|
|
!t.Alive || !m.Alive || t.IsDeadBondedPet || m.IsDeadBondedPet || t.Hidden && t.AccessLevel > AccessLevel.Player;
|
|
|
|
private static void GetStartZ(Mobile m, Map map, Point3D loc, List<Item> itemList, out int zLow, out int zTop)
|
|
{
|
|
int xCheck = loc.X, yCheck = loc.Y;
|
|
|
|
var landTile = map.Tiles.GetLandTile(xCheck, yCheck);
|
|
var flags = TileData.LandTable[landTile.ID & TileData.MaxLandValue].Flags;
|
|
var impassable = (flags & TileFlag.Impassable) != 0;
|
|
|
|
// Impassable + swim on water is ok, otherwise block if cannot walk or impassable
|
|
var landBlocks = (m.CantWalk || impassable) && !(impassable && m.CanSwim && (flags & TileFlag.Wet) != 0);
|
|
|
|
map.GetAverageZ(xCheck, yCheck, out var landZ, out var landCenter, out var landTop);
|
|
|
|
var considerLand = !landTile.Ignored;
|
|
|
|
var zCenter = zLow = zTop = 0;
|
|
var isSet = false;
|
|
|
|
if (considerLand && !landBlocks && loc.Z >= landCenter)
|
|
{
|
|
zLow = landZ;
|
|
zCenter = landCenter;
|
|
|
|
zTop = landTop;
|
|
|
|
isSet = true;
|
|
}
|
|
|
|
foreach (var tile in map.Tiles.GetStaticAndMultiTiles(xCheck, yCheck))
|
|
{
|
|
var id = TileData.ItemTable[tile.ID & TileData.MaxItemValue];
|
|
var calcTop = tile.Z + id.CalcHeight;
|
|
|
|
if (isSet && calcTop < zCenter || loc.Z < calcTop || !id.Surface && !(m.CanSwim && id.Wet))
|
|
{
|
|
continue;
|
|
}
|
|
|
|
if (m.CantWalk && !id.Wet)
|
|
{
|
|
continue;
|
|
}
|
|
|
|
zLow = tile.Z;
|
|
zCenter = calcTop;
|
|
|
|
var top = tile.Z + id.Height;
|
|
|
|
if (!isSet || top > zTop)
|
|
{
|
|
zTop = top;
|
|
}
|
|
|
|
isSet = true;
|
|
}
|
|
|
|
for (var i = 0; i < itemList.Count; ++i)
|
|
{
|
|
var item = itemList[i];
|
|
var id = item.ItemData;
|
|
var calcTop = item.Z + id.CalcHeight;
|
|
|
|
if (isSet && calcTop < zCenter || loc.Z < calcTop || !id.Surface && !(m.CanSwim && id.Wet))
|
|
{
|
|
continue;
|
|
}
|
|
|
|
if (m.CantWalk && !id.Wet)
|
|
{
|
|
continue;
|
|
}
|
|
|
|
zLow = item.Z;
|
|
zCenter = calcTop;
|
|
|
|
var top = item.Z + id.Height;
|
|
|
|
if (!isSet || top > zTop)
|
|
{
|
|
zTop = top;
|
|
}
|
|
|
|
isSet = true;
|
|
}
|
|
|
|
if (!isSet)
|
|
{
|
|
zLow = zTop = loc.Z;
|
|
}
|
|
else if (loc.Z > zTop)
|
|
{
|
|
zTop = loc.Z;
|
|
}
|
|
}
|
|
}
|