9a25054809
## Summary Many tests proved a specific change when it landed but don't need to run on every CI build forever. This removes **202 test methods and 9 files: 313 test cases, 2,247 → 1,934**. UOContent.Tests drops from about 14s to about 5s locally. Removed: - **Tautologies.** Asserting a constant, a constructor readback or a trivial getter, or testing BCL behavior. - **Exact duplicates** of a surviving test on the same code path. - **Obsolete regressions** whose failure can no longer be expressed. - **Game-content values** shard owners customize (era drop rates, loot and skill tables, single-creature tuning). Each customization would otherwise force a test fix. ## How it was decided 1. Every test was classified, with a reason, by a per-shard sweep over all 287 test files. 2. Each proposed deletion was then checked by a second, adversarial reviewer against the surviving tests and the production code. 3. Anything that was the only coverage of a separate code path was **kept**, even where it looked like a duplicate. Examples: the unsigned `SpanReader`/`SpanWriter` methods, the at-location versus bounds enumerators, null-map enumerables, the security filters, archive-journal state transitions. About 130 proposed deletions were rejected this way. Whole files removed: - `FishingTests`, apart from 3 tests: the map-edge scan, serpent cleanup, and SOS chest consumption. The SOS test now stops at the first chest instead of measuring a catch rate. The multi-million-cast rate simulations are gone. - `LordOaksTests` and `MeerEnragedTests` (single-creature tests). - `AutoArchiveHelperTests`, `JsonDiscoverableTypeAttributeTests`, `DecimalSerializationTests` and `EnumConversionTests` (tautologies, or tests of their own local helpers). - `NetworkStatsTests`. - `MigratedDataLoadTests` (a subset of `AllSpawnFilesLoadTests`). - `SpawnerFixtureCapture`: a capture tool, not a test, and its `version == 12` assert can no longer pass. The `.bin` fixtures it produced stay. ## Tests - Server.Tests: 811 pass. - UOContent.Tests: 1,123 pass. A follow-up PR, stacked on this one, fixes how the remaining tests behave: shared state, CI-vacuous tests, harness duplication.
81 lines
2.6 KiB
C#
81 lines
2.6 KiB
C#
using Server.Engines.Pathing.Cache;
|
|
using Xunit;
|
|
using Xunit.Abstractions;
|
|
|
|
namespace Server.Tests.Pathfinding;
|
|
|
|
[Collection("Sequential Pathfinding Tests")]
|
|
public class StepProbeTests
|
|
{
|
|
private readonly ITestOutputHelper _output;
|
|
|
|
public StepProbeTests(ITestOutputHelper output)
|
|
{
|
|
_output = output;
|
|
}
|
|
|
|
[Fact]
|
|
public void ComputeMaskAt_NullMap_ReturnsDefault()
|
|
{
|
|
var result = StepProbe.ComputeMaskAt(null, 100, 100, 0);
|
|
|
|
Assert.Equal(0, result.WalkMask);
|
|
for (var d = 0; d < 8; d++)
|
|
{
|
|
Assert.Equal(0, result.GetWalkZ((Direction)d));
|
|
}
|
|
}
|
|
|
|
[Fact]
|
|
public void ComputeMaskAt_InternalMap_ReturnsDefault()
|
|
{
|
|
var result = StepProbe.ComputeMaskAt(Map.Internal, 100, 100, 0);
|
|
|
|
Assert.Equal(0, result.WalkMask);
|
|
for (var d = 0; d < 8; d++)
|
|
{
|
|
Assert.Equal(0, result.GetWalkZ((Direction)d));
|
|
}
|
|
}
|
|
|
|
[Fact]
|
|
public void ComputeMaskAt_TopLeftCorner_OffMapDirectionsBlocked()
|
|
{
|
|
// From source (0, 0), these neighbor cells are off-map and MUST be blocked,
|
|
// regardless of map content:
|
|
// N = (0, -1) bit 0
|
|
// NE = (1, -1) bit 1
|
|
// SW = (-1, 1) bit 5
|
|
// W = (-1, 0) bit 6
|
|
// NW = (-1, -1) bit 7
|
|
// Bits 2 (E), 3 (SE), 4 (S) depend on map content and aren't asserted.
|
|
var map = Map.Maps[1];
|
|
Assert.NotNull(map);
|
|
|
|
var result = StepProbe.ComputeMaskAt(map, 0, 0, 0);
|
|
|
|
Assert.False(result.IsWalkable(Direction.North), "N should be off-map");
|
|
Assert.False(result.IsWalkable(Direction.Right), "NE should be off-map");
|
|
Assert.False(result.IsWalkable(Direction.Left), "SW should be off-map");
|
|
Assert.False(result.IsWalkable(Direction.West), "W should be off-map");
|
|
Assert.False(result.IsWalkable(Direction.Up), "NW should be off-map");
|
|
}
|
|
|
|
[Fact]
|
|
public void ComputeMaskAt_BottomRightCorner_OffMapDirectionsBlocked()
|
|
{
|
|
var map = Map.Maps[1];
|
|
Assert.NotNull(map);
|
|
|
|
var x = map.Width - 1;
|
|
var y = map.Height - 1;
|
|
var result = StepProbe.ComputeMaskAt(map, x, y, 0);
|
|
|
|
// From the SE corner, S/SE/SW/E/NE all go off-map (only N/NW/W in-map).
|
|
Assert.False(result.IsWalkable(Direction.Right), "NE should be off-map");
|
|
Assert.False(result.IsWalkable(Direction.East), "E should be off-map");
|
|
Assert.False(result.IsWalkable(Direction.Down), "SE should be off-map");
|
|
Assert.False(result.IsWalkable(Direction.South), "S should be off-map");
|
|
Assert.False(result.IsWalkable(Direction.Left), "SW should be off-map");
|
|
}
|
|
}
|