ModernUO/Projects/UOContent/Engines/Harvest/Core
Kamron Batman f77dd91811
fix: Overhauls virtue system (#1376)
## MAJOR CHANGE (API BREAKING)

Moved the virtues to it's own system _VirtueSystem_. This should make it easier to extend or remove the virtue system. Virtues will be saved to a new folder called _Virtues_.

### Motivation

The motivation was also two-fold, performance/stability, and to fix bugs.

First, virtues is the second system (first is murders), that has a pre-world-save check on _every mobile in the game_ to atrophy virtue stats. This is taxing since it freexes the world and makes world saves take longer. Every mobile had Gain/Loss dates for each virtue, whether they needed them or not. Most players don't even use the virtue system, so this will increase performance considerably.

Second, when I tried to optimize/refactor the code, I found several bugs that needed to be fixed.

### Major API Changes

- [X] The properties on players related to virtues are gone. Use `pm.GetVirtues()?.<PropertyName>` instead.
- [X] Virtues were removed from non-player Mobiles.
- [X] `pm.JusticeProtectors` was removed. Use `JusticeVirtue.GetProtector()` or `JusticeVirtue.GetProtected()` instead.

### Screenshots

<img width="221" alt="Props-1" src="https://github.com/modernuo/ModernUO/assets/3953314/5c09cb83-b8d5-44a2-b899-a7ed7cd736ac">
<img width="220" alt="props-2" src="https://github.com/modernuo/ModernUO/assets/3953314/aeade4d3-8df0-47bd-955a-a864d0946cf7">
2023-07-19 21:43:47 -07:00
..
BonusHarvestResource.cs feat: Adds TextDefinition serialization support. (#1217) 2022-10-30 01:42:48 -07:00
FurnitureAttribute.cs Formats UO Content (#201) 2020-08-27 18:30:38 -07:00
HarvestBank.cs fix(core): Caches DateTime.NowUtc (#548) 2021-03-13 01:32:04 -08:00
HarvestDefinition.cs fix: Overhauls virtue system (#1376) 2023-07-19 21:43:47 -07:00
HarvestResource.cs fix: Adds more null checks for text definition to prevent NPEs (#936) 2022-02-18 11:13:38 -08:00
HarvestSoundTimer.cs Fixes brace style (#248) 2020-09-13 21:49:46 -07:00
HarvestSystem.cs fix: Fixes the limitation on static tiles for harvesting (#1396) 2023-04-22 09:14:42 -07:00
HarvestTarget.cs chore: Cleans up pattern checks. (#892) 2021-12-24 15:53:59 -08:00
HarvestTimer.cs Fixes brace style (#248) 2020-09-13 21:49:46 -07:00
HarvestVein.cs Formats UO Content (#201) 2020-08-27 18:30:38 -07:00
IChoppable..cs Formats UO Content (#201) 2020-08-27 18:30:38 -07:00