10a69bf754
## Breaking Changes
Incoming packet registration signature has changed to:
```cs
delegate* void OnReceiveCallback(NetState state, SpanReader reader, int packetLength);
IncomingPackets.Register(int packetID, int length, bool ingame, OnReceiveCallback onReceive);
```
For example, an incoming packet handler signature would now look like this:
```cs
public static void SomeIncomingPacket(NetState state, SpanReader reader, int packetLength)
{
// Parse the data
}
```
## Summary
Updates the network Pipe class to use a mirrored memory technique. This technique involves mapping the same physical memory to two contiguous virtual memory spaces so the byte buffer appears duplicated. This allows writing to a double-sized array to wrap around without the need for the `CircularBuffer` classes.
In practice this allows us to use `Span<byte>` as if the buffer was a regular array.
### Bug Fixes
- [X] Fixes bad fixed length string parsing
69 lines
2.2 KiB
C#
69 lines
2.2 KiB
C#
using System;
|
|
using Server;
|
|
using Server.Items;
|
|
using Server.Network;
|
|
using Server.Tests;
|
|
using Server.Tests.Network;
|
|
using Xunit;
|
|
|
|
namespace UOContent.Tests
|
|
{
|
|
[Collection("Sequential Tests")]
|
|
public class BulletinBoardPacketTests : IClassFixture<ServerFixture>
|
|
{
|
|
[Theory]
|
|
[InlineData("Test Name")]
|
|
[InlineData(null)]
|
|
[InlineData("🅵🅰🅽🅲🆈 🆃🅴🆇🆃")]
|
|
public void TestSendBBDisplayBoard(string boardName)
|
|
{
|
|
var bb = new TestBulletinBoard(0x234) { BoardName = boardName };
|
|
|
|
var expected = new BBDisplayBoard(bb).Compile();
|
|
|
|
var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.SendBBDisplayBoard(bb);
|
|
|
|
var result = ns.SendPipe.Reader.AvailableToRead();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData("The Subject", false, "First Line", "Second Line", "Third Line")]
|
|
[InlineData("", false, "")]
|
|
[InlineData("🅵🅰🅽🅲🆈 🆃🅴🆇🆃", false, "First Line", "Second Line")]
|
|
[InlineData("The Subject", true, "First Line", "Second Line", "Third Line")]
|
|
[InlineData("", true, "")]
|
|
[InlineData("🅵🅰🅽🅲🆈 🆃🅴🆇🆃", true, "First Line", "Second Line")]
|
|
public void TestSendBBHeaderMessage(string subject, bool content, params string[] lines)
|
|
{
|
|
var poster = new Mobile((Serial)0x1024u) { Name = "Kamron" };
|
|
poster.DefaultMobileInit();
|
|
|
|
var bb = new TestBulletinBoard(0x234);
|
|
bb.PostMessage(poster, null, subject, lines);
|
|
|
|
var msg = bb.Items[0] as BulletinMessage;
|
|
|
|
var expected = (content ?
|
|
(Packet)new BBMessageContent(bb, msg) : new BBMessageHeader(bb, msg)).Compile();
|
|
|
|
var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.SendBBMessage(bb, msg, content);
|
|
|
|
var result = ns.SendPipe.Reader.AvailableToRead();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
}
|
|
|
|
internal class TestBulletinBoard : BaseBulletinBoard
|
|
{
|
|
public TestBulletinBoard(int itemID) : base(itemID)
|
|
{
|
|
}
|
|
|
|
public TestBulletinBoard(Serial serial) : base(serial)
|
|
{
|
|
}
|
|
}
|
|
}
|