10a69bf754
## Breaking Changes
Incoming packet registration signature has changed to:
```cs
delegate* void OnReceiveCallback(NetState state, SpanReader reader, int packetLength);
IncomingPackets.Register(int packetID, int length, bool ingame, OnReceiveCallback onReceive);
```
For example, an incoming packet handler signature would now look like this:
```cs
public static void SomeIncomingPacket(NetState state, SpanReader reader, int packetLength)
{
// Parse the data
}
```
## Summary
Updates the network Pipe class to use a mirrored memory technique. This technique involves mapping the same physical memory to two contiguous virtual memory spaces so the byte buffer appears duplicated. This allows writing to a double-sized array to wrap around without the need for the `CircularBuffer` classes.
In practice this allows us to use `Span<byte>` as if the buffer was a regular array.
### Bug Fixes
- [X] Fixes bad fixed length string parsing
43 lines
1.4 KiB
C#
43 lines
1.4 KiB
C#
using System;
|
|
using Server;
|
|
using Server.Network;
|
|
using Server.Tests;
|
|
using Server.Tests.Network;
|
|
using Xunit;
|
|
|
|
namespace UOContent.Tests
|
|
{
|
|
public class BuffIconPacketTests
|
|
{
|
|
[Theory]
|
|
[InlineData(0x1024u, BuffIcon.Clumsy, 500100, 300200, "123456", 8000)]
|
|
[InlineData(0x2048u, BuffIcon.Disguised, 500102, 300203, null, 9000)]
|
|
public void TestAddBuffIcon(uint mob, BuffIcon iconID, int titleCliloc, int secondaryCliloc, string args, int ts)
|
|
{
|
|
var timeSpan = new TimeSpan(ts);
|
|
var expected = new AddBuffPacket(
|
|
(Serial)mob, iconID, titleCliloc, secondaryCliloc, args, timeSpan
|
|
).Compile();
|
|
|
|
var ns = PacketTestUtilities.CreateTestNetState();
|
|
BuffInfo.SendAddBuffPacket(ns, (Serial)mob, iconID, titleCliloc, secondaryCliloc, args, (int)timeSpan.TotalMilliseconds);
|
|
|
|
var result = ns.SendPipe.Reader.AvailableToRead();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Fact]
|
|
public void TestRemoveBuffIcon()
|
|
{
|
|
Serial m = (Serial)0x1024;
|
|
var buffIcon = BuffIcon.Disguised;
|
|
var expected = new RemoveBuffPacket(m, buffIcon).Compile();
|
|
|
|
var ns = PacketTestUtilities.CreateTestNetState();
|
|
BuffInfo.SendRemoveBuffPacket(ns, m, buffIcon);
|
|
|
|
var result = ns.SendPipe.Reader.AvailableToRead();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
}
|
|
}
|