ModernUO/Projects/UOContent/Mobiles/Monsters/Misc/Melee/Golem.cs
Kamron Batman 843a29e7dc
refactor: master views over BaseCreature's one master reference (#2674)
## Summary

After #2670, `BaseCreature` stores one master. Callers still reached it through three differently gated names plus hand-rolled combinations of the `Controlled`/`Summoned` flags. Each gate is now one named view:

| Member | Definition | Meaning |
|---|---|---|
| `Master` | the reference; its setter does the follower bookkeeping; serialized as before | whoever the creature answers to |
| `ControlMaster` | `Controlled ? Master : null` | the owner |
| `SummonMaster` | `Summoned ? Master : null` | the summoner |
| `GetMaster()` | `ControlMaster ?? SummonMaster` | who answers for the creature |

`ControlMaster` and `SummonMaster` stay settable so custom code keeps compiling: both setters assign `Master`. There is no guard, so a write through either one can read back as null until the matching flag is set.

An enraged creature is the one shape with a master and neither flag. It keeps its meer through `Master`, while `GetMaster()` stays null, so the meer never answers for it (notoriety, kill credit).

Readers move onto the view they mean:
- "Owner or summoner" pairs and `ControlMaster ?? SummonMaster` collapse into `GetMaster()`: pack instinct, familiars, golem, house access, mounts, pack horse, Solen friendship, spell target and guild checks, and the `[` pet command.
- Checks such as `Controlled && ControlMaster == from` drop the flag the view already applies. Checks that don't reduce keep it: `Controlled && ControlMaster != from`, a possibly-null `from`, and `MageAI.CanDispel`'s `Summoned &&`.

**No behavior change, save format unchanged** (the schema generator produces no diff). Edge cases for custom code and shard operators:
- `SummonMaster = x` on a plain pet now replaces its owner (#2670 made that a no-op), and `ControlMaster = null` on an uncontrolled summon now clears its caster (it did nothing before).
- `SpellHelper.GetGuildFor` no longer falls back to an enraged creature's meer. Meer mages have no guild.

## Docs

- `dev-docs/content-patterns.md` § Masters: which view answers which question, how to set a master, and which flag checks are redundant.
- `dev-docs/runuo-migration-docs/09-items-mobiles-creatures.md` § Masters: RunUO's two-field reads mapped onto the views, plus the gotcha for creatures that set `SummonMaster` without `Summoned` (the write compiles, the read now returns null; use `Master`).
- The `modernuo-content-patterns` and `migrate-items-mobiles` skills point at both.

## Test plan

- [x] `MasterViewsTests`: all four views across wild, pet, controlled summon, uncontrolled summon and enraged shapes; reassigning `Master` moves follower slots; `SetControlMaster(null)` keeps an uncontrolled summon's caster; deleting a summon returns the caster's slots
- [x] Serialization tests updated to the new views (round-trip, legacy v22, v23 migration)
- [x] UOContent.Tests (1178 passed, 2 skipped) and Server.Tests (907) green
2026-09-24 22:45:24 -07:00

162 lines
4.9 KiB
C#

using ModernUO.Serialization;
using Server.Items;
namespace Server.Mobiles
{
[SerializationGenerator(0, false)]
public partial class Golem : BaseCreature
{
[Constructible]
public Golem(bool summoned = false, double scalar = 1.0) : base(AIType.AI_Melee)
{
Body = 752;
if (summoned)
{
Hue = 2101;
}
SetStr((int)(251 * scalar), (int)(350 * scalar));
SetDex((int)(76 * scalar), (int)(100 * scalar));
SetInt((int)(101 * scalar), (int)(150 * scalar));
SetHits((int)(151 * scalar), (int)(210 * scalar));
SetDamage((int)(13 * scalar), (int)(24 * scalar));
SetDamageType(ResistanceType.Physical, 100);
SetResistance(ResistanceType.Physical, (int)(35 * scalar), (int)(55 * scalar));
if (summoned)
{
SetResistance(ResistanceType.Fire, (int)(50 * scalar), (int)(60 * scalar));
}
else
{
SetResistance(ResistanceType.Fire, (int)(100 * scalar));
}
SetResistance(ResistanceType.Cold, (int)(10 * scalar), (int)(30 * scalar));
SetResistance(ResistanceType.Poison, (int)(10 * scalar), (int)(25 * scalar));
SetResistance(ResistanceType.Energy, (int)(30 * scalar), (int)(40 * scalar));
SetSkill(SkillName.MagicResist, 150.1 * scalar, 190.0 * scalar);
SetSkill(SkillName.Tactics, 60.1 * scalar, 100.0 * scalar);
SetSkill(SkillName.Wrestling, 60.1 * scalar, 100.0 * scalar);
if (summoned)
{
Fame = 10;
Karma = 10;
}
else
{
Fame = 3500;
Karma = -3500;
}
if (!summoned)
{
PackItem(new IronIngot(Utility.RandomMinMax(13, 21)));
if (Utility.RandomDouble() < 0.1)
{
PackItem(new PowerCrystal());
}
if (Utility.RandomDouble() < 0.15)
{
PackItem(new ClockworkAssembly());
}
if (Utility.RandomDouble() < 0.2)
{
PackItem(new ArcaneGem());
}
if (Utility.RandomDouble() < 0.25)
{
PackItem(new Gears());
}
}
ControlSlots = 3;
}
public override string CorpseName => "a golem corpse";
public override bool IsScaredOfScaryThings => false;
public override bool IsScaryToPets => true;
public override bool IsBondable => false;
public override FoodType FavoriteFood => FoodType.None;
public override string DefaultName => "a golem";
public override bool DeleteOnRelease => true;
public override bool AutoDispel => !Controlled;
public override bool BleedImmune => true;
public override bool BardImmune => !Core.AOS || Controlled;
public override Poison PoisonImmune => Poison.Lethal;
private static MonsterAbility[] _abilities = { MonsterAbilities.ColossalBlow };
public override MonsterAbility[] GetMonsterAbilities() => _abilities;
public override void OnDeath(Container c)
{
base.OnDeath(c);
if (Utility.RandomDouble() < 0.05)
{
if (!IsParagon)
{
if (Utility.RandomDouble() < 0.75)
{
c.DropItem(DawnsMusicGear.RandomCommon);
}
else
{
c.DropItem(DawnsMusicGear.RandomUncommon);
}
}
else
{
c.DropItem(DawnsMusicGear.RandomRare);
}
}
}
public override int GetAngerSound() => 541;
public override int GetIdleSound() => !Controlled ? 542 : base.GetIdleSound();
public override int GetDeathSound() => !Controlled ? 545 : base.GetDeathSound();
public override int GetAttackSound() => 562;
public override int GetHurtSound() => Controlled ? 320 : base.GetHurtSound();
public override void OnDamage(int amount, Mobile from, bool willKill)
{
if (GetMaster() is { Player: true } master && master.Map == Map && master.InRange(Location, 20))
{
if (master.Mana >= amount)
{
master.Mana -= amount;
}
else
{
amount -= master.Mana;
master.Mana = 0;
master.Damage(amount);
}
}
base.OnDamage(amount, from, willKill);
}
}
}