10a69bf754
## Breaking Changes
Incoming packet registration signature has changed to:
```cs
delegate* void OnReceiveCallback(NetState state, SpanReader reader, int packetLength);
IncomingPackets.Register(int packetID, int length, bool ingame, OnReceiveCallback onReceive);
```
For example, an incoming packet handler signature would now look like this:
```cs
public static void SomeIncomingPacket(NetState state, SpanReader reader, int packetLength)
{
// Parse the data
}
```
## Summary
Updates the network Pipe class to use a mirrored memory technique. This technique involves mapping the same physical memory to two contiguous virtual memory spaces so the byte buffer appears duplicated. This allows writing to a double-sized array to wrap around without the need for the `CircularBuffer` classes.
In practice this allows us to use `Span<byte>` as if the buffer was a regular array.
### Bug Fixes
- [X] Fixes bad fixed length string parsing
117 lines
3.1 KiB
C#
117 lines
3.1 KiB
C#
using System;
|
|
using Server.Network;
|
|
using Xunit;
|
|
|
|
namespace Server.Tests.Network
|
|
{
|
|
public class ItemPacketTests : IClassFixture<ServerFixture>
|
|
{
|
|
[Fact]
|
|
public void TestWorldItemPacket()
|
|
{
|
|
Serial serial = (Serial)0x1024;
|
|
var itemId = 1;
|
|
|
|
// Move to fixture
|
|
TileData.ItemTable[itemId] = new ItemData(
|
|
"Test Item Data",
|
|
TileFlag.Generic,
|
|
1,
|
|
1,
|
|
1,
|
|
1,
|
|
1,
|
|
1
|
|
);
|
|
|
|
var item = new Item(serial)
|
|
{
|
|
ItemID = itemId,
|
|
Hue = 0x1024,
|
|
Amount = 10,
|
|
Location = new Point3D(1000, 100, -10),
|
|
Direction = Direction.Left
|
|
};
|
|
|
|
var expected = new WorldItem(item).Compile();
|
|
|
|
var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.SendWorldItem(item);
|
|
|
|
var result = ns.SendPipe.Reader.AvailableToRead();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Fact]
|
|
public void TestWorldItemSAPacket()
|
|
{
|
|
Serial serial = (Serial)0x1024;
|
|
ushort itemId = 1;
|
|
|
|
// Move to fixture
|
|
TileData.ItemTable[itemId] = new ItemData(
|
|
"Test Item Data",
|
|
TileFlag.Generic,
|
|
1,
|
|
1,
|
|
1,
|
|
1,
|
|
1,
|
|
1
|
|
);
|
|
|
|
var item = new Item(serial)
|
|
{
|
|
ItemID = itemId,
|
|
Hue = 0x1024,
|
|
Amount = 10,
|
|
Location = new Point3D(1000, 100, -10)
|
|
};
|
|
|
|
var expected = new WorldItemSA(item).Compile();
|
|
|
|
var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.ProtocolChanges = ProtocolChanges.StygianAbyss;
|
|
ns.SendWorldItem(item);
|
|
|
|
var result = ns.SendPipe.Reader.AvailableToRead();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Fact]
|
|
public void TestWorldItemHSPacket()
|
|
{
|
|
Serial serial = (Serial)0x1024;
|
|
var itemId = 1;
|
|
|
|
// Move to fixture
|
|
TileData.ItemTable[itemId] = new ItemData(
|
|
"Test Item Data",
|
|
TileFlag.Generic,
|
|
1,
|
|
1,
|
|
1,
|
|
1,
|
|
1,
|
|
1
|
|
);
|
|
|
|
var item = new Item(serial)
|
|
{
|
|
ItemID = itemId,
|
|
Hue = 0x1024,
|
|
Amount = 10,
|
|
Location = new Point3D(1000, 100, -10)
|
|
};
|
|
|
|
var expected = new WorldItemHS(item).Compile();
|
|
|
|
var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.ProtocolChanges = ProtocolChanges.StygianAbyss | ProtocolChanges.HighSeas;
|
|
ns.SendWorldItem(item);
|
|
|
|
var result = ns.SendPipe.Reader.AvailableToRead();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
}
|
|
}
|