## Breaking Changes
Incoming packet registration signature has changed to:
```cs
delegate* void OnReceiveCallback(NetState state, SpanReader reader, int packetLength);
IncomingPackets.Register(int packetID, int length, bool ingame, OnReceiveCallback onReceive);
```
For example, an incoming packet handler signature would now look like this:
```cs
public static void SomeIncomingPacket(NetState state, SpanReader reader, int packetLength)
{
// Parse the data
}
```
## Summary
Updates the network Pipe class to use a mirrored memory technique. This technique involves mapping the same physical memory to two contiguous virtual memory spaces so the byte buffer appears duplicated. This allows writing to a double-sized array to wrap around without the need for the `CircularBuffer` classes.
In practice this allows us to use `Span<byte>` as if the buffer was a regular array.
### Bug Fixes
- [X] Fixes bad fixed length string parsing
99 lines
2.7 KiB
C#
99 lines
2.7 KiB
C#
using System;
|
|
using Server;
|
|
using Server.Engines.PartySystem;
|
|
using Server.Tests;
|
|
using Server.Tests.Network;
|
|
using Xunit;
|
|
|
|
namespace UOContent.Tests
|
|
{
|
|
public class PartyPacketTests : IClassFixture<ServerFixture>
|
|
{
|
|
[Fact]
|
|
public void TestPartyEmptyList()
|
|
{
|
|
Serial m = (Serial)0x1024u;
|
|
|
|
var expected = new PartyEmptyList(m).Compile();
|
|
|
|
var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.SendPartyRemoveMember(m);
|
|
|
|
var result = ns.SendPipe.Reader.AvailableToRead();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Fact]
|
|
public void TestPartyRemoveMember()
|
|
{
|
|
var leader = new Mobile((Serial)0x1024u);
|
|
leader.DefaultMobileInit();
|
|
|
|
var member = new Mobile((Serial)0x2048u);
|
|
member.DefaultMobileInit();
|
|
|
|
var p = new Party(leader);
|
|
p.Add(member);
|
|
|
|
var expected = new PartyRemoveMember(member.Serial, p).Compile();
|
|
|
|
var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.SendPartyRemoveMember(member.Serial, p);
|
|
|
|
var result = ns.SendPipe.Reader.AvailableToRead();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Fact]
|
|
public void TestPartyMemberList()
|
|
{
|
|
var leader = new Mobile((Serial)0x1024u);
|
|
leader.DefaultMobileInit();
|
|
|
|
var member = new Mobile((Serial)0x2048u);
|
|
member.DefaultMobileInit();
|
|
|
|
var p = new Party(leader);
|
|
p.Add(member);
|
|
|
|
var expected = new PartyMemberList(p).Compile();
|
|
|
|
var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.SendPartyMemberList(p);
|
|
|
|
var result = ns.SendPipe.Reader.AvailableToRead();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(true)]
|
|
[InlineData(false)]
|
|
public void TestPartyTextMessage(bool toAll)
|
|
{
|
|
Serial serial = (Serial)0x1024u;
|
|
var text = "[Party] Stuff Happens";
|
|
|
|
var expected = new PartyTextMessage(toAll, serial, text).Compile();
|
|
|
|
var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.SendPartyTextMessage(serial, text, toAll);
|
|
|
|
var result = ns.SendPipe.Reader.AvailableToRead();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Fact]
|
|
public void TestPartyInvitation()
|
|
{
|
|
Serial m = (Serial)0x1024u;
|
|
|
|
var expected = new PartyInvitation(m).Compile();
|
|
|
|
var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.SendPartyInvitation(m);
|
|
|
|
var result = ns.SendPipe.Reader.AvailableToRead();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
}
|
|
}
|