10a69bf754
## Breaking Changes
Incoming packet registration signature has changed to:
```cs
delegate* void OnReceiveCallback(NetState state, SpanReader reader, int packetLength);
IncomingPackets.Register(int packetID, int length, bool ingame, OnReceiveCallback onReceive);
```
For example, an incoming packet handler signature would now look like this:
```cs
public static void SomeIncomingPacket(NetState state, SpanReader reader, int packetLength)
{
// Parse the data
}
```
## Summary
Updates the network Pipe class to use a mirrored memory technique. This technique involves mapping the same physical memory to two contiguous virtual memory spaces so the byte buffer appears duplicated. This allows writing to a double-sized array to wrap around without the need for the `CircularBuffer` classes.
In practice this allows us to use `Span<byte>` as if the buffer was a regular array.
### Bug Fixes
- [X] Fixes bad fixed length string parsing
50 lines
1.5 KiB
C#
50 lines
1.5 KiB
C#
using System;
|
|
using Server;
|
|
using Server.Items;
|
|
using Server.Network;
|
|
using Server.Tests;
|
|
using Server.Tests.Network;
|
|
using Xunit;
|
|
|
|
namespace UOContent.Tests
|
|
{
|
|
[Collection("Sequential Tests")]
|
|
public class TestMapItemPackets : IClassFixture<ServerFixture>
|
|
{
|
|
[Theory]
|
|
[InlineData(ProtocolChanges.NewCharacterList)]
|
|
[InlineData(ProtocolChanges.None)]
|
|
public void TestSendMapDetails(ProtocolChanges changes)
|
|
{
|
|
var mapItem = new MapItem(Map.Trammel);
|
|
|
|
var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.ProtocolChanges = changes;
|
|
|
|
var expected = (ns.NewCharacterList ?
|
|
(Packet)new MapDetailsNew(mapItem) : new MapDetails(mapItem)).Compile();
|
|
ns.SendMapDetails(mapItem);
|
|
|
|
var result = ns.SendPipe.Reader.AvailableToRead();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(5, 0, 0, 0)]
|
|
[InlineData(1, 0, 100, 200)]
|
|
[InlineData(7, 1, 0, 0)]
|
|
[InlineData(7, 0, 0, 0)]
|
|
public void TestSendMapCommand(int command, int number, int x, int y)
|
|
{
|
|
var mapItem = new MapItem(Map.Trammel);
|
|
|
|
var expected = new MapCommand(mapItem, command, number, x, y).Compile();
|
|
|
|
var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.SendMapCommand(mapItem, command, x, y, number > 0);
|
|
|
|
var result = ns.SendPipe.Reader.AvailableToRead();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
}
|
|
}
|