## Breaking Changes
Incoming packet registration signature has changed to:
```cs
delegate* void OnReceiveCallback(NetState state, SpanReader reader, int packetLength);
IncomingPackets.Register(int packetID, int length, bool ingame, OnReceiveCallback onReceive);
```
For example, an incoming packet handler signature would now look like this:
```cs
public static void SomeIncomingPacket(NetState state, SpanReader reader, int packetLength)
{
// Parse the data
}
```
## Summary
Updates the network Pipe class to use a mirrored memory technique. This technique involves mapping the same physical memory to two contiguous virtual memory spaces so the byte buffer appears duplicated. This allows writing to a double-sized array to wrap around without the need for the `CircularBuffer` classes.
In practice this allows us to use `Span<byte>` as if the buffer was a regular array.
### Bug Fixes
- [X] Fixes bad fixed length string parsing
72 lines
2 KiB
C#
72 lines
2 KiB
C#
using System;
|
|
using Server.Network;
|
|
using Xunit;
|
|
|
|
namespace Server.Tests.Network
|
|
{
|
|
public class ArrowPacketTests
|
|
{
|
|
[Fact]
|
|
public void TestCancelArrow()
|
|
{
|
|
var expected = new CancelArrow().Compile();
|
|
|
|
var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.SendCancelArrow(0, 0, Serial.Zero);
|
|
|
|
var result = ns.SendPipe.Reader.AvailableToRead();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(0, 0)]
|
|
[InlineData(100, 10)]
|
|
[InlineData(100000, 100000)]
|
|
public void TestSetArrow(int x, int y)
|
|
{
|
|
var expected = new SetArrow(x, y).Compile();
|
|
|
|
var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.SendSetArrow(x, y, Serial.Zero);
|
|
|
|
var result = ns.SendPipe.Reader.AvailableToRead();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(0, 0)]
|
|
[InlineData(100, 10)]
|
|
[InlineData(100000, 100000)]
|
|
public void TestCancelArrowHS(int x, int y)
|
|
{
|
|
Serial serial = (Serial)0x1024;
|
|
|
|
var expected = new CancelArrowHS(x, y, serial).Compile();
|
|
|
|
var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.ProtocolChanges = ProtocolChanges.HighSeas;
|
|
ns.SendCancelArrow(x, y, serial);
|
|
|
|
var result = ns.SendPipe.Reader.AvailableToRead();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(0, 0)]
|
|
[InlineData(100, 10)]
|
|
[InlineData(100000, 100000)]
|
|
public void TestSetArrowHS(int x, int y)
|
|
{
|
|
Serial serial = (Serial)0x1024;
|
|
|
|
var expected = new SetArrowHS(x, y, serial).Compile();
|
|
|
|
var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.ProtocolChanges = ProtocolChanges.HighSeas;
|
|
ns.SendSetArrow(x, y, serial);
|
|
|
|
var result = ns.SendPipe.Reader.AvailableToRead();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
}
|
|
}
|