10a69bf754
## Breaking Changes
Incoming packet registration signature has changed to:
```cs
delegate* void OnReceiveCallback(NetState state, SpanReader reader, int packetLength);
IncomingPackets.Register(int packetID, int length, bool ingame, OnReceiveCallback onReceive);
```
For example, an incoming packet handler signature would now look like this:
```cs
public static void SomeIncomingPacket(NetState state, SpanReader reader, int packetLength)
{
// Parse the data
}
```
## Summary
Updates the network Pipe class to use a mirrored memory technique. This technique involves mapping the same physical memory to two contiguous virtual memory spaces so the byte buffer appears duplicated. This allows writing to a double-sized array to wrap around without the need for the `CircularBuffer` classes.
In practice this allows us to use `Span<byte>` as if the buffer was a regular array.
### Bug Fixes
- [X] Fixes bad fixed length string parsing
33 lines
1,006 B
C#
33 lines
1,006 B
C#
using System;
|
|
using Server.Mobiles;
|
|
using Server.Network;
|
|
using Server.SkillHandlers;
|
|
using Server.Tests;
|
|
using Server.Tests.Network;
|
|
using Xunit;
|
|
|
|
namespace UOContent.Tests
|
|
{
|
|
public class TrackingGumpTests : IClassFixture<ServerFixture>
|
|
{
|
|
[Theory]
|
|
[InlineData(ProtocolChanges.None)]
|
|
[InlineData(ProtocolChanges.Unpack)]
|
|
// Regression test used to identify an issue with AddItem compilation of the packet
|
|
public void TestTrackingGump(ProtocolChanges changes)
|
|
{
|
|
var pm = new PlayerMobile();
|
|
pm.Skills.Tracking.BaseFixedPoint = 1000;
|
|
var g = new TrackWhatGump(pm);
|
|
|
|
var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.ProtocolChanges = changes;
|
|
|
|
var expected = g.Compile(ns).Compile();
|
|
ns.SendDisplayGump(g, out var switches, out var entries);
|
|
|
|
var result = ns.SendPipe.Reader.AvailableToRead();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
}
|
|
}
|