9a25054809
## Summary Many tests proved a specific change when it landed but don't need to run on every CI build forever. This removes **202 test methods and 9 files: 313 test cases, 2,247 → 1,934**. UOContent.Tests drops from about 14s to about 5s locally. Removed: - **Tautologies.** Asserting a constant, a constructor readback or a trivial getter, or testing BCL behavior. - **Exact duplicates** of a surviving test on the same code path. - **Obsolete regressions** whose failure can no longer be expressed. - **Game-content values** shard owners customize (era drop rates, loot and skill tables, single-creature tuning). Each customization would otherwise force a test fix. ## How it was decided 1. Every test was classified, with a reason, by a per-shard sweep over all 287 test files. 2. Each proposed deletion was then checked by a second, adversarial reviewer against the surviving tests and the production code. 3. Anything that was the only coverage of a separate code path was **kept**, even where it looked like a duplicate. Examples: the unsigned `SpanReader`/`SpanWriter` methods, the at-location versus bounds enumerators, null-map enumerables, the security filters, archive-journal state transitions. About 130 proposed deletions were rejected this way. Whole files removed: - `FishingTests`, apart from 3 tests: the map-edge scan, serpent cleanup, and SOS chest consumption. The SOS test now stops at the first chest instead of measuring a catch rate. The multi-million-cast rate simulations are gone. - `LordOaksTests` and `MeerEnragedTests` (single-creature tests). - `AutoArchiveHelperTests`, `JsonDiscoverableTypeAttributeTests`, `DecimalSerializationTests` and `EnumConversionTests` (tautologies, or tests of their own local helpers). - `NetworkStatsTests`. - `MigratedDataLoadTests` (a subset of `AllSpawnFilesLoadTests`). - `SpawnerFixtureCapture`: a capture tool, not a test, and its `version == 12` assert can no longer pass. The `.bin` fixtures it produced stay. ## Tests - Server.Tests: 811 pass. - UOContent.Tests: 1,123 pass. A follow-up PR, stacked on this one, fixes how the remaining tests behave: shared state, CI-vacuous tests, harness duplication.
77 lines
2.8 KiB
C#
77 lines
2.8 KiB
C#
using System;
|
|
using Server.Buffers;
|
|
using Xunit;
|
|
|
|
namespace Server.Tests.Buffers;
|
|
|
|
[Collection("Sequential Server Tests")]
|
|
public class RawInterpolatedStringHandlerTests
|
|
{
|
|
[Fact]
|
|
public void TestLowercaseFormatString()
|
|
{
|
|
var name = "Hello WORLD";
|
|
var handler = new RawInterpolatedStringHandler(0, 1);
|
|
handler.AppendFormatted(name, format: "L");
|
|
Assert.Equal("hello world", handler.Text.ToString());
|
|
handler.Clear();
|
|
}
|
|
|
|
[Fact]
|
|
public void TestLowercaseFormatEnum()
|
|
{
|
|
var handler = new RawInterpolatedStringHandler(0, 1);
|
|
handler.AppendFormatted(DayOfWeek.Wednesday, format: "L");
|
|
Assert.Equal("wednesday", handler.Text.ToString());
|
|
handler.Clear();
|
|
}
|
|
|
|
[Fact]
|
|
public void TestLowercaseFormatInt()
|
|
{
|
|
// Numerics have no uppercase chars; :L should be a no-op
|
|
var handler = new RawInterpolatedStringHandler(0, 1);
|
|
handler.AppendFormatted(42, format: "L");
|
|
Assert.Equal("42", handler.Text.ToString());
|
|
handler.Clear();
|
|
}
|
|
|
|
[Fact]
|
|
public void TestLowercaseFormatSpan()
|
|
{
|
|
var span = "MIXED Case TEXT".AsSpan();
|
|
var handler = new RawInterpolatedStringHandler(0, 1);
|
|
handler.AppendFormatted(span, alignment: 0, format: "L");
|
|
Assert.Equal("mixed case text", handler.Text.ToString());
|
|
handler.Clear();
|
|
}
|
|
|
|
[Fact]
|
|
public void TestLowercaseFormatWithAlignment()
|
|
{
|
|
// Right-aligned: "Gold" in width 8 with :L -> " gold"
|
|
var handler = new RawInterpolatedStringHandler(0, 1);
|
|
handler.AppendFormatted("Gold", alignment: 8, format: "L");
|
|
Assert.Equal(" gold", handler.Text.ToString());
|
|
handler.Clear();
|
|
}
|
|
|
|
[Fact]
|
|
public void TestLowercaseFormatSurrogatePairAtChunkBoundary()
|
|
{
|
|
// The chunked lowercase path uses a 256-char stackalloc temp buffer. Place a
|
|
// supplementary-plane code point (U+10400 DESERET CAPITAL LONG I, encoded as
|
|
// surrogate pair "𐐀") so its high half lands at offset 255 and its
|
|
// low half at offset 256 — straddling the chunk boundary. Without the
|
|
// surrogate-aware boundary trim, ToLowerInvariant would see two lone surrogates
|
|
// and pass them through unchanged, leaving the capital code point intact.
|
|
// With the trim, the chunk shrinks to 255 chars and the pair stays together
|
|
// in the next chunk, lowercasing correctly to U+10428 ("𐐨").
|
|
var input = new string('a', 255) + "𐐀" + new string('b', 10);
|
|
var handler = new RawInterpolatedStringHandler(0, 1);
|
|
handler.AppendFormatted(input, format: "L");
|
|
var expected = new string('a', 255) + "𐐨" + new string('b', 10);
|
|
Assert.Equal(expected, handler.Text.ToString());
|
|
handler.Clear();
|
|
}
|
|
}
|