d8a64f3316
## Summary Removes the dated `DynamicJson` JSON helper and migrates spawner JSON (de)serialization to a polymorphic `record SpawnerDto` hierarchy. `DynamicJson` was the last remaining consumer (regions moved off it in #1400). The key correctness improvement: **System.Text.Json deserializes plain DTO records, never a live `Item`.** Previously, deserializing directly into an `Item` meant STJ constructed world-registered objects *before* the data was validated — a malformed/hand-edited spawn file could leave orphaned spawner Items in the world save. Now a parse failure is GC-only; `dto.ToSpawner()` constructs the spawner only from a fully-validated DTO and self-cleans on failure. ## What changed - **New:** `SpawnerDto` (abstract) + `SpawnerDataDto` / `RegionSpawnerDto` / `ProximitySpawnerDto`, each marked with a reusable `[JsonDiscoverableType]` opt-in attribute. Auto-discovered at the `Configure` phase — no manual registration list (avoids the regions `Register<T>()` footgun), open to custom spawner subtypes. - **Symmetric mapping:** `BaseSpawner.ToDto()` (export) ⇄ `SpawnerDto.ToSpawner()` (import). `ToSpawner()` deletes-and-rethrows on any failure, so the importer can never orphan an Item. - **`SpawnerJsonSerializer`** wires `$type` polymorphism on the `SpawnerDto` root with loud collision/constructibility validation. - **Import/export commands** rewired to the typed DTO path (reflection `FindTypeByName`/`CreateInstance` removed). - **Data migration:** the 109 `Distribution/Data/Spawns/**` files moved from `"type"`→`"$type"` and legacy `homeRange`→`spawnBounds`. The runtime still *reads* legacy `homeRange` for external files. The `homeRange→spawnBounds` formula is proven equivalent to the runtime conversion (`BoundsEquivalenceTests`, hr=0/1/3/7). - **Deleted:** `Projects/Server/Json/DynamicJson.cs`. Sparse export output matches the legacy `ToJson` (nullable DTO properties + `WhenWritingNull`). Binary world-save serialization is untouched. ## Tests - DTO round-trip per spawner type; sparse-default omission; legacy `homeRange` read; export/import file round-trip. - `Import_MalformedFile_LeaksNoWorldItems` — proves a mid-array parse failure constructs zero world Items. - `AllSpawnFilesLoadTests` — every migrated spawn file deserializes and builds. - Duplicate-discriminator validation. - UOContent.Tests 485/485, Server.Tests 710/710, build clean. ## Follow-up (not in this PR) `Rectangle3DConverter.Write` (in `Projects/Server/`) omits `z1/z2` when `Start.Z == -128`, so a future server-side export of a `homeRange`-style spawner round-trips depth 256→255. Pre-existing and out of scope here (Server change); the migrated data reads correctly. Worth a separate small converter PR.
286 lines
9.4 KiB
JSON
286 lines
9.4 KiB
JSON
[
|
|
{
|
|
"$type": "Spawner",
|
|
"guid": "04a75e0b-4499-4fe6-8bd6-49e3dbf0d528",
|
|
"name": "Spawner (215)",
|
|
"location": [6416, 447, -40],
|
|
"map": "Felucca",
|
|
"count": 15,
|
|
"minDelay": "00:05:00",
|
|
"maxDelay": "00:10:00",
|
|
"team": 0,
|
|
"homeRange": 20,
|
|
"walkingRange": 20,
|
|
"entries": [
|
|
{ "name": "PlagueBeast", "maxCount": 8, "probability": 100 },
|
|
{ "name": "PlagueSpawn", "maxCount": 8, "probability": 100 },
|
|
{ "name": "AcidElemental", "maxCount": 7, "probability": 100 },
|
|
{ "name": "CorrosiveSlime", "maxCount": 7, "probability": 100 }
|
|
]
|
|
},
|
|
{
|
|
"$type": "Spawner",
|
|
"guid": "04cc01ab-f7da-4992-8913-4db4ea63149e",
|
|
"name": "Spawner (215)",
|
|
"location": [6298, 395, 60],
|
|
"map": "Felucca",
|
|
"count": 2,
|
|
"minDelay": "00:05:00",
|
|
"maxDelay": "00:10:00",
|
|
"team": 0,
|
|
"homeRange": 8,
|
|
"walkingRange": 8,
|
|
"entries": [
|
|
{ "name": "EarthElemental", "maxCount": 2, "probability": 100 },
|
|
{ "name": "CorrosiveSlime", "maxCount": 2, "probability": 100 }
|
|
]
|
|
},
|
|
{
|
|
"$type": "Spawner",
|
|
"guid": "3a0d9e92-6661-4ad8-a38e-dcf7516e05de",
|
|
"name": "Spawner (215)",
|
|
"location": [6354, 455, -40],
|
|
"map": "Felucca",
|
|
"count": 10,
|
|
"minDelay": "00:05:00",
|
|
"maxDelay": "00:10:00",
|
|
"team": 0,
|
|
"homeRange": 20,
|
|
"walkingRange": 20,
|
|
"entries": [
|
|
{ "name": "PlagueBeast", "maxCount": 5, "probability": 100 },
|
|
{ "name": "CorrosiveSlime", "maxCount": 5, "probability": 100 },
|
|
{ "name": "PoisonElemental", "maxCount": 5, "probability": 100 },
|
|
{ "name": "PlagueSpawn", "maxCount": 5, "probability": 100 }
|
|
]
|
|
},
|
|
{
|
|
"$type": "Spawner",
|
|
"guid": "5a586bde-b6a0-4f4d-b147-1e1886aae735",
|
|
"name": "Spawner (215)",
|
|
"location": [6384, 580, -50],
|
|
"map": "Felucca",
|
|
"count": 31,
|
|
"minDelay": "00:05:00",
|
|
"maxDelay": "00:10:00",
|
|
"team": 0,
|
|
"homeRange": 30,
|
|
"walkingRange": 30,
|
|
"entries": [
|
|
{ "name": "InterredGrizzle", "maxCount": 4, "probability": 100 },
|
|
{ "name": "CorrosiveSlime", "maxCount": 4, "probability": 100 },
|
|
{ "name": "PoisonElemental", "maxCount": 3, "probability": 100 },
|
|
{ "name": "Balron", "maxCount": 9, "probability": 100 },
|
|
{ "name": "Succubus", "maxCount": 9, "probability": 100 },
|
|
{ "name": "Daemon", "maxCount": 9, "probability": 100 },
|
|
{ "name": "PlagueBeastLord", "maxCount": 11, "probability": 100 },
|
|
{ "name": "PlagueBeast", "maxCount": 11, "probability": 100 },
|
|
{ "name": "PlagueSpawn", "maxCount": 11, "probability": 100 }
|
|
]
|
|
},
|
|
{
|
|
"$type": "Spawner",
|
|
"guid": "5ef37566-7b9c-47fb-a88c-d6c0177d92f3",
|
|
"name": "Spawner (215)",
|
|
"location": [6418, 358, -40],
|
|
"map": "Felucca",
|
|
"count": 22,
|
|
"minDelay": "00:05:00",
|
|
"maxDelay": "00:10:00",
|
|
"team": 0,
|
|
"homeRange": 25,
|
|
"walkingRange": 25,
|
|
"entries": [
|
|
{ "name": "PlagueSpawn", "maxCount": 12, "probability": 100 },
|
|
{ "name": "PlagueBeast", "maxCount": 12, "probability": 100 },
|
|
{ "name": "AcidElemental", "maxCount": 12, "probability": 100 },
|
|
{ "name": "CorrosiveSlime", "maxCount": 12, "probability": 100 },
|
|
{ "name": "PoisonElemental", "maxCount": 12, "probability": 100 },
|
|
{ "name": "PlagueSpawn", "maxCount": 2, "probability": 100 },
|
|
{ "name": "PlagueBeast", "maxCount": 2, "probability": 100 },
|
|
{ "name": "AcidElemental", "maxCount": 2, "probability": 100 },
|
|
{ "name": "CorrosiveSlime", "maxCount": 2, "probability": 100 },
|
|
{ "name": "PoisonElemental", "maxCount": 2, "probability": 100 }
|
|
]
|
|
},
|
|
{
|
|
"$type": "Spawner",
|
|
"guid": "604b87ed-6718-4802-b1b6-f572ed7d9935",
|
|
"name": "Spawner (215)",
|
|
"location": [6295, 616, -50],
|
|
"map": "Felucca",
|
|
"count": 27,
|
|
"minDelay": "00:05:00",
|
|
"maxDelay": "00:10:00",
|
|
"team": 0,
|
|
"homeRange": 50,
|
|
"walkingRange": 50,
|
|
"entries": [
|
|
{ "name": "Daemon", "maxCount": 6, "probability": 100 },
|
|
{ "name": "Succubus", "maxCount": 6, "probability": 100 },
|
|
{ "name": "InterredGrizzle", "maxCount": 6, "probability": 100 },
|
|
{ "name": "PoisonElemental", "maxCount": 6, "probability": 100 },
|
|
{ "name": "PlagueBeast", "maxCount": 6, "probability": 100 },
|
|
{ "name": "PlagueSpawn", "maxCount": 6, "probability": 100 },
|
|
{ "name": "CorrosiveSlime", "maxCount": 3, "probability": 100 },
|
|
{ "name": "Putrefier", "maxCount": 3, "probability": 100 },
|
|
{ "name": "PlagueBeastLord", "maxCount": 3, "probability": 100 }
|
|
]
|
|
},
|
|
{
|
|
"$type": "Spawner",
|
|
"guid": "74269ae8-5e94-4496-ad04-611e81b14168",
|
|
"name": "Spawner (215)",
|
|
"location": [6404, 378, -40],
|
|
"map": "Felucca",
|
|
"count": 4,
|
|
"minDelay": "00:05:00",
|
|
"maxDelay": "00:10:00",
|
|
"team": 0,
|
|
"homeRange": 18,
|
|
"walkingRange": 18,
|
|
"entries": [
|
|
{ "name": "AcidElemental", "maxCount": 2, "probability": 100 },
|
|
{ "name": "PlagueSpawn", "maxCount": 2, "probability": 100 },
|
|
{ "name": "AcidElemental", "maxCount": 1, "probability": 100 },
|
|
{ "name": "PlagueSpawn", "maxCount": 1, "probability": 100 }
|
|
]
|
|
},
|
|
{
|
|
"$type": "Spawner",
|
|
"guid": "9c1149a5-ac2a-42e6-b6e2-296e6ca05602",
|
|
"name": "Spawner (215)",
|
|
"location": [6249, 352, 60],
|
|
"map": "Felucca",
|
|
"count": 9,
|
|
"minDelay": "00:05:00",
|
|
"maxDelay": "00:10:00",
|
|
"team": 0,
|
|
"homeRange": 15,
|
|
"walkingRange": 15,
|
|
"entries": [
|
|
{ "name": "AcidElemental", "maxCount": 6, "probability": 100 },
|
|
{ "name": "EarthElemental", "maxCount": 6, "probability": 100 },
|
|
{ "name": "CorrosiveSlime", "maxCount": 6, "probability": 100 },
|
|
{ "name": "AcidElemental", "maxCount": 1, "probability": 100 },
|
|
{ "name": "EarthElemental", "maxCount": 1, "probability": 100 },
|
|
{ "name": "CorrosiveSlime", "maxCount": 1, "probability": 100 }
|
|
]
|
|
},
|
|
{
|
|
"$type": "Spawner",
|
|
"guid": "ad3fbc20-7914-4651-a7c1-994d9b88ed22",
|
|
"name": "Spawner (215)",
|
|
"location": [6466, 543, -50],
|
|
"map": "Felucca",
|
|
"count": 22,
|
|
"minDelay": "00:05:00",
|
|
"maxDelay": "00:10:00",
|
|
"team": 0,
|
|
"homeRange": 30,
|
|
"walkingRange": 30,
|
|
"entries": [
|
|
{ "name": "Balron", "maxCount": 6, "probability": 100 },
|
|
{ "name": "Succubus", "maxCount": 6, "probability": 100 },
|
|
{ "name": "Daemon", "maxCount": 6, "probability": 100 },
|
|
{ "name": "CorrosiveSlime", "maxCount": 3, "probability": 100 },
|
|
{ "name": "PlagueBeastLord", "maxCount": 8, "probability": 100 },
|
|
{ "name": "PlagueBeast", "maxCount": 8, "probability": 100 },
|
|
{ "name": "PlagueSpawn", "maxCount": 8, "probability": 100 },
|
|
{ "name": "InterredGrizzle", "maxCount": 5, "probability": 100 },
|
|
{ "name": "PoisonElemental", "maxCount": 5, "probability": 100 }
|
|
]
|
|
},
|
|
{
|
|
"$type": "Spawner",
|
|
"guid": "af6ef316-bb00-417f-852c-14e9c98ca74c",
|
|
"name": "Spawner (215)",
|
|
"location": [6285, 353, 60],
|
|
"map": "Felucca",
|
|
"count": 1,
|
|
"minDelay": "00:05:00",
|
|
"maxDelay": "00:10:00",
|
|
"team": 0,
|
|
"homeRange": 5,
|
|
"walkingRange": 5,
|
|
"entries": [
|
|
{ "name": "PoisonElemental", "maxCount": 1, "probability": 100 }
|
|
]
|
|
},
|
|
{
|
|
"$type": "Spawner",
|
|
"guid": "b7da2a27-b13e-4113-b8c8-e5f2e7ac2e3a",
|
|
"name": "Spawner (215)",
|
|
"location": [6292, 462, -50],
|
|
"map": "Felucca",
|
|
"count": 18,
|
|
"minDelay": "00:05:00",
|
|
"maxDelay": "00:10:00",
|
|
"team": 0,
|
|
"homeRange": 40,
|
|
"walkingRange": 40,
|
|
"entries": [
|
|
{ "name": "ChaosDaemon", "maxCount": 7, "probability": 100 },
|
|
{ "name": "Moloch", "maxCount": 7, "probability": 100 },
|
|
{ "name": "Succubus", "maxCount": 7, "probability": 100 },
|
|
{ "name": "Daemon", "maxCount": 7, "probability": 100 },
|
|
{ "name": "Balron", "maxCount": 4, "probability": 100 }
|
|
]
|
|
},
|
|
{
|
|
"$type": "Spawner",
|
|
"guid": "bbed003d-43d6-4690-b93e-763f42a4187f",
|
|
"name": "Spawner (215)",
|
|
"location": [6353, 400, 60],
|
|
"map": "Felucca",
|
|
"count": 4,
|
|
"minDelay": "00:05:00",
|
|
"maxDelay": "00:10:00",
|
|
"team": 0,
|
|
"homeRange": 10,
|
|
"walkingRange": 10,
|
|
"entries": [
|
|
{ "name": "EarthElemental", "maxCount": 4, "probability": 100 },
|
|
{ "name": "CorrosiveSlime", "maxCount": 4, "probability": 100 }
|
|
]
|
|
},
|
|
{
|
|
"$type": "Spawner",
|
|
"guid": "d3ba2375-fc73-4996-9f54-3a09dc39c653",
|
|
"name": "Spawner (215)",
|
|
"location": [6319, 348, 60],
|
|
"map": "Felucca",
|
|
"count": 9,
|
|
"minDelay": "00:05:00",
|
|
"maxDelay": "00:10:00",
|
|
"team": 0,
|
|
"homeRange": 20,
|
|
"walkingRange": 20,
|
|
"entries": [
|
|
{ "name": "EarthElemental", "maxCount": 5, "probability": 100 },
|
|
{ "name": "CorrosiveSlime", "maxCount": 5, "probability": 100 },
|
|
{ "name": "AcidElemental", "maxCount": 5, "probability": 100 },
|
|
{ "name": "PlagueSpawn", "maxCount": 5, "probability": 100 },
|
|
{ "name": "EarthElemental", "maxCount": 1, "probability": 100 },
|
|
{ "name": "CorrosiveSlime", "maxCount": 1, "probability": 100 },
|
|
{ "name": "AcidElemental", "maxCount": 1, "probability": 100 },
|
|
{ "name": "PlagueSpawn", "maxCount": 1, "probability": 100 }
|
|
]
|
|
},
|
|
{
|
|
"$type": "Spawner",
|
|
"guid": "e695b242-221c-49b5-853a-9e943afe8355",
|
|
"name": "Spawner (215)",
|
|
"location": [6328, 517, -50],
|
|
"map": "Felucca",
|
|
"count": 4,
|
|
"minDelay": "00:05:00",
|
|
"maxDelay": "00:10:00",
|
|
"team": 0,
|
|
"homeRange": 10,
|
|
"walkingRange": 10,
|
|
"entries": [
|
|
{ "name": "PoisonElemental", "maxCount": 4, "probability": 100 }
|
|
]
|
|
}
|
|
]
|