CI reported success despite two failing tests because the Test step ran
`dotnet test --no-restore`, but the Build step (BuildTool) only restores
and builds Application - never the test projects. Without a restore, the
test projects have no project.assets.json, so the Microsoft.NET.Test.Sdk
build targets aren't imported, the projects aren't recognized as test
projects, and `dotnet test` invokes the VSTest target against zero
projects: no output, exit 0. Failures were silently masked.
- Replace `--no-restore` with `dotnet test --logger trx --results-directory`
on both the macOS and Linux jobs so the test projects restore and run.
- Add a guard that fails the job if no .trx is produced, as a permanent
backstop against silent zero-test passes.
Also removes the two AosWeapon/AosArmor `EmitsLowerStatReqWhenPassed`
tests. PR #2501 deliberately emits LowerStatReq (1060435) inline in each
item, not in AosWeaponAttributes/AosArmorAttributes.GetProperties, which
no longer take a lowerStatReq argument. A prior "fix" dropped the argument
to make them compile but left the assertions expecting 1060435, so they
threw KeyNotFoundException at runtime. The "not emitted by GetProperties"
behavior stays covered by the sibling tests; the stale comments that
claimed lowerStatReq is passed in are removed.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
326dc470de