ModernUO/Projects/UOContent/Mobiles/Vendors
Kamron Batman 50599e0453
perf: Migrate NPC and Skill UI gumps to DynamicGump/StaticGump (#2414)
## Summary

Migrates five legacy `Gump`-derived UI dialogs in the NPC and Skill domains to the modern `DynamicGump` builder pipeline. All five gumps were chosen as `DynamicGump` rather than `StaticGump<T>` because their layout shape varies per instance, and several of them carry per-instance localization numbers (cliloc IDs) that the static cache cannot bake (see CLAUDE.md gump-system rule and `dev-docs/gump-system.md`).

Per-gump rationale:

- **`TownCrierGump` (`Mobiles/Townfolk/TownCrier.cs`)** - DynamicGump. Announcement count varies, expiration text is rebuilt per render via `ValueStringBuilder`, and one button per entry is emitted in a loop.
- **`ClaimListGump` (`Mobiles/Vendors/NPC/AnimalTrainer.cs`)** - DynamicGump. The pet list and resulting background/alpha-region heights vary per stabling player.
- **`AnimalLoreGump` (`Skills/AnimalLore.cs`)** - DynamicGump. Page count itself varies (3 pages pre-AOS, 5 pages on AOS) and several `AddHtmlLocalized` calls use cliloc IDs computed from per-creature data (loyalty rating `1049595 + c.Loyalty / 10`, food preference, pack instinct), which violates the StaticGump cliloc-bake rule.
- **`DisguiseGump` (`Items/Skill Items/Thief/DisguiseKit.cs`)** - DynamicGump. Page count and entry order shift on `from.Female`, `Body.IsFemale`, and `startAtHair`.
- **`CommentsGump` (`Gumps/CommentsGump.cs`)** - DynamicGump. Comment list and pagination depend on `Account.Comments` size; the title label encodes the variable account username string.

All five are now `Singleton => true`, have `private` constructors, and expose static `DisplayTo(...)` entry points that validate prerequisites before constructing - guaranteeing no empty gumps (CLAUDE.md Sec.13). All internal refresh paths (prompts, `OnDoubleClick`, command handlers, target callbacks) were updated to call `DisplayTo` rather than `new XGump(...)`. Legacy `m_`-prefixed fields renamed to `_camelCase` (CLAUDE.md Sec.12), and `DisguiseEntry`'s `m_`-prefixed public readonly fields converted to PascalCase auto-properties. `OnResponse` signatures updated to `in RelayInfo info`. No external callers needed updating - all `new XGump(...)` sites lived inside the same files.
2026-04-25 19:51:42 -07:00
..
NPC perf: Migrate NPC and Skill UI gumps to DynamicGump/StaticGump (#2414) 2026-04-25 19:51:42 -07:00
SBInfo fix: Fixes arbitrage by adjusting prices. (#1500) 2023-09-15 19:22:35 -07:00
AnimalBuy.cs Formats UO Content (#201) 2020-08-27 18:30:38 -07:00
BaseVendor.cs fix: Removes vendor buy/sell context when FF is off (#2405) 2026-04-08 13:46:43 -06:00
BeverageBuy.cs fix: Consolidates Color/Center html (#1762) 2024-05-07 23:56:32 -07:00
GenericBuy.cs fix: Moves containers/bods/traps/etc to serialization generator (#2310) 2026-01-07 21:55:55 -08:00
GenericSell.cs chore(content): Updates to C# 9 syntax (#373) 2020-12-30 12:50:10 -08:00
PlayerBarkeeper.cs fix: Moves PlayerBarkeeper to Serialization Generator (#2323) 2026-02-01 17:01:39 -08:00
PlayerVendor.cs feat: Adds Feature Flag System (#2328) 2026-02-07 12:02:57 -08:00
PlayerVendorPlaceholder.cs fix: Codegens house/vendors (#1767) 2024-05-08 22:45:59 -07:00
PresetMapBuy.cs Formats UO Content (#201) 2020-08-27 18:30:38 -07:00
RentedVendor.cs feat: Moves gumps out of the core (#1916) 2024-08-09 19:07:32 -07:00
VendorBackpack.cs fix: Optimizes items to use default weights. (Part 4) (#2243) 2025-07-24 23:29:29 -07:00
VendorInventory.cs feat(timers): Adds timer pooling, fixes timer related bugs, and changes timer api (#667) 2021-08-07 14:33:35 -07:00
VendorItem.cs fix: Set VendorItem Valid AfterDeserialize (#1930) 2024-08-15 07:25:38 -07:00