9a25054809
## Summary Many tests proved a specific change when it landed but don't need to run on every CI build forever. This removes **202 test methods and 9 files: 313 test cases, 2,247 → 1,934**. UOContent.Tests drops from about 14s to about 5s locally. Removed: - **Tautologies.** Asserting a constant, a constructor readback or a trivial getter, or testing BCL behavior. - **Exact duplicates** of a surviving test on the same code path. - **Obsolete regressions** whose failure can no longer be expressed. - **Game-content values** shard owners customize (era drop rates, loot and skill tables, single-creature tuning). Each customization would otherwise force a test fix. ## How it was decided 1. Every test was classified, with a reason, by a per-shard sweep over all 287 test files. 2. Each proposed deletion was then checked by a second, adversarial reviewer against the surviving tests and the production code. 3. Anything that was the only coverage of a separate code path was **kept**, even where it looked like a duplicate. Examples: the unsigned `SpanReader`/`SpanWriter` methods, the at-location versus bounds enumerators, null-map enumerables, the security filters, archive-journal state transitions. About 130 proposed deletions were rejected this way. Whole files removed: - `FishingTests`, apart from 3 tests: the map-edge scan, serpent cleanup, and SOS chest consumption. The SOS test now stops at the first chest instead of measuring a catch rate. The multi-million-cast rate simulations are gone. - `LordOaksTests` and `MeerEnragedTests` (single-creature tests). - `AutoArchiveHelperTests`, `JsonDiscoverableTypeAttributeTests`, `DecimalSerializationTests` and `EnumConversionTests` (tautologies, or tests of their own local helpers). - `NetworkStatsTests`. - `MigratedDataLoadTests` (a subset of `AllSpawnFilesLoadTests`). - `SpawnerFixtureCapture`: a capture tool, not a test, and its `version == 12` assert can no longer pass. The `.bin` fixtures it produced stay. ## Tests - Server.Tests: 811 pass. - UOContent.Tests: 1,123 pass. A follow-up PR, stacked on this one, fixes how the remaining tests behave: shared state, CI-vacuous tests, harness duplication.
61 lines
1.6 KiB
C#
61 lines
1.6 KiB
C#
using Xunit;
|
|
|
|
namespace Server.Tests;
|
|
|
|
/// <summary>
|
|
/// The event loop only sleeps when every queue it drains is empty. These drains are deliberately
|
|
/// bounded -- ExecuteTasks stops at its per-frame cap -- so leftover work is normal and must keep
|
|
/// the loop awake. Getting this wrong strands queued work for the length of a sleep.
|
|
/// </summary>
|
|
[Collection("Sequential Server Tests")]
|
|
public class EventLoopIdleTests
|
|
{
|
|
[Fact]
|
|
public void PostedWorkMakesContextNonEmpty()
|
|
{
|
|
var context = new EventLoopContext();
|
|
|
|
context.Post(() => { });
|
|
|
|
Assert.False(context.IsEmpty);
|
|
}
|
|
|
|
[Fact]
|
|
public void PriorityWorkMakesContextNonEmpty()
|
|
{
|
|
var context = new EventLoopContext();
|
|
|
|
context.Post(() => { }, EventLoopContext.Priority.High);
|
|
|
|
Assert.False(context.IsEmpty);
|
|
}
|
|
|
|
[Fact]
|
|
public void ContextIsEmptyAgainOnceDrained()
|
|
{
|
|
var context = new EventLoopContext();
|
|
context.Post(() => { });
|
|
|
|
context.ExecuteTasks();
|
|
|
|
Assert.True(context.IsEmpty);
|
|
}
|
|
|
|
[Fact]
|
|
public void WorkBeyondThePerFrameCapKeepsContextNonEmpty()
|
|
{
|
|
// The cap is what makes IsEmpty necessary: a single ExecuteTasks pass cannot be assumed
|
|
// to have drained everything, so the loop must not treat "I just ran tasks" as "idle".
|
|
const int perFrameCap = 128;
|
|
var context = new EventLoopContext(perFrameCap);
|
|
|
|
for (var i = 0; i < perFrameCap + 10; i++)
|
|
{
|
|
context.Post(() => { });
|
|
}
|
|
|
|
context.ExecuteTasks();
|
|
|
|
Assert.False(context.IsEmpty);
|
|
}
|
|
}
|