9b554f69b0
### Changes/Fixes:
* Adds timer pooling.
* Allows pool to be configurable in ModernUO.json
* Pool replenishes itself asynchronously if depleted.
* Fixes an issue with barkeeps and town criers
* Fixes an issue with incognito buff icons not being removed
* Fixes an issue with polymorph name mod not being removed
* Fixes several places where timers go on forever even after an object is deleted, keeping a reference (memory leak)
* Eliminates the timer for MiningCart altogether.
* Deletes `AcidSlime` since it is a duplicate of `PoolOfAcid`
* Fixes HonorableExecution and standardizes the code for other Bushido moves.
## Changes to the Timer API:
```cs
public class Timer
{
// Creates a timer that will be returned to the pool once execution stops.
public static void StartTimer(Action callback);
public static void StartTimer(TimeSpan delay, Action callback);
public static void StartTimer(TimeSpan delay, TimeSpan interval, Action callback);
public static void StartTimer(TimeSpan interval, int count, Action callback);
public static void StartTimer(TimeSpan delay, TimeSpan interval, int count, Action callback);
// Creates a timer and returns a token for more control. Requires manual cancellation in order for the timer to be returned to the pool.
// If the token is dereferenced, the timer will be dereferenced too. While not returning a timer to the pool is not considered hazardous, it does defeat the purpose of pooled timers.
public static void StartTimer(Action callback, out TimerExecutionToken token);
public static void StartTimer(TimeSpan delay, Action callback, out TimerExecutionToken token);
public static void StartTimer(TimeSpan delay, TimeSpan interval, Action callback, out TimerExecutionToken token);
public static void StartTimer(TimeSpan interval, int count, Action callback, out TimerExecutionToken token);
public static void StartTimer(TimeSpan delay, TimeSpan interval, int count, Action callback, out TimerExecutionToken token);
// If you aren't sure how to use the API above, or you don't care about performance, then you can use the old RunUO Timer.DelayCall
public static DelayCallTimer DelayCall(Action callback);
public static DelayCallTimer DelayCall(TimeSpan delay, Action callback);
public static DelayCallTimer DelayCall(TimeSpan delay, TimeSpan interval, Action callback);
public static DelayCallTimer DelayCall(TimeSpan interval, int count, Action callback);
public static DelayCallTimer DelayCall(TimeSpan delay, TimeSpan interval, int count, Action callback);
}
public struct TimerExecutionToken
{
public bool Running { get; }
public int Index { get; }
public int RemainingCount { get; }
public DateTime Next { get; }
}
```
## When to use `TimerExecutionToken`?
Use tokens when you want to gain the performance benefit of using a pooled timer, but you need one of the following:
* Access to the next time the timer will tick:`token.Next`
* Access to which interval, how many intervals there are, or how many are remaining: `token.Index`, `token.Count`, and `token.RemainingCount`
* Stop a timer manually.
* Determine if the timer is running: `timer.Running`
* See notes below about requirements for using tokens!
## Notes about using the TimerExecutionToken:
When you opt-in to receive a token, you must call `Cancel()` to return the timer. This can be done inside of the callback, or outside of the callback at any time.
If this is not called and your timer is an infinite interval, then you will create a potential memory leak, or null pointer exception in your callback.
If the timer ends and is stopped, but cancel is not called, then the timer will never return to the pool and stay referenced until the token is deleted or cancel is called. (Memory leak)
## Is this thread safe?
No. The ModernUO timer system is not thread safe at all. If you require a thread safe timer system, contact me and I'll help adapt this system. Keep in mind that there is a massive performance hit to make this thread safe when there are literally no use cases for it.
If you need to synchronize execution, meaning you want to execute code from another thread on the core thread. Let's say you have a discord bot that is pushing commands to the game server. Then use `EventLoopContext.Post(SendOrPostCallback callback, object state);`.
550 lines
21 KiB
C#
550 lines
21 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
using Server.Factions;
|
|
using Server.Mobiles;
|
|
using Server.Network;
|
|
using Server.Spells;
|
|
using Server.Spells.Necromancy;
|
|
using Server.Spells.Spellweaving;
|
|
using Server.Targeting;
|
|
|
|
namespace Server.SkillHandlers
|
|
{
|
|
public static class AnimalTaming
|
|
{
|
|
private static readonly HashSet<Mobile> m_BeingTamed = new();
|
|
|
|
public static bool DisableMessage { get; set; }
|
|
|
|
public static void Initialize()
|
|
{
|
|
SkillInfo.Table[(int)SkillName.AnimalTaming].Callback = OnUse;
|
|
}
|
|
|
|
public static TimeSpan OnUse(Mobile m)
|
|
{
|
|
m.RevealingAction();
|
|
|
|
m.Target = new InternalTarget();
|
|
m.RevealingAction();
|
|
|
|
if (!DisableMessage)
|
|
{
|
|
m.SendLocalizedMessage(502789); // Tame which animal?
|
|
}
|
|
|
|
return TimeSpan.FromHours(6.0);
|
|
}
|
|
|
|
public static bool CheckMastery(Mobile tamer, BaseCreature creature) =>
|
|
SummonFamiliarSpell.Table.TryGetValue(tamer, out var bc) && bc is DarkWolfFamiliar familiar &&
|
|
!familiar.Deleted && creature is DireWolf or GreyWolf or TimberWolf or WhiteWolf or BakeKitsune;
|
|
|
|
public static bool MustBeSubdued(BaseCreature bc) =>
|
|
bc.Owners.Count <= 0 && bc.SubdueBeforeTame && bc.Hits > bc.HitsMax / 10;
|
|
|
|
public static void ScaleStats(BaseCreature bc, double scalar)
|
|
{
|
|
if (bc.RawStr > 0)
|
|
{
|
|
bc.RawStr = (int)Math.Max(1, bc.RawStr * scalar);
|
|
}
|
|
|
|
if (bc.RawDex > 0)
|
|
{
|
|
bc.RawDex = (int)Math.Max(1, bc.RawDex * scalar);
|
|
}
|
|
|
|
if (bc.RawInt > 0)
|
|
{
|
|
bc.RawInt = (int)Math.Max(1, bc.RawInt * scalar);
|
|
}
|
|
|
|
if (bc.HitsMaxSeed > 0)
|
|
{
|
|
bc.HitsMaxSeed = (int)Math.Max(1, bc.HitsMaxSeed * scalar);
|
|
bc.Hits = bc.Hits;
|
|
}
|
|
|
|
if (bc.StamMaxSeed > 0)
|
|
{
|
|
bc.StamMaxSeed = (int)Math.Max(1, bc.StamMaxSeed * scalar);
|
|
bc.Stam = bc.Stam;
|
|
}
|
|
}
|
|
|
|
public static void ScaleSkills(BaseCreature bc, double scalar)
|
|
{
|
|
ScaleSkills(bc, scalar, scalar);
|
|
}
|
|
|
|
public static void ScaleSkills(BaseCreature bc, double scalar, double capScalar)
|
|
{
|
|
for (var i = 0; i < bc.Skills.Length; ++i)
|
|
{
|
|
bc.Skills[i].Base *= scalar;
|
|
|
|
bc.Skills[i].Cap = Math.Max(100.0, bc.Skills[i].Cap * capScalar);
|
|
|
|
if (bc.Skills[i].Base > bc.Skills[i].Cap)
|
|
{
|
|
bc.Skills[i].Cap = bc.Skills[i].Base;
|
|
}
|
|
}
|
|
}
|
|
|
|
private class InternalTarget : Target
|
|
{
|
|
private bool m_SetSkillTime = true;
|
|
|
|
public InternalTarget() : base(Core.AOS ? 3 : 2, false, TargetFlags.None)
|
|
{
|
|
}
|
|
|
|
protected override void OnTargetFinish(Mobile from)
|
|
{
|
|
if (m_SetSkillTime)
|
|
{
|
|
from.NextSkillTime = Core.TickCount;
|
|
}
|
|
}
|
|
|
|
protected override void OnTarget(Mobile from, object targeted)
|
|
{
|
|
from.RevealingAction();
|
|
|
|
if (targeted is not Mobile mobile)
|
|
{
|
|
from.SendLocalizedMessage(502801); // You can't tame that!
|
|
return;
|
|
}
|
|
|
|
if (mobile is not BaseCreature creature)
|
|
{
|
|
mobile.PrivateOverheadMessage(
|
|
MessageType.Regular,
|
|
0x3B2,
|
|
502469,
|
|
from.NetState
|
|
); // That being cannot be tamed.
|
|
return;
|
|
}
|
|
|
|
if (!creature.Tamable)
|
|
{
|
|
creature.PrivateOverheadMessage(
|
|
MessageType.Regular,
|
|
0x3B2,
|
|
1049655,
|
|
from.NetState
|
|
); // That creature cannot be tamed.
|
|
return;
|
|
}
|
|
|
|
if (creature.Controlled)
|
|
{
|
|
creature.PrivateOverheadMessage(
|
|
MessageType.Regular,
|
|
0x3B2,
|
|
502804,
|
|
from.NetState
|
|
); // That animal looks tame already.
|
|
return;
|
|
}
|
|
|
|
if (from.Female && !creature.AllowFemaleTamer)
|
|
{
|
|
creature.PrivateOverheadMessage(
|
|
MessageType.Regular,
|
|
0x3B2,
|
|
1049653,
|
|
from.NetState
|
|
); // That creature can only be tamed by males.
|
|
return;
|
|
}
|
|
|
|
if (!from.Female && !creature.AllowMaleTamer)
|
|
{
|
|
creature.PrivateOverheadMessage(
|
|
MessageType.Regular,
|
|
0x3B2,
|
|
1049652,
|
|
from.NetState
|
|
); // That creature can only be tamed by females.
|
|
return;
|
|
}
|
|
|
|
if (creature is CuSidhe && from.Race != Race.Elf)
|
|
{
|
|
creature.PrivateOverheadMessage(
|
|
MessageType.Regular,
|
|
0x3B2,
|
|
502801,
|
|
from.NetState
|
|
); // You can't tame that!
|
|
return;
|
|
}
|
|
|
|
if (from.Followers + creature.ControlSlots > from.FollowersMax)
|
|
{
|
|
from.SendLocalizedMessage(1049611); // You have too many followers to tame that creature.
|
|
return;
|
|
}
|
|
|
|
if (creature.Owners.Count >= BaseCreature.MaxOwners && !creature.Owners.Contains(from))
|
|
{
|
|
creature.PrivateOverheadMessage(
|
|
MessageType.Regular,
|
|
0x3B2,
|
|
1005615,
|
|
from.NetState
|
|
); // This animal has had too many owners and is too upset for you to tame.
|
|
return;
|
|
}
|
|
|
|
if (MustBeSubdued(creature))
|
|
{
|
|
creature.PrivateOverheadMessage(
|
|
MessageType.Regular,
|
|
0x3B2,
|
|
1054025,
|
|
from.NetState
|
|
); // You must subdue this creature before you can tame it!
|
|
return;
|
|
}
|
|
|
|
if (!(CheckMastery(from, creature) || from.Skills.AnimalTaming.Value >= creature.MinTameSkill))
|
|
{
|
|
creature.PrivateOverheadMessage(
|
|
MessageType.Regular,
|
|
0x3B2,
|
|
502806,
|
|
from.NetState
|
|
); // You have no chance of taming this creature.
|
|
return;
|
|
}
|
|
|
|
if (creature is FactionWarHorse warHorse)
|
|
{
|
|
var faction = Faction.Find(from);
|
|
|
|
if (faction == null || faction != warHorse.Faction)
|
|
{
|
|
creature.PrivateOverheadMessage(
|
|
MessageType.Regular,
|
|
0x3B2,
|
|
1042590,
|
|
from.NetState
|
|
); // You cannot tame this creature.
|
|
return;
|
|
}
|
|
}
|
|
|
|
if (m_BeingTamed.Contains(creature))
|
|
{
|
|
creature.PrivateOverheadMessage(
|
|
MessageType.Regular,
|
|
0x3B2,
|
|
502802,
|
|
from.NetState
|
|
); // Someone else is already taming this.
|
|
}
|
|
else if (creature.CanAngerOnTame && Utility.RandomDouble() <= 0.95)
|
|
{
|
|
creature.PrivateOverheadMessage(
|
|
MessageType.Regular,
|
|
0x3B2,
|
|
502805,
|
|
from.NetState
|
|
); // You seem to anger the beast!
|
|
creature.PlaySound(creature.GetAngerSound());
|
|
creature.Direction = creature.GetDirectionTo(from);
|
|
|
|
if (creature.BardPacified && Utility.RandomDouble() > .24)
|
|
{
|
|
Timer.StartTimer(TimeSpan.FromSeconds(2.0), () => Pacify(creature));
|
|
}
|
|
else
|
|
{
|
|
creature.BardEndTime = Core.Now;
|
|
}
|
|
|
|
creature.BardPacified = false;
|
|
|
|
creature.AIObject?.DoMove(creature.Direction);
|
|
|
|
if (from is PlayerMobile pm &&
|
|
!(pm.HonorActive ||
|
|
TransformationSpellHelper.UnderTransformation(pm, typeof(EtherealVoyageSpell))))
|
|
{
|
|
creature.Combatant = pm;
|
|
}
|
|
}
|
|
else
|
|
{
|
|
m_BeingTamed.Add(creature);
|
|
|
|
from.LocalOverheadMessage(
|
|
MessageType.Emote,
|
|
0x59,
|
|
1010597
|
|
); // You start to tame the creature.
|
|
from.NonlocalOverheadMessage(
|
|
MessageType.Emote,
|
|
0x59,
|
|
1010598
|
|
); // *begins taming a creature.*
|
|
|
|
new InternalTimer(from, creature, Utility.Random(3, 2)).Start();
|
|
|
|
m_SetSkillTime = false;
|
|
}
|
|
}
|
|
|
|
private static void Pacify(BaseCreature bc) => bc.BardPacified = true; // Should use bc.Pacify with an end time?
|
|
|
|
private class InternalTimer : Timer
|
|
{
|
|
private readonly BaseCreature m_Creature;
|
|
private readonly int m_MaxCount;
|
|
private readonly DateTime m_StartTime;
|
|
private readonly Mobile m_Tamer;
|
|
private int m_Count;
|
|
private bool m_Paralyzed;
|
|
|
|
public InternalTimer(Mobile tamer, BaseCreature creature, int count) : base(
|
|
TimeSpan.FromSeconds(3.0),
|
|
TimeSpan.FromSeconds(3.0),
|
|
count
|
|
)
|
|
{
|
|
m_Tamer = tamer;
|
|
m_Creature = creature;
|
|
m_MaxCount = count;
|
|
m_Paralyzed = creature.Paralyzed;
|
|
m_StartTime = Core.Now;
|
|
}
|
|
|
|
protected override void OnTick()
|
|
{
|
|
m_Count++;
|
|
|
|
var de = m_Creature.FindMostRecentDamageEntry(false);
|
|
var alreadyOwned = m_Creature.Owners.Contains(m_Tamer);
|
|
|
|
if (!m_Tamer.InRange(m_Creature, Core.AOS ? 7 : 6))
|
|
{
|
|
m_BeingTamed.Remove(m_Creature);
|
|
m_Tamer.NextSkillTime = Core.TickCount;
|
|
m_Creature.PrivateOverheadMessage(
|
|
MessageType.Regular,
|
|
0x3B2,
|
|
502795,
|
|
m_Tamer.NetState
|
|
); // You are too far away to continue taming.
|
|
Stop();
|
|
}
|
|
else if (!m_Tamer.CheckAlive())
|
|
{
|
|
m_BeingTamed.Remove(m_Creature);
|
|
m_Tamer.NextSkillTime = Core.TickCount;
|
|
m_Creature.PrivateOverheadMessage(
|
|
MessageType.Regular,
|
|
0x3B2,
|
|
502796,
|
|
m_Tamer.NetState
|
|
); // You are dead, and cannot continue taming.
|
|
Stop();
|
|
}
|
|
else if (!m_Tamer.CanSee(m_Creature) || !m_Tamer.InLOS(m_Creature) || !CanPath())
|
|
{
|
|
m_BeingTamed.Remove(m_Creature);
|
|
m_Tamer.NextSkillTime = Core.TickCount;
|
|
m_Tamer.SendLocalizedMessage(
|
|
1049654
|
|
); // You do not have a clear path to the animal you are taming, and must cease your attempt.
|
|
Stop();
|
|
}
|
|
else if (!m_Creature.Tamable)
|
|
{
|
|
m_BeingTamed.Remove(m_Creature);
|
|
m_Tamer.NextSkillTime = Core.TickCount;
|
|
m_Creature.PrivateOverheadMessage(
|
|
MessageType.Regular,
|
|
0x3B2,
|
|
1049655,
|
|
m_Tamer.NetState
|
|
); // That creature cannot be tamed.
|
|
Stop();
|
|
}
|
|
else if (m_Creature.Controlled)
|
|
{
|
|
m_BeingTamed.Remove(m_Creature);
|
|
m_Tamer.NextSkillTime = Core.TickCount;
|
|
m_Creature.PrivateOverheadMessage(
|
|
MessageType.Regular,
|
|
0x3B2,
|
|
502804,
|
|
m_Tamer.NetState
|
|
); // That animal looks tame already.
|
|
Stop();
|
|
}
|
|
else if (m_Creature.Owners.Count >= BaseCreature.MaxOwners && !m_Creature.Owners.Contains(m_Tamer))
|
|
{
|
|
m_BeingTamed.Remove(m_Creature);
|
|
m_Tamer.NextSkillTime = Core.TickCount;
|
|
m_Creature.PrivateOverheadMessage(
|
|
MessageType.Regular,
|
|
0x3B2,
|
|
1005615,
|
|
m_Tamer.NetState
|
|
); // This animal has had too many owners and is too upset for you to tame.
|
|
Stop();
|
|
}
|
|
else if (MustBeSubdued(m_Creature))
|
|
{
|
|
m_BeingTamed.Remove(m_Creature);
|
|
m_Tamer.NextSkillTime = Core.TickCount;
|
|
m_Creature.PrivateOverheadMessage(
|
|
MessageType.Regular,
|
|
0x3B2,
|
|
1054025,
|
|
m_Tamer.NetState
|
|
); // You must subdue this creature before you can tame it!
|
|
Stop();
|
|
}
|
|
else if (de?.LastDamage > m_StartTime)
|
|
{
|
|
m_BeingTamed.Remove(m_Creature);
|
|
m_Tamer.NextSkillTime = Core.TickCount;
|
|
m_Creature.PrivateOverheadMessage(
|
|
MessageType.Regular,
|
|
0x3B2,
|
|
502794,
|
|
m_Tamer.NetState
|
|
); // The animal is too angry to continue taming.
|
|
Stop();
|
|
}
|
|
else if (m_Count < m_MaxCount)
|
|
{
|
|
m_Tamer.RevealingAction();
|
|
|
|
switch (Utility.Random(3))
|
|
{
|
|
case 0:
|
|
m_Tamer.PublicOverheadMessage(MessageType.Regular, 0x3B2, Utility.Random(502790, 4));
|
|
break;
|
|
case 1:
|
|
m_Tamer.PublicOverheadMessage(MessageType.Regular, 0x3B2, Utility.Random(1005608, 6));
|
|
break;
|
|
case 2:
|
|
m_Tamer.PublicOverheadMessage(MessageType.Regular, 0x3B2, Utility.Random(1010593, 4));
|
|
break;
|
|
}
|
|
|
|
if (!alreadyOwned) // Passively check animal lore for gain
|
|
{
|
|
m_Tamer.CheckTargetSkill(SkillName.AnimalLore, m_Creature, 0.0, 120.0);
|
|
}
|
|
|
|
if (m_Creature.Paralyzed)
|
|
{
|
|
m_Paralyzed = true;
|
|
}
|
|
}
|
|
else
|
|
{
|
|
m_Tamer.RevealingAction();
|
|
m_Tamer.NextSkillTime = Core.TickCount;
|
|
m_BeingTamed.Remove(m_Creature);
|
|
|
|
if (m_Creature.Paralyzed)
|
|
{
|
|
m_Paralyzed = true;
|
|
}
|
|
|
|
if (!alreadyOwned) // Passively check animal lore for gain
|
|
{
|
|
m_Tamer.CheckTargetSkill(SkillName.AnimalLore, m_Creature, 0.0, 120.0);
|
|
}
|
|
|
|
var minSkill = m_Creature.MinTameSkill + m_Creature.Owners.Count * 6.0;
|
|
|
|
if (minSkill > -24.9 && CheckMastery(m_Tamer, m_Creature))
|
|
{
|
|
minSkill = -24.9; // 50% at 0.0?
|
|
}
|
|
|
|
minSkill += 24.9;
|
|
|
|
if (CheckMastery(m_Tamer, m_Creature) || alreadyOwned ||
|
|
m_Tamer.CheckTargetSkill(SkillName.AnimalTaming, m_Creature, minSkill - 25.0, minSkill + 25.0))
|
|
{
|
|
if (m_Creature.Owners.Count == 0) // First tame
|
|
{
|
|
if (m_Creature is GreaterDragon)
|
|
{
|
|
ScaleSkills(m_Creature, 0.72, 0.90); // 72% of original skills trainable to 90%
|
|
m_Creature.Skills.Magery.Base =
|
|
m_Creature.Skills.Magery
|
|
.Cap; // Greater dragons have a 90% cap reduction and 90% skill reduction on magery
|
|
}
|
|
else if (m_Paralyzed)
|
|
{
|
|
ScaleSkills(
|
|
m_Creature,
|
|
0.86
|
|
); // 86% of original skills if they were paralyzed during the taming
|
|
}
|
|
else
|
|
{
|
|
ScaleSkills(m_Creature, 0.90); // 90% of original skills
|
|
}
|
|
|
|
if (m_Creature.StatLossAfterTame)
|
|
{
|
|
ScaleStats(m_Creature, 0.50);
|
|
}
|
|
}
|
|
|
|
if (alreadyOwned)
|
|
{
|
|
m_Tamer.SendLocalizedMessage(502797); // That wasn't even challenging.
|
|
}
|
|
else
|
|
{
|
|
m_Creature.PrivateOverheadMessage(
|
|
MessageType.Regular,
|
|
0x3B2,
|
|
502799,
|
|
m_Tamer.NetState
|
|
); // It seems to accept you as master.
|
|
m_Creature.Owners.Add(m_Tamer);
|
|
}
|
|
|
|
m_Creature.SetControlMaster(m_Tamer);
|
|
m_Creature.IsBonded = false;
|
|
}
|
|
else
|
|
{
|
|
m_Creature.PrivateOverheadMessage(
|
|
MessageType.Regular,
|
|
0x3B2,
|
|
502798,
|
|
m_Tamer.NetState
|
|
); // You fail to tame the creature.
|
|
}
|
|
}
|
|
}
|
|
|
|
private bool CanPath()
|
|
{
|
|
IPoint3D p = m_Tamer;
|
|
|
|
return p != null && (m_Creature.InRange(new Point3D(p), 1) ||
|
|
new MovementPath(m_Creature, new Point3D(p)).Success);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|