6b6cc10771
## Summary - Adds `Mobile.Murderer` virtual property and consolidates kill-threshold checks across the codebase - Tracks ping-pong count: how many times a player crosses the 5-kill murderer threshold (T2A/UOR/UOTD only, disabled on LBR+) - Adds `[CommandProperty]` to view a player's ping-pong count via the admin panel - After enough ping-pongs, player is permanently flagged as a murderer regardless of kill count - Accounts for perma-red players with low kills in murderer status transition notifications - Implements era-appropriate "I must consider my sins" speech responses: - **T2A**: contextual cliloc flavor text (502122–502126) - **UOR–AOS**: raw short/long-term murder counts + ping-pong count if applicable - **SE+**: localized stats message (1114370) - Refactors kill-report logic out of `Keywords.cs` into `PlayerMurderSystem.ReportKillsToSelf` ## Testing - [x] Thoroughly tested and self reviewed - [x] Test T2A "I must consider my sins" behaviour over all scenarios. - [x] Test UOR "I must consider my sins" behaviour over all scenarios. - [x] Test that LBR does not have ping pongs enabled (I must consider my sins) - [x] Test serialization cross over from v0 -> v1 increments 1 ping pong if player is already red. ## Notes * Manually setting kills to 5 does not trigger a ping pong, it must go through the actual murder system. This includes if the kills were manually set to 5 and then migrated (as manually setting kills to 5 never adds the player into the murder system - it only happens via ReportMurderer). This is arguably a bug in the existing system, but one that currently only ever happens via staff interaction. * Thieves guild SuspendOnMurder specifically checks for kills > 0. This means a person with 0 shorts but 5 ping pongs (flagged as murderer) can steal. This may be accurate, as according to a forum post this is how it works on UOSA which is the T2A gold standard. * This doesn't implement Pre-T2A behaviour which should be that "I must consider my sins" does nothing at all. The reason I didn't implement it for Pre-T2A is then it 100% have to sit behind a feature flag. I don't mind adding it as a feature flag, just let me know.
32 lines
No EOL
648 B
JSON
Generated
32 lines
No EOL
648 B
JSON
Generated
{
|
|
"version": 1,
|
|
"type": "Server.Engines.PlayerMurderSystem.MurderContext",
|
|
"properties": [
|
|
{
|
|
"name": "ShortTermElapse",
|
|
"type": "System.TimeSpan",
|
|
"rule": "PrimitiveTypeMigrationRule"
|
|
},
|
|
{
|
|
"name": "LongTermElapse",
|
|
"type": "System.TimeSpan",
|
|
"rule": "PrimitiveTypeMigrationRule"
|
|
},
|
|
{
|
|
"name": "ShortTermMurders",
|
|
"type": "int",
|
|
"rule": "PrimitiveTypeMigrationRule",
|
|
"ruleArguments": [
|
|
""
|
|
]
|
|
},
|
|
{
|
|
"name": "PingPong",
|
|
"type": "int",
|
|
"rule": "PrimitiveTypeMigrationRule",
|
|
"ruleArguments": [
|
|
""
|
|
]
|
|
}
|
|
]
|
|
} |