## Breaking Changes (New API)
ObjectPropertyList supports the following API:
```cs
list.Add(500000);
list.Add(500001, stringArgument);
list.Add("Some text");
list.Add($"Some text with {argument}");
list.Add(500002, $"{arg1}\t{arg2}");
```
## Notes
1. All API uses that require a formatter like this:
```cs
list.Add(500002, "{0}\t{1}", arg1, arg2);
```
Should be changed to use string interpolation, for example:
```cs
list.Add(500002, $"{arg1}\t{arg2}");
```
2. The following paradigm should no longer be used:
```cs
list.Add(1061170, prop.ToString()); // strength requirement ~1_val~
```
The new string interpolation API will avoid having to convert the argument to a string before writing it to the packet. Instead use the following:
```cs
list.Add(1061170, $"{prop}"); // strength requirement ~1_val~
```
### Benchmarks
```cs
| Method | Mean | Error | StdDev | Gen 0 | Allocated |
|------------------------------- |---------:|--------:|--------:|-------:|----------:|
| BenchmarkOldOPL | 241.0 ns | 0.56 ns | 0.47 ns | 0.0105 | 88 B |
| BenchmarkStringInterpolatedOPL | 199.9 ns | 2.44 ns | 2.39 ns | - | - |
```
### Changes
- [X] Removes crash in STArray.Return when array is null.
- [X] Fixes NPE in OPL when entity is null. Serial in packet will be 0 when entity is null.
- [X] Fixes NPE in AosAttributes when Parent is null.
- [X] Changes OPL to use string interpolation.
- [X] Introduces `IPropertyList` to allow extending PropertyList for other uses.
171 lines
4.7 KiB
C#
171 lines
4.7 KiB
C#
using Server.Gumps;
|
|
using Server.Network;
|
|
|
|
namespace Server.Items
|
|
{
|
|
public abstract class PromotionalToken : Item
|
|
{
|
|
public PromotionalToken() : base(0x2AAA)
|
|
{
|
|
LootType = LootType.Blessed;
|
|
Light = LightType.Circle300;
|
|
Weight = 5.0;
|
|
}
|
|
|
|
public PromotionalToken(Serial serial) : base(serial)
|
|
{
|
|
}
|
|
|
|
public abstract TextDefinition ItemName { get; }
|
|
public abstract TextDefinition ItemReceiveMessage { get; }
|
|
public abstract TextDefinition ItemGumpName { get; }
|
|
|
|
public override int LabelNumber => 1070997; // A promotional token
|
|
public abstract Item CreateItemFor(Mobile from);
|
|
|
|
public override void GetProperties(IPropertyList list)
|
|
{
|
|
base.GetProperties(list);
|
|
|
|
list.Add(1070998, $"{ItemName}"); // Use this to redeem<br>your ~1_PROMO~
|
|
}
|
|
|
|
public override void OnDoubleClick(Mobile from)
|
|
{
|
|
if (!IsChildOf(from.Backpack))
|
|
{
|
|
from.SendLocalizedMessage(1062334); // This item must be in your backpack to be used.
|
|
}
|
|
else
|
|
{
|
|
from.CloseGump<PromotionalTokenGump>();
|
|
from.SendGump(new PromotionalTokenGump(this));
|
|
}
|
|
}
|
|
|
|
public override void OnRemoved(IEntity parent)
|
|
{
|
|
Mobile m = null;
|
|
|
|
if (parent is Item item)
|
|
{
|
|
m = item.RootParent as Mobile;
|
|
}
|
|
else if (parent is Mobile mobile)
|
|
{
|
|
m = mobile;
|
|
}
|
|
|
|
m?.CloseGump<PromotionalTokenGump>();
|
|
}
|
|
|
|
public override void Serialize(IGenericWriter writer)
|
|
{
|
|
base.Serialize(writer);
|
|
|
|
writer.Write(0);
|
|
}
|
|
|
|
public override void Deserialize(IGenericReader reader)
|
|
{
|
|
base.Deserialize(reader);
|
|
|
|
var version = reader.ReadInt();
|
|
}
|
|
|
|
private class PromotionalTokenGump : Gump
|
|
{
|
|
private readonly PromotionalToken m_Token;
|
|
|
|
public PromotionalTokenGump(PromotionalToken token) : base(10, 10)
|
|
{
|
|
m_Token = token;
|
|
|
|
AddPage(0);
|
|
|
|
AddBackground(0, 0, 240, 135, 0x2422);
|
|
AddHtmlLocalized(
|
|
15,
|
|
15,
|
|
210,
|
|
75,
|
|
1070972,
|
|
0x0,
|
|
true
|
|
); // Click "OKAY" to redeem the following promotional item:
|
|
TextDefinition.AddHtmlText(this, 15, 60, 210, 75, m_Token.ItemGumpName, false, false);
|
|
|
|
AddButton(160, 95, 0xF7, 0xF8, 1); // Okay
|
|
AddButton(90, 95, 0xF2, 0xF1, 0); // Cancel
|
|
}
|
|
|
|
public override void OnResponse(NetState sender, RelayInfo info)
|
|
{
|
|
if (info.ButtonID != 1)
|
|
{
|
|
return;
|
|
}
|
|
|
|
var from = sender.Mobile;
|
|
|
|
if (!m_Token.IsChildOf(from.Backpack))
|
|
{
|
|
from.SendLocalizedMessage(1062334); // This item must be in your backpack to be used.
|
|
}
|
|
else
|
|
{
|
|
var i = m_Token.CreateItemFor(from);
|
|
|
|
if (i != null)
|
|
{
|
|
from.BankBox.AddItem(i);
|
|
TextDefinition.SendMessageTo(from, m_Token.ItemReceiveMessage);
|
|
m_Token.Delete();
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
public class SoulstoneFragmentToken : PromotionalToken
|
|
{
|
|
[Constructible]
|
|
public SoulstoneFragmentToken()
|
|
{
|
|
}
|
|
|
|
public SoulstoneFragmentToken(Serial serial) : base(serial)
|
|
{
|
|
}
|
|
|
|
public override TextDefinition ItemGumpName => 1070999; // <center>Soulstone Fragment</center>
|
|
public override TextDefinition ItemName => 1071000; // soulstone fragment
|
|
|
|
public override TextDefinition ItemReceiveMessage =>
|
|
1070976; // A soulstone fragment has been created in your bank box.
|
|
|
|
public override Item CreateItemFor(Mobile from)
|
|
{
|
|
if (from?.Account != null)
|
|
{
|
|
return new SoulstoneFragment(from.Account.ToString());
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
public override void Serialize(IGenericWriter writer)
|
|
{
|
|
base.Serialize(writer);
|
|
|
|
writer.Write(0);
|
|
}
|
|
|
|
public override void Deserialize(IGenericReader reader)
|
|
{
|
|
base.Deserialize(reader);
|
|
|
|
var version = reader.ReadInt();
|
|
}
|
|
}
|
|
}
|