ecbee17690
## Breaking Changes (New API)
ObjectPropertyList supports the following API:
```cs
list.Add(500000);
list.Add(500001, stringArgument);
list.Add("Some text");
list.Add($"Some text with {argument}");
list.Add(500002, $"{arg1}\t{arg2}");
```
## Notes
1. All API uses that require a formatter like this:
```cs
list.Add(500002, "{0}\t{1}", arg1, arg2);
```
Should be changed to use string interpolation, for example:
```cs
list.Add(500002, $"{arg1}\t{arg2}");
```
2. The following paradigm should no longer be used:
```cs
list.Add(1061170, prop.ToString()); // strength requirement ~1_val~
```
The new string interpolation API will avoid having to convert the argument to a string before writing it to the packet. Instead use the following:
```cs
list.Add(1061170, $"{prop}"); // strength requirement ~1_val~
```
### Benchmarks
```cs
| Method | Mean | Error | StdDev | Gen 0 | Allocated |
|------------------------------- |---------:|--------:|--------:|-------:|----------:|
| BenchmarkOldOPL | 241.0 ns | 0.56 ns | 0.47 ns | 0.0105 | 88 B |
| BenchmarkStringInterpolatedOPL | 199.9 ns | 2.44 ns | 2.39 ns | - | - |
```
### Changes
- [X] Removes crash in STArray.Return when array is null.
- [X] Fixes NPE in OPL when entity is null. Serial in packet will be 0 when entity is null.
- [X] Fixes NPE in AosAttributes when Parent is null.
- [X] Changes OPL to use string interpolation.
- [X] Introduces `IPropertyList` to allow extending PropertyList for other uses.
60 lines
1.6 KiB
C#
60 lines
1.6 KiB
C#
using System;
|
|
|
|
namespace Server.Items
|
|
{
|
|
public class ArcaneFocus : TransientItem
|
|
{
|
|
[Constructible]
|
|
public ArcaneFocus()
|
|
: this(TimeSpan.FromHours(1), 1)
|
|
{
|
|
}
|
|
|
|
[Constructible]
|
|
public ArcaneFocus(int lifeSpan, int strengthBonus)
|
|
: this(TimeSpan.FromSeconds(lifeSpan), strengthBonus)
|
|
{
|
|
}
|
|
|
|
public ArcaneFocus(TimeSpan lifeSpan, int strengthBonus) : base(0x3155, lifeSpan)
|
|
{
|
|
LootType = LootType.Blessed;
|
|
StrengthBonus = strengthBonus;
|
|
}
|
|
|
|
public ArcaneFocus(Serial serial) : base(serial)
|
|
{
|
|
}
|
|
|
|
public override int LabelNumber => 1032629; // Arcane Focus
|
|
|
|
[CommandProperty(AccessLevel.GameMaster)]
|
|
public int StrengthBonus { get; set; }
|
|
|
|
public override TextDefinition InvalidTransferMessage => 1073480; // Your arcane focus disappears.
|
|
public override bool Nontransferable => true;
|
|
|
|
public override void GetProperties(IPropertyList list)
|
|
{
|
|
base.GetProperties(list);
|
|
|
|
list.Add(1060485, $"{StrengthBonus}"); // strength bonus ~1_val~
|
|
}
|
|
|
|
public override void Serialize(IGenericWriter writer)
|
|
{
|
|
base.Serialize(writer);
|
|
writer.Write(0);
|
|
|
|
writer.Write(StrengthBonus);
|
|
}
|
|
|
|
public override void Deserialize(IGenericReader reader)
|
|
{
|
|
base.Deserialize(reader);
|
|
var version = reader.ReadInt();
|
|
|
|
StrengthBonus = reader.ReadInt();
|
|
}
|
|
}
|
|
}
|