## Summary Migrates 16 player-facing legacy `Gump` subclasses in the Veteran Rewards system to `DynamicGump` or `StaticGump<T>`, renames every nested `InternalGump`/`ConfirmGump` to system-prefixed names, and updates external callers to use new static `DisplayTo` entry points. ### Reward chain (Engines/Veteran Rewards) | Gump | Base type | Reasoning | |---|---|---| | `RewardNoticeGump` | `StaticGump<T>` | Fixed layout | | `RewardChoiceGump` | `DynamicGump` | Layout shape varies (per-player categories, entries, pages) | | `RewardConfirmGump` | `DynamicGump` | `entry.Name` is a dynamic cliloc per reward (cliloc rule) | | `RewardOptionGump` | `DynamicGump` | Title cliloc and per-option clilocs are dynamic (cliloc rule) | | `RewardDemolitionGump` | `DynamicGump` | `question` cliloc is dynamic per caller (cliloc rule) | ### Statue (Engines/Veteran Rewards/Character Statue Maker) | Gump | Base type | Reasoning | |---|---|---| | `CharacterStatueGump` | `DynamicGump` | Pose/Direction/Material labels are dynamic clilocs (cliloc rule) | | `CharacterPlinthGump` | `DynamicGump` | `statue.Name`, sculpted-on date, and statue-type cliloc are dynamic (cliloc rule) | ### Decorations (Items/Special/Veteran Rewards) — every `InternalGump` renamed | Original | New name | Base type | Reasoning | |---|---|---|---| | `Banner.InternalGump` | `BannerGump` | `StaticGump<T>` | Fully fixed item-id picker over `Start..End` range | | `Brazier.InternalGump` | `BrazierGump` | `StaticGump<T>` | Fixed two-item picker | | `Cannon.InternalGump` | `CannonGump` | `DynamicGump` | `keg.Validate()` value passed as `~1_CHARGES~` arg (cliloc-arg rule) | | `DecorativeShield.InternalGump` | `DecorativeShieldGump` | `StaticGump<T>` | Fixed item picker over a constant range | | `DecorativeShield.FacingGump` | `DecorativeShieldFacingGump` | `DynamicGump` | Item ids depend on instance state | | `HangingSkeleton.InternalGump` | `HangingSkeletonGump` | `StaticGump<T>` | Fixed item picker (5 hard-coded ids) | | `PottedCactus.InternalGump` | `PottedCactusGump` | `StaticGump<T>` | Fixed 6-item picker | | `StoneAnkh.InternalGump` | `StoneAnkhGump` | `StaticGump<T>` | Fixed two-direction picker | | `WallBanner.InternalGump` | `WallBannerGump` | `StaticGump<T>` | Fixed 30-banner picker across 5 pages | | `WeaponEngravingTool.InternalGump` | `WeaponEngravingToolGump` | `StaticGump<T>` | Fixed text-entry dialog | | `WeaponEngravingTool.ConfirmGump` | `WeaponEngravingToolConfirmGump` | `DynamicGump` | Layout branches on `guildmaster != null` | ### External callers updated `RewardSystem`, `CharacterStatue`, `FireFliesDeed`, `FlamingHead`, `Banner`, `DecorativeShield`, `HangingSkeleton`, `StoneAnkh` (RewardDemolitionGump callers); `AnkhOfSacrifice`, `Cannon`, `MiningCart`, `MinotaurStatue`, `TreeStump` (RewardOptionGump callers); `TinkerGuildmaster` (engraver confirm gump). The pre-existing `FacingGump` inside `Banner.cs` (already `DynamicGump`) was left as-is — it is private, nested inside `InternalTarget`, and never referenced outside.
90 lines
2.3 KiB
C#
90 lines
2.3 KiB
C#
using Server.Items;
|
|
using Server.Multis;
|
|
using Server.Network;
|
|
|
|
namespace Server.Gumps;
|
|
|
|
public class RewardDemolitionGump : DynamicGump
|
|
{
|
|
private readonly IAddon _addon;
|
|
private readonly int _question;
|
|
|
|
public override bool Singleton => true;
|
|
|
|
private RewardDemolitionGump(IAddon addon, int question) : base(150, 50)
|
|
{
|
|
_addon = addon;
|
|
_question = question;
|
|
}
|
|
|
|
public static void DisplayTo(Mobile from, IAddon addon, int question)
|
|
{
|
|
if (from?.NetState == null || addon is not Item item || item.Deleted)
|
|
{
|
|
return;
|
|
}
|
|
|
|
from.SendGump(new RewardDemolitionGump(addon, question));
|
|
}
|
|
|
|
protected override void BuildLayout(ref DynamicGumpBuilder builder)
|
|
{
|
|
builder.AddPage();
|
|
|
|
builder.AddBackground(0, 0, 220, 170, 0x13BE);
|
|
builder.AddBackground(10, 10, 200, 150, 0xBB8);
|
|
|
|
builder.AddHtmlLocalized(20, 30, 180, 60, _question); // Do you wish to re-deed this decoration?
|
|
|
|
builder.AddHtmlLocalized(55, 100, 150, 25, 1011011); // CONTINUE
|
|
builder.AddButton(20, 100, 0xFA5, 0xFA7, (int)Buttons.Confirm);
|
|
|
|
builder.AddHtmlLocalized(55, 125, 150, 25, 1011012); // CANCEL
|
|
builder.AddButton(20, 125, 0xFA5, 0xFA7, (int)Buttons.Cancel);
|
|
}
|
|
|
|
public override void OnResponse(NetState sender, in RelayInfo info)
|
|
{
|
|
if (_addon is not Item item || item.Deleted)
|
|
{
|
|
return;
|
|
}
|
|
|
|
if (info.ButtonID != (int)Buttons.Confirm)
|
|
{
|
|
return;
|
|
}
|
|
|
|
var m = sender.Mobile;
|
|
var house = BaseHouse.FindHouseAt(m);
|
|
|
|
if (house?.IsOwner(m) != true)
|
|
{
|
|
// You can only re-deed this decoration if you are the house owner or originally placed the decoration.
|
|
m.SendLocalizedMessage(1049784);
|
|
return;
|
|
}
|
|
|
|
if (m.InRange(item.Location, 2))
|
|
{
|
|
var deed = _addon.Deed;
|
|
|
|
if (deed != null)
|
|
{
|
|
m.AddToBackpack(deed);
|
|
house.Addons.Remove(item);
|
|
item.Delete();
|
|
}
|
|
}
|
|
else
|
|
{
|
|
m.LocalOverheadMessage(MessageType.Regular, 0x3B2, 1019045); // I can't reach that.
|
|
}
|
|
}
|
|
|
|
private enum Buttons
|
|
{
|
|
Cancel,
|
|
Confirm
|
|
}
|
|
}
|