## Summary Migrates 16 player-facing legacy `Gump` subclasses in the Veteran Rewards system to `DynamicGump` or `StaticGump<T>`, renames every nested `InternalGump`/`ConfirmGump` to system-prefixed names, and updates external callers to use new static `DisplayTo` entry points. ### Reward chain (Engines/Veteran Rewards) | Gump | Base type | Reasoning | |---|---|---| | `RewardNoticeGump` | `StaticGump<T>` | Fixed layout | | `RewardChoiceGump` | `DynamicGump` | Layout shape varies (per-player categories, entries, pages) | | `RewardConfirmGump` | `DynamicGump` | `entry.Name` is a dynamic cliloc per reward (cliloc rule) | | `RewardOptionGump` | `DynamicGump` | Title cliloc and per-option clilocs are dynamic (cliloc rule) | | `RewardDemolitionGump` | `DynamicGump` | `question` cliloc is dynamic per caller (cliloc rule) | ### Statue (Engines/Veteran Rewards/Character Statue Maker) | Gump | Base type | Reasoning | |---|---|---| | `CharacterStatueGump` | `DynamicGump` | Pose/Direction/Material labels are dynamic clilocs (cliloc rule) | | `CharacterPlinthGump` | `DynamicGump` | `statue.Name`, sculpted-on date, and statue-type cliloc are dynamic (cliloc rule) | ### Decorations (Items/Special/Veteran Rewards) — every `InternalGump` renamed | Original | New name | Base type | Reasoning | |---|---|---|---| | `Banner.InternalGump` | `BannerGump` | `StaticGump<T>` | Fully fixed item-id picker over `Start..End` range | | `Brazier.InternalGump` | `BrazierGump` | `StaticGump<T>` | Fixed two-item picker | | `Cannon.InternalGump` | `CannonGump` | `DynamicGump` | `keg.Validate()` value passed as `~1_CHARGES~` arg (cliloc-arg rule) | | `DecorativeShield.InternalGump` | `DecorativeShieldGump` | `StaticGump<T>` | Fixed item picker over a constant range | | `DecorativeShield.FacingGump` | `DecorativeShieldFacingGump` | `DynamicGump` | Item ids depend on instance state | | `HangingSkeleton.InternalGump` | `HangingSkeletonGump` | `StaticGump<T>` | Fixed item picker (5 hard-coded ids) | | `PottedCactus.InternalGump` | `PottedCactusGump` | `StaticGump<T>` | Fixed 6-item picker | | `StoneAnkh.InternalGump` | `StoneAnkhGump` | `StaticGump<T>` | Fixed two-direction picker | | `WallBanner.InternalGump` | `WallBannerGump` | `StaticGump<T>` | Fixed 30-banner picker across 5 pages | | `WeaponEngravingTool.InternalGump` | `WeaponEngravingToolGump` | `StaticGump<T>` | Fixed text-entry dialog | | `WeaponEngravingTool.ConfirmGump` | `WeaponEngravingToolConfirmGump` | `DynamicGump` | Layout branches on `guildmaster != null` | ### External callers updated `RewardSystem`, `CharacterStatue`, `FireFliesDeed`, `FlamingHead`, `Banner`, `DecorativeShield`, `HangingSkeleton`, `StoneAnkh` (RewardDemolitionGump callers); `AnkhOfSacrifice`, `Cannon`, `MiningCart`, `MinotaurStatue`, `TreeStump` (RewardOptionGump callers); `TinkerGuildmaster` (engraver confirm gump). The pre-existing `FacingGump` inside `Banner.cs` (already `DynamicGump`) was left as-is — it is private, nested inside `InternalTarget`, and never referenced outside.
115 lines
2.7 KiB
C#
115 lines
2.7 KiB
C#
using System.Collections.Generic;
|
|
using Server.Network;
|
|
|
|
namespace Server.Gumps;
|
|
|
|
public interface IRewardOption
|
|
{
|
|
void GetOptions(RewardOptionList list);
|
|
void OnOptionSelected(Mobile from, int choice);
|
|
}
|
|
|
|
public class RewardOptionGump : DynamicGump
|
|
{
|
|
private readonly IRewardOption _option;
|
|
private readonly RewardOptionList _options = new();
|
|
private readonly int _title;
|
|
|
|
public override bool Singleton => true;
|
|
|
|
private RewardOptionGump(IRewardOption option, int title) : base(60, 36)
|
|
{
|
|
_option = option;
|
|
_title = title;
|
|
|
|
_option?.GetOptions(_options);
|
|
}
|
|
|
|
public static void DisplayTo(Mobile from, IRewardOption option, int title = 0)
|
|
{
|
|
if (from?.NetState == null || option == null)
|
|
{
|
|
return;
|
|
}
|
|
|
|
from.SendGump(new RewardOptionGump(option, title));
|
|
}
|
|
|
|
protected override void BuildLayout(ref DynamicGumpBuilder builder)
|
|
{
|
|
builder.AddPage();
|
|
|
|
builder.AddBackground(0, 0, 273, 324, 0x13BE);
|
|
builder.AddImageTiled(10, 10, 253, 20, 0xA40);
|
|
builder.AddImageTiled(10, 40, 253, 244, 0xA40);
|
|
builder.AddImageTiled(10, 294, 253, 20, 0xA40);
|
|
builder.AddAlphaRegion(10, 10, 253, 304);
|
|
|
|
builder.AddButton(10, 294, 0xFB1, 0xFB2, 0);
|
|
builder.AddHtmlLocalized(45, 296, 450, 20, 1060051, 0x7FFF); // CANCEL
|
|
|
|
if (_title > 0)
|
|
{
|
|
builder.AddHtmlLocalized(14, 12, 273, 20, _title, 0x7FFF);
|
|
}
|
|
else
|
|
{
|
|
builder.AddHtmlLocalized(14, 12, 273, 20, 1080392, 0x7FFF); // Select your choice from the menu below.
|
|
}
|
|
|
|
builder.AddPage(1);
|
|
|
|
for (var i = 0; i < _options.Count; i++)
|
|
{
|
|
builder.AddButton(19, 49 + i * 24, 0x845, 0x846, _options[i].ID);
|
|
builder.AddHtmlLocalized(44, 47 + i * 24, 213, 20, _options[i].Cliloc, 0x7FFF);
|
|
}
|
|
}
|
|
|
|
public override void OnResponse(NetState sender, in RelayInfo info)
|
|
{
|
|
if (_option != null && Contains(info.ButtonID))
|
|
{
|
|
_option.OnOptionSelected(sender.Mobile, info.ButtonID);
|
|
}
|
|
}
|
|
|
|
private bool Contains(int chosen)
|
|
{
|
|
if (_options == null)
|
|
{
|
|
return false;
|
|
}
|
|
|
|
foreach (var option in _options)
|
|
{
|
|
if (option.ID == chosen)
|
|
{
|
|
return true;
|
|
}
|
|
}
|
|
|
|
return false;
|
|
}
|
|
}
|
|
|
|
public class RewardOption
|
|
{
|
|
public RewardOption(int id, int cliloc)
|
|
{
|
|
ID = id;
|
|
Cliloc = cliloc;
|
|
}
|
|
|
|
public int ID { get; }
|
|
|
|
public int Cliloc { get; }
|
|
}
|
|
|
|
public class RewardOptionList : List<RewardOption>
|
|
{
|
|
public void Add(int id, int cliloc)
|
|
{
|
|
Add(new RewardOption(id, cliloc));
|
|
}
|
|
}
|