ModernUO/Projects/UOContent/Items/Clothing/Shoes.cs
Kamron Batman 73f9688083
feat: adopt serialization generator v4 (field-side linkage, anchored timers) (#2586)
## Summary

Adopts ModernUO.Serialization 4.0.0 across the engine. Three commits, reviewable independently:

1. **Package + tool bump to 4.0.0** (`Server.csproj`, `UOContent.csproj`, `dotnet-tools.json`).
2. **Timers → `[DeserializeTimer]`** — the 8 drifting timers (BaseLight, TreasureMapChest, MarkContainer, FillableContainer, DeathRobe, DecayedCorpse, Corpse, BaseEscortable) now store their next tick as **anchored time**: server downtime no longer consumes the remaining delay, and idle-world saves are byte-stable. This changes their wire format, so each class bumps its serialization version with a `MigrateFrom` that replays the old delta-time read through the migration schema (the new `vN.json` files carry `@AnchoredTimer`; the old ones keep `@TimerDrift`, which the generator reads forever). The 2 wall-clock timers (Aquarium, FountainOfLife) keep their exact format via `wallClock: true` — no bump. Restart methods drop their `TimeSpan.MinValue` sentinel checks: v4 invokes them **only when a timer was actually running at save**.
3. **Linkage → field-side declarations** — 175 conversions across 25 files: `[SerializableFieldSaveFlag(order)]`/`[SerializableFieldDefault(order)]` become `[SaveFlag(nameof(...), nameof(...))]` on the field, and `[SerializableFieldChanged(order)]` becomes the `fieldChanged:` argument of `[SerializableField]`. **Wire-neutral: zero migration schemas changed.**

## Verification

- Solution builds with **0 errors, 0 warnings**; all three 4.0.0 packages verified indexed on nuget.org (no local feed needed).
- **835 + 708 tests green.**
- Generated output inspected: old-version content structs replay `ReadDeltaTime` (e.g. `V3Content.DecayTimerNext = reader.ReadDeltaTime()`), current versions write/read anchored time with the gated restart, and the wall-clock classes emit byte-identical `Write`/`ReadDateTime` framing.
- Schema tool run is committed (CI's `git diff --exit-code` schema check passes): exactly the 8 expected new `vN.json` files, nothing else touched.
- The conversion was scripted with a class-scoped resolver (order → same-class `[SerializableField(order)]`/`[SerializableProperty(order)]`); it planned 175/175 with zero ambiguities before applying.

## Notes

- New `MigrateFrom`s use the content structs' provided `XxxDelay` property, matching the pre-existing idiom in Corpse's and TreasureMapChest's older migrations.
- Follow-up candidate (separate PR, wire-neutral, any time): fold the ~150 eligible hand-written `[SerializableProperty]` setters (clamps, post-change side effects) down to `[SerializableField]` with `allowFieldChange`/`fieldChanged` hooks.
2026-08-22 17:54:02 -07:00

231 lines
6 KiB
C#

using System.Runtime.CompilerServices;
using ModernUO.Serialization;
namespace Server.Items
{
[SerializationGenerator(0, false)]
public abstract partial class BaseShoes : BaseClothing
{
public BaseShoes(int itemID, int hue = 0) : base(itemID, Layer.Shoes, hue)
{
}
public override bool Scissor(Mobile from, Scissors scissors)
{
if (DefaultResource == CraftResource.None)
{
return base.Scissor(from, scissors);
}
from.SendLocalizedMessage(502440); // Scissors can not be used on that to produce anything.
return false;
}
}
[Flippable(0x2307, 0x2308)]
[SerializationGenerator(0, false)]
public partial class FurBoots : BaseShoes
{
[Constructible]
public FurBoots(int hue = 0) : base(0x2307, hue)
{
}
public override double DefaultWeight => 3.0;
}
[Flippable(0x170b, 0x170c)]
[SerializationGenerator(0, false)]
public partial class Boots : BaseShoes
{
[Constructible]
public Boots(int hue = 0) : base(0x170B, hue)
{
}
public override double DefaultWeight => 3.0;
public override CraftResource DefaultResource => CraftResource.RegularLeather;
}
[Flippable]
[SerializationGenerator(2, false)]
public partial class ThighBoots : BaseShoes, IArcaneEquip
{
[EncodedInt]
[InvalidateProperties]
[SerializableField(0, fieldChanged: nameof(OnCurArcaneChargesChanged))]
[SerializedCommandProperty(AccessLevel.GameMaster)]
private int _curArcaneCharges;
[MethodImpl(MethodImplOptions.AggressiveInlining)]
private void OnCurArcaneChargesChanged(int oldValue, int newValue) => Update();
[Constructible]
public ThighBoots(int hue = 0) : base(0x1711, hue)
{
}
public override double DefaultWeight => 4.0;
public override CraftResource DefaultResource => CraftResource.RegularLeather;
[EncodedInt]
[SerializableProperty(1)]
[CommandProperty(AccessLevel.GameMaster)]
public int MaxArcaneCharges
{
get => _maxArcaneCharges;
set
{
_maxArcaneCharges = value;
InvalidateProperties();
Update();
this.MarkDirty();
}
}
[CommandProperty(AccessLevel.GameMaster)]
public bool IsArcane => _maxArcaneCharges > 0 && _curArcaneCharges >= 0;
private void Deserialize(IGenericReader reader, int version)
{
if (reader.ReadBool())
{
_curArcaneCharges = reader.ReadInt();
_maxArcaneCharges = reader.ReadInt();
}
}
public override void OnSingleClick(Mobile from)
{
base.OnSingleClick(from);
if (IsArcane)
{
LabelTo(from, 1061837, $"{_curArcaneCharges}\t{_maxArcaneCharges}");
}
}
public void Update()
{
if (IsArcane)
{
ItemID = 0x26AF;
}
else if (ItemID == 0x26AF)
{
ItemID = 0x1711;
}
if (IsArcane && CurArcaneCharges == 0)
{
Hue = 0;
}
}
public override void GetProperties(IPropertyList list)
{
base.GetProperties(list);
if (IsArcane)
{
list.Add(1061837, $"{_curArcaneCharges}\t{_maxArcaneCharges}"); // arcane charges: ~1_val~ / ~2_val~
}
}
public void Flip()
{
ItemID = ItemID switch
{
0x1711 => 0x1712,
0x1712 => 0x1711,
_ => ItemID
};
}
}
[Flippable(0x170f, 0x1710)]
[SerializationGenerator(0, false)]
public partial class Shoes : BaseShoes
{
[Constructible]
public Shoes(int hue = 0) : base(0x170F, hue)
{
}
public override double DefaultWeight => 2.0;
public override CraftResource DefaultResource => CraftResource.RegularLeather;
}
[Flippable(0x170d, 0x170e)]
[SerializationGenerator(0, false)]
public partial class Sandals : BaseShoes
{
[Constructible]
public Sandals(int hue = 0) : base(0x170D, hue)
{
}
public override double DefaultWeight => 1.0;
public override CraftResource DefaultResource => CraftResource.RegularLeather;
public override bool Dye(Mobile from, DyeTub sender) => false;
}
[Flippable(0x2797, 0x27E2)]
[SerializationGenerator(0, false)]
public partial class NinjaTabi : BaseShoes
{
[Constructible]
public NinjaTabi(int hue = 0) : base(0x2797, hue)
{
}
public override double DefaultWeight => 2.0;
}
[Flippable(0x2796, 0x27E1)]
[SerializationGenerator(0, false)]
public partial class SamuraiTabi : BaseShoes
{
[Constructible]
public SamuraiTabi(int hue = 0) : base(0x2796, hue)
{
}
public override double DefaultWeight => 2.0;
}
[Flippable(0x2796, 0x27E1)]
[SerializationGenerator(0, false)]
public partial class Waraji : BaseShoes
{
[Constructible]
public Waraji(int hue = 0) : base(0x2796, hue)
{
}
public override double DefaultWeight => 2.0;
}
[Flippable(0x2FC4, 0x317A)]
[SerializationGenerator(0)]
public partial class ElvenBoots : BaseShoes
{
[Constructible]
public ElvenBoots(int hue = 0) : base(0x2FC4, hue)
{
}
public override double DefaultWeight => 2.0;
public override CraftResource DefaultResource => CraftResource.RegularLeather;
public override int RequiredRaces => Race.AllowElvesOnly;
public override bool Dye(Mobile from, DyeTub sender) => false;
}
}