ModernUO/Projects/UOContent/Items/Special/8th Anniversary Items/FountainOfLife.cs
Kamron Batman 73f9688083
feat: adopt serialization generator v4 (field-side linkage, anchored timers) (#2586)
## Summary

Adopts ModernUO.Serialization 4.0.0 across the engine. Three commits, reviewable independently:

1. **Package + tool bump to 4.0.0** (`Server.csproj`, `UOContent.csproj`, `dotnet-tools.json`).
2. **Timers → `[DeserializeTimer]`** — the 8 drifting timers (BaseLight, TreasureMapChest, MarkContainer, FillableContainer, DeathRobe, DecayedCorpse, Corpse, BaseEscortable) now store their next tick as **anchored time**: server downtime no longer consumes the remaining delay, and idle-world saves are byte-stable. This changes their wire format, so each class bumps its serialization version with a `MigrateFrom` that replays the old delta-time read through the migration schema (the new `vN.json` files carry `@AnchoredTimer`; the old ones keep `@TimerDrift`, which the generator reads forever). The 2 wall-clock timers (Aquarium, FountainOfLife) keep their exact format via `wallClock: true` — no bump. Restart methods drop their `TimeSpan.MinValue` sentinel checks: v4 invokes them **only when a timer was actually running at save**.
3. **Linkage → field-side declarations** — 175 conversions across 25 files: `[SerializableFieldSaveFlag(order)]`/`[SerializableFieldDefault(order)]` become `[SaveFlag(nameof(...), nameof(...))]` on the field, and `[SerializableFieldChanged(order)]` becomes the `fieldChanged:` argument of `[SerializableField]`. **Wire-neutral: zero migration schemas changed.**

## Verification

- Solution builds with **0 errors, 0 warnings**; all three 4.0.0 packages verified indexed on nuget.org (no local feed needed).
- **835 + 708 tests green.**
- Generated output inspected: old-version content structs replay `ReadDeltaTime` (e.g. `V3Content.DecayTimerNext = reader.ReadDeltaTime()`), current versions write/read anchored time with the gated restart, and the wall-clock classes emit byte-identical `Write`/`ReadDateTime` framing.
- Schema tool run is committed (CI's `git diff --exit-code` schema check passes): exactly the 8 expected new `vN.json` files, nothing else touched.
- The conversion was scripted with a class-scoped resolver (order → same-class `[SerializableField(order)]`/`[SerializableProperty(order)]`); it planned 175/175 with zero ambiguities before applying.

## Notes

- New `MigrateFrom`s use the content structs' provided `XxxDelay` property, matching the pre-existing idiom in Corpse's and TreasureMapChest's older migrations.
- Follow-up candidate (separate PR, wire-neutral, any time): fold the ~150 eligible hand-written `[SerializableProperty]` setters (clamps, post-change side effects) down to `[SerializableField]` with `allowFieldChange`/`fieldChanged` hooks.
2026-08-22 17:54:02 -07:00

198 lines
4.9 KiB
C#

using System;
using ModernUO.Serialization;
namespace Server.Items;
[SerializationGenerator(0)]
public partial class EnhancedBandage : Bandage
{
[Constructible]
public EnhancedBandage(int amount = 1) : base(amount) => Hue = 0x8A5;
// TODO: On BandageContext, check if enhanced, and add this value
public const int HealingBonus = 10;
public override int LabelNumber => 1152441; // enhanced bandage
public override bool Dye(Mobile from, DyeTub sender) => false;
public override void AddNameProperties(IPropertyList list)
{
base.AddNameProperties(list);
list.Add(1075216); // these bandages have been enhanced
}
}
[Flippable(0x2AC0, 0x2AC3)]
[SerializationGenerator(1)]
public partial class FountainOfLife : BaseAddonContainer
{
public const int MaxCharges = 10;
[SerializableField(1)]
[DeserializeTimer(nameof(DeserializeTimer), wallClock: true)]
private Timer _timer;
[Constructible]
public FountainOfLife(int charges = MaxCharges) : base(0x2AC0)
{
_charges = charges;
}
private void DeserializeTimer(TimeSpan delay)
{
_timer = Timer.DelayCall(Utility.Max(delay, TimeSpan.Zero), RechargeTime, Recharge);
}
public override BaseAddonContainerDeed Deed => new FountainOfLifeDeed(_charges);
public virtual TimeSpan RechargeTime => TimeSpan.FromDays(1);
public override int LabelNumber => 1075197; // Fountain of Life
public override int DefaultGumpID => 0x484;
public override int DefaultDropSound => 66;
public override int DefaultMaxItems => 125;
[SerializableProperty(0)]
[CommandProperty(AccessLevel.GameMaster)]
public int Charges
{
get => _charges;
set
{
_charges = Math.Min(value, MaxCharges);
InvalidateProperties();
this.MarkDirty();
}
}
public override bool OnDragLift(Mobile from) => false;
public override bool OnDragDrop(Mobile from, Item dropped)
{
if (dropped is not Bandage)
{
from.SendLocalizedMessage(1075209); // Only bandages may be dropped into the fountain.
return false;
}
if (base.OnDragDrop(from, dropped))
{
Enhance(from);
return true;
}
return false;
}
public override bool OnDragDropInto(Mobile from, Item item, Point3D p)
{
if (item is not Bandage)
{
from.SendLocalizedMessage(1075209); // Only bandages may be dropped into the fountain.
return false;
}
if (base.OnDragDropInto(from, item, p))
{
Enhance(from);
return true;
}
return false;
}
public override void AddNameProperties(IPropertyList list)
{
base.AddNameProperties(list);
list.Add(1075217, _charges); // ~1_val~ charges remaining
}
public override void OnDelete()
{
_timer?.Stop();
base.OnDelete();
}
private void Deserialize(IGenericReader reader, int version)
{
_charges = reader.ReadInt();
var next = reader.ReadDateTime();
var now = Core.Now;
DeserializeTimer(next - now);
}
public void Recharge()
{
Charges = MaxCharges;
Enhance(null);
}
public void Enhance(Mobile from)
{
for (var i = Items.Count - 1; i >= 0 && _charges > 0; --i)
{
if (Items[i] is EnhancedBandage)
{
continue;
}
if (Items[i] is Bandage bandage)
{
Item enhanced;
if (bandage.Amount > _charges)
{
bandage.Amount -= _charges;
enhanced = new EnhancedBandage(_charges);
Charges = 0;
}
else
{
enhanced = new EnhancedBandage(bandage.Amount);
Charges -= bandage.Amount;
bandage.Delete();
}
if (from == null || !TryDropItem(from, enhanced, false)) // try stacking first
{
DropItem(enhanced);
}
}
}
InvalidateProperties();
}
}
[SerializationGenerator(0)]
public partial class FountainOfLifeDeed : BaseAddonContainerDeed
{
[Constructible]
public FountainOfLifeDeed(int charges = FountainOfLife.MaxCharges)
{
LootType = LootType.Blessed;
_charges = charges;
}
public override int LabelNumber => 1075197; // Fountain of Life
public override BaseAddonContainer Addon => new FountainOfLife(_charges);
[SerializableProperty(0)]
[CommandProperty(AccessLevel.GameMaster)]
public int Charges
{
get => _charges;
set
{
_charges = Math.Min(value, FountainOfLife.MaxCharges);
InvalidateProperties();
this.MarkDirty();
}
}
}