146abad36e
### Summary
- Removes Fastwalk system
- Removed the following settings:
- `movement.enableFastWalkPrevention`
- `movement.fastwalkExemptionLevel`
- Adds movement throttle system.
- Adds the following settings:
- `movement.throttleReset` - Default value is `1000` (1 second).
- `movement.throttleThreshold` - Default value is `400` (400ms).
### Movement Throttling
This new system will trigger if a player requests 400ms (configurable) worth of movements quicker than wall clock time. When this happens, the player is throttled (all incoming packets to the server are halted) until wall clock time catches up with the requests. Upon each throttle, the player receives enough credit to handle up to 400ms of "lag" as a grace/catch-up.
### Developer Notes
We use two throttle queues to prevent an infinite loop.
71 lines
2.5 KiB
C#
71 lines
2.5 KiB
C#
/*************************************************************************
|
|
* ModernUO *
|
|
* Copyright 2019-2023 - ModernUO Development Team *
|
|
* Email: hi@modernuo.com *
|
|
* File: MovementThrottle.cs *
|
|
* *
|
|
* This program is free software: you can redistribute it and/or modify *
|
|
* it under the terms of the GNU General Public License as published by *
|
|
* the Free Software Foundation, either version 3 of the License, or *
|
|
* (at your option) any later version. *
|
|
* *
|
|
* You should have received a copy of the GNU General Public License *
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>. *
|
|
*************************************************************************/
|
|
|
|
using System;
|
|
|
|
namespace Server.Network;
|
|
|
|
public static class MovementThrottle
|
|
{
|
|
private static long _movementThrottleReset; // 1 second
|
|
private static long _throttleThreshold; // 400 milliseconds
|
|
|
|
public static void Configure()
|
|
{
|
|
_movementThrottleReset = ServerConfiguration.GetOrUpdateSetting("movement.throttleReset", 1000);
|
|
_throttleThreshold = ServerConfiguration.GetOrUpdateSetting("movement.throttleThreshold", 400);
|
|
}
|
|
|
|
public static unsafe void Initialize()
|
|
{
|
|
IncomingPackets.RegisterThrottler(0x02, &Throttle);
|
|
}
|
|
|
|
public static bool Throttle(int packetId, NetState ns, out bool drop)
|
|
{
|
|
drop = false;
|
|
|
|
var from = ns.Mobile;
|
|
|
|
if (from?.Deleted != false || from.AccessLevel > AccessLevel.Player)
|
|
{
|
|
return true;
|
|
}
|
|
|
|
long now = Core.TickCount;
|
|
long credit = ns._movementCredit;
|
|
long nextMove = ns._nextMovementTime;
|
|
|
|
// Reset system if idle for more than 1 second
|
|
if (now - nextMove + _movementThrottleReset > 0)
|
|
{
|
|
ns._movementCredit = 0;
|
|
ns._nextMovementTime = now;
|
|
return true;
|
|
}
|
|
|
|
long cost = nextMove - now;
|
|
|
|
if (credit < cost)
|
|
{
|
|
// Not enough credit, therefore throttled
|
|
return false;
|
|
}
|
|
|
|
// On the next event loop, the player receives up to 400ms in grace latency
|
|
ns._movementCredit = Math.Min(_throttleThreshold, credit - cost);
|
|
return true;
|
|
}
|
|
}
|