9a25054809
## Summary Many tests proved a specific change when it landed but don't need to run on every CI build forever. This removes **202 test methods and 9 files: 313 test cases, 2,247 → 1,934**. UOContent.Tests drops from about 14s to about 5s locally. Removed: - **Tautologies.** Asserting a constant, a constructor readback or a trivial getter, or testing BCL behavior. - **Exact duplicates** of a surviving test on the same code path. - **Obsolete regressions** whose failure can no longer be expressed. - **Game-content values** shard owners customize (era drop rates, loot and skill tables, single-creature tuning). Each customization would otherwise force a test fix. ## How it was decided 1. Every test was classified, with a reason, by a per-shard sweep over all 287 test files. 2. Each proposed deletion was then checked by a second, adversarial reviewer against the surviving tests and the production code. 3. Anything that was the only coverage of a separate code path was **kept**, even where it looked like a duplicate. Examples: the unsigned `SpanReader`/`SpanWriter` methods, the at-location versus bounds enumerators, null-map enumerables, the security filters, archive-journal state transitions. About 130 proposed deletions were rejected this way. Whole files removed: - `FishingTests`, apart from 3 tests: the map-edge scan, serpent cleanup, and SOS chest consumption. The SOS test now stops at the first chest instead of measuring a catch rate. The multi-million-cast rate simulations are gone. - `LordOaksTests` and `MeerEnragedTests` (single-creature tests). - `AutoArchiveHelperTests`, `JsonDiscoverableTypeAttributeTests`, `DecimalSerializationTests` and `EnumConversionTests` (tautologies, or tests of their own local helpers). - `NetworkStatsTests`. - `MigratedDataLoadTests` (a subset of `AllSpawnFilesLoadTests`). - `SpawnerFixtureCapture`: a capture tool, not a test, and its `version == 12` assert can no longer pass. The `.bin` fixtures it produced stay. ## Tests - Server.Tests: 811 pass. - UOContent.Tests: 1,123 pass. A follow-up PR, stacked on this one, fixes how the remaining tests behave: shared state, CI-vacuous tests, harness duplication.
152 lines
6.6 KiB
C#
152 lines
6.6 KiB
C#
using System;
|
|
using Xunit;
|
|
|
|
namespace Server.Tests;
|
|
|
|
[Collection("Sequential Server Tests")]
|
|
public sealed class WorldLocationTests
|
|
{
|
|
private static Map CreateMap(string name) => new(0, 0, 0, 1, 1, 0, name, MapRules.Internal);
|
|
|
|
private const string _nullMap = "(-null-)";
|
|
|
|
private const string _superLongMapName =
|
|
"Some super long map name that nobody should be using, but probably someone will just because you can!";
|
|
|
|
[Fact]
|
|
public void TestWorldLocationToString()
|
|
{
|
|
const string mapName = "Internal Map";
|
|
var map = CreateMap(mapName);
|
|
|
|
const int max = int.MaxValue;
|
|
const int min = int.MinValue;
|
|
Assert.Equal($"(0, 0, 0) [{mapName}]", new WorldLocation(0, 0, 0, map).ToString());
|
|
Assert.Equal($"(1, 1, 1) [{mapName}]", new WorldLocation(1, 1, 1, map).ToString());
|
|
|
|
Assert.Equal($"(0, 0, 0) [{_nullMap}]", new WorldLocation(0, 0, 0, null).ToString());
|
|
Assert.Equal($"(1, 1, 1) [{_nullMap}]", new WorldLocation(1, 1, 1, null).ToString());
|
|
|
|
Assert.Equal($"({max}, {max}, {max}) [{mapName}]", new WorldLocation(max, max, max, map).ToString());
|
|
Assert.Equal($"({min}, {min}, {min}) [{mapName}]", new WorldLocation(min, min, min, map).ToString());
|
|
|
|
Assert.Equal($"({max}, {max}, {max}) [{_nullMap}]", new WorldLocation(max, max, max, null).ToString());
|
|
Assert.Equal($"({min}, {min}, {min}) [{_nullMap}]", new WorldLocation(min, min, min, null).ToString());
|
|
|
|
map = CreateMap(_superLongMapName);
|
|
|
|
Assert.Equal($"({max}, {max}, {max}) [{_superLongMapName}]", new WorldLocation(max, max, max, map).ToString());
|
|
Assert.Equal($"({min}, {min}, {min}) [{_superLongMapName}]", new WorldLocation(min, min, min, map).ToString());
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(null)]
|
|
[InlineData("Internal Map")]
|
|
public void TestWorldLocationTryFormatFails(string mapName)
|
|
{
|
|
var map = mapName != null ? CreateMap(mapName) : null;
|
|
|
|
const int max = int.MaxValue;
|
|
const int min = int.MinValue;
|
|
var array = new char[1];
|
|
|
|
var p1 = new WorldLocation(0, 0, 0, map);
|
|
Assert.False(p1.TryFormat(array, out var cp1, null, null));
|
|
Assert.Equal(0, cp1);
|
|
Array.Clear(array);
|
|
|
|
var p2 = new WorldLocation(1, 1, 1, map);
|
|
Assert.False(p2.TryFormat(array, out var cp2, null, null));
|
|
Assert.Equal(0, cp2);
|
|
Array.Clear(array);
|
|
|
|
var p3 = new WorldLocation(max, max, max, map);
|
|
Assert.False(p3.TryFormat(array, out var cp3, null, null));
|
|
Assert.Equal(0, cp3);
|
|
Array.Clear(array);
|
|
|
|
var p4 = new WorldLocation(min, min, min, map);
|
|
Assert.False(p4.TryFormat(array, out var cp4, null, null));
|
|
Assert.Equal(0, cp4);
|
|
}
|
|
|
|
[Fact]
|
|
public void TestWorldLocationTryParse()
|
|
{
|
|
var validMap = Map.Felucca;
|
|
// Happy Path
|
|
Assert.True(WorldLocation.TryParse("(101, 23, 55) [Felucca]", null, out var p));
|
|
Assert.Equal(new WorldLocation(101, 23, 55, validMap), p);
|
|
Assert.Equal(new WorldLocation(101, 23, 55, validMap), WorldLocation.Parse("(101, 23, 55) [Felucca]", null));
|
|
|
|
// Trimming
|
|
Assert.True(WorldLocation.TryParse(" (101,23 ,55) [Felucca] ", null, out p));
|
|
Assert.Equal(new WorldLocation(101, 23, 55, validMap), p);
|
|
Assert.Equal(new WorldLocation(101, 23, 55, validMap), WorldLocation.Parse(" (101,23 ,55) [Felucca] ", null));
|
|
|
|
// Null Map
|
|
Assert.True(WorldLocation.TryParse(" (101,23 ,55) [(-null-)]", null, out p));
|
|
Assert.Equal(new WorldLocation(101, 23, 55, null), p);
|
|
Assert.Equal(new WorldLocation(101, 23, 55, null), WorldLocation.Parse(" (101,23 ,55) [(-null-)]", null));
|
|
|
|
// No Brackets
|
|
Assert.False(WorldLocation.TryParse("(101, 23 55) Felucca]", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => WorldLocation.Parse("(101, 23, 55) Felucca]", null));
|
|
|
|
Assert.False(WorldLocation.TryParse("(101, 23 55) [Felucca", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => WorldLocation.Parse("(101, 23, 55) [Felucca", null));
|
|
|
|
// No parenthesis
|
|
Assert.False(WorldLocation.TryParse("101, 23 55) [Felucca]", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => WorldLocation.Parse("101, 23, 55) [Felucca]", null));
|
|
|
|
Assert.False(WorldLocation.TryParse("(101, 23, 55 [Felucca]", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => WorldLocation.Parse("(101, 23, 55 [Felucca]", null));
|
|
|
|
// No Map - We don't support maps with no name, sorry.
|
|
Assert.False(WorldLocation.TryParse("(101, 23, 55) []", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => WorldLocation.Parse("(101, 23, 55) []", null));
|
|
|
|
// No numbers
|
|
Assert.False(WorldLocation.TryParse("()", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => WorldLocation.Parse("()", null));
|
|
|
|
Assert.False(WorldLocation.TryParse("(,)", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => WorldLocation.Parse("(,)", null));
|
|
|
|
Assert.False(WorldLocation.TryParse("(|)", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => WorldLocation.Parse("(|)", null));
|
|
|
|
Assert.False(WorldLocation.TryParse("() []", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => WorldLocation.Parse("() []", null));
|
|
|
|
Assert.False(WorldLocation.TryParse("(101) [Felucca]", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => WorldLocation.Parse("(101) [Felucca]", null));
|
|
|
|
Assert.False(WorldLocation.TryParse("(101,) [Felucca]", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => WorldLocation.Parse("(101,) [Felucca]", null));
|
|
|
|
Assert.False(WorldLocation.TryParse("(,23) [Felucca]", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => WorldLocation.Parse("(,23) [Felucca]", null));
|
|
|
|
Assert.False(WorldLocation.TryParse("(,23,55) [Felucca]", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => WorldLocation.Parse("(,23,55) [Felucca]", null));
|
|
|
|
Assert.False(WorldLocation.TryParse("(,23,) [Felucca]", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => WorldLocation.Parse("(,23,) [Felucca]", null));
|
|
}
|
|
}
|