9a25054809
## Summary Many tests proved a specific change when it landed but don't need to run on every CI build forever. This removes **202 test methods and 9 files: 313 test cases, 2,247 → 1,934**. UOContent.Tests drops from about 14s to about 5s locally. Removed: - **Tautologies.** Asserting a constant, a constructor readback or a trivial getter, or testing BCL behavior. - **Exact duplicates** of a surviving test on the same code path. - **Obsolete regressions** whose failure can no longer be expressed. - **Game-content values** shard owners customize (era drop rates, loot and skill tables, single-creature tuning). Each customization would otherwise force a test fix. ## How it was decided 1. Every test was classified, with a reason, by a per-shard sweep over all 287 test files. 2. Each proposed deletion was then checked by a second, adversarial reviewer against the surviving tests and the production code. 3. Anything that was the only coverage of a separate code path was **kept**, even where it looked like a duplicate. Examples: the unsigned `SpanReader`/`SpanWriter` methods, the at-location versus bounds enumerators, null-map enumerables, the security filters, archive-journal state transitions. About 130 proposed deletions were rejected this way. Whole files removed: - `FishingTests`, apart from 3 tests: the map-edge scan, serpent cleanup, and SOS chest consumption. The SOS test now stops at the first chest instead of measuring a catch rate. The multi-million-cast rate simulations are gone. - `LordOaksTests` and `MeerEnragedTests` (single-creature tests). - `AutoArchiveHelperTests`, `JsonDiscoverableTypeAttributeTests`, `DecimalSerializationTests` and `EnumConversionTests` (tautologies, or tests of their own local helpers). - `NetworkStatsTests`. - `MigratedDataLoadTests` (a subset of `AllSpawnFilesLoadTests`). - `SpawnerFixtureCapture`: a capture tool, not a test, and its `version == 12` assert can no longer pass. The `.bin` fixtures it produced stay. ## Tests - Server.Tests: 811 pass. - UOContent.Tests: 1,123 pass. A follow-up PR, stacked on this one, fixes how the remaining tests behave: shared state, CI-vacuous tests, harness duplication.
79 lines
3.4 KiB
C#
79 lines
3.4 KiB
C#
/*************************************************************************
|
|
* ModernUO *
|
|
* Copyright 2019-2026 - ModernUO Development Team *
|
|
* Email: hi@modernuo.com *
|
|
* File: FirewallTests.cs *
|
|
* *
|
|
* This program is free software: you can redistribute it and/or modify *
|
|
* it under the terms of the GNU General Public License as published by *
|
|
* the Free Software Foundation, either version 3 of the License, or *
|
|
* (at your option) any later version. *
|
|
* *
|
|
* You should have received a copy of the GNU General Public License *
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>. *
|
|
*************************************************************************/
|
|
|
|
using System;
|
|
using System.Net;
|
|
using Server.Network;
|
|
using Xunit;
|
|
|
|
namespace Server.Tests.Network.Firewall;
|
|
|
|
[Collection("Sequential UOContent Tests")]
|
|
public class FirewallTests
|
|
{
|
|
private static IPAddress Ip(string s) => IPAddress.Parse(s);
|
|
|
|
[Fact]
|
|
public void Add_ThenIsBlocked_SingleIp()
|
|
{
|
|
Server.Network.Firewall.ResetForTesting();
|
|
Assert.True(Server.Network.Firewall.Add(new SingleIpFirewallEntry(Ip("1.2.3.4"))));
|
|
Assert.True(Server.Network.Firewall.IsBlocked(Ip("1.2.3.4")));
|
|
Assert.False(Server.Network.Firewall.IsBlocked(Ip("1.2.3.5")));
|
|
}
|
|
|
|
[Fact]
|
|
public void Add_Range_BlocksInside_NotOutside()
|
|
{
|
|
Server.Network.Firewall.ResetForTesting();
|
|
Server.Network.Firewall.Add(new CidrFirewallEntry(Ip("10.0.0.0"), Ip("10.0.0.255")));
|
|
Assert.True(Server.Network.Firewall.IsBlocked(Ip("10.0.0.7")));
|
|
Assert.False(Server.Network.Firewall.IsBlocked(Ip("10.0.1.0")));
|
|
}
|
|
|
|
[Fact]
|
|
public void Remove_Unblocks()
|
|
{
|
|
Server.Network.Firewall.ResetForTesting();
|
|
var entry = new SingleIpFirewallEntry(Ip("1.2.3.4"));
|
|
Server.Network.Firewall.Add(entry);
|
|
Assert.True(Server.Network.Firewall.Remove(entry));
|
|
Assert.False(Server.Network.Firewall.IsBlocked(Ip("1.2.3.4")));
|
|
}
|
|
|
|
[Fact]
|
|
public void ExpireEntries_RemovesExpired_KeepsPermanent()
|
|
{
|
|
Server.Network.Firewall.ResetForTesting();
|
|
var permanent = new SingleIpFirewallEntry(Ip("1.1.1.1"));
|
|
var temporary = new SingleIpFirewallEntry(Ip("2.2.2.2"));
|
|
Server.Network.Firewall.Add(permanent); // no ttl
|
|
Server.Network.Firewall.Add(temporary, TimeSpan.FromMilliseconds(50)); // ttl
|
|
|
|
Server.Network.Firewall.ExpireEntries(Core.TickCount + 100); // past the ttl
|
|
|
|
Assert.True(Server.Network.Firewall.IsBlocked(Ip("1.1.1.1")));
|
|
Assert.False(Server.Network.Firewall.IsBlocked(Ip("2.2.2.2")));
|
|
}
|
|
|
|
[Fact]
|
|
public void ToFirewallEntry_ParsesForms()
|
|
{
|
|
Assert.IsType<SingleIpFirewallEntry>(Server.Network.Firewall.ToFirewallEntry("1.2.3.4"));
|
|
Assert.IsType<CidrFirewallEntry>(Server.Network.Firewall.ToFirewallEntry("10.0.0.0/24"));
|
|
Assert.IsType<CidrFirewallEntry>(Server.Network.Firewall.ToFirewallEntry("10.0.0.0-10.0.0.255"));
|
|
Assert.Null(Server.Network.Firewall.ToFirewallEntry("not-an-ip"));
|
|
}
|
|
}
|