9a25054809
## Summary Many tests proved a specific change when it landed but don't need to run on every CI build forever. This removes **202 test methods and 9 files: 313 test cases, 2,247 → 1,934**. UOContent.Tests drops from about 14s to about 5s locally. Removed: - **Tautologies.** Asserting a constant, a constructor readback or a trivial getter, or testing BCL behavior. - **Exact duplicates** of a surviving test on the same code path. - **Obsolete regressions** whose failure can no longer be expressed. - **Game-content values** shard owners customize (era drop rates, loot and skill tables, single-creature tuning). Each customization would otherwise force a test fix. ## How it was decided 1. Every test was classified, with a reason, by a per-shard sweep over all 287 test files. 2. Each proposed deletion was then checked by a second, adversarial reviewer against the surviving tests and the production code. 3. Anything that was the only coverage of a separate code path was **kept**, even where it looked like a duplicate. Examples: the unsigned `SpanReader`/`SpanWriter` methods, the at-location versus bounds enumerators, null-map enumerables, the security filters, archive-journal state transitions. About 130 proposed deletions were rejected this way. Whole files removed: - `FishingTests`, apart from 3 tests: the map-edge scan, serpent cleanup, and SOS chest consumption. The SOS test now stops at the first chest instead of measuring a catch rate. The multi-million-cast rate simulations are gone. - `LordOaksTests` and `MeerEnragedTests` (single-creature tests). - `AutoArchiveHelperTests`, `JsonDiscoverableTypeAttributeTests`, `DecimalSerializationTests` and `EnumConversionTests` (tautologies, or tests of their own local helpers). - `NetworkStatsTests`. - `MigratedDataLoadTests` (a subset of `AllSpawnFilesLoadTests`). - `SpawnerFixtureCapture`: a capture tool, not a test, and its `version == 12` assert can no longer pass. The `.bin` fixtures it produced stay. ## Tests - Server.Tests: 811 pass. - UOContent.Tests: 1,123 pass. A follow-up PR, stacked on this one, fixes how the remaining tests behave: shared state, CI-vacuous tests, harness duplication.
84 lines
2.5 KiB
C#
84 lines
2.5 KiB
C#
using Server;
|
|
using Server.Misc;
|
|
using Xunit;
|
|
|
|
namespace UOContent.Tests;
|
|
|
|
[Collection("Sequential UOContent Tests")]
|
|
public class SkillEventsTests
|
|
{
|
|
private sealed class Recorder
|
|
{
|
|
public Mobile From;
|
|
public Skill Skill;
|
|
public bool Success;
|
|
public int Calls;
|
|
|
|
public void Handle(Mobile from, Skill skill, bool success)
|
|
{
|
|
From = from;
|
|
Skill = skill;
|
|
Success = success;
|
|
Calls++;
|
|
}
|
|
}
|
|
|
|
[Fact]
|
|
public void DirectTarget_RolledAttempt_RaisesOnceWithTheReturnedOutcome()
|
|
{
|
|
var from = new Mobile();
|
|
var skill = from.Skills[SkillName.Mining];
|
|
var recorder = new Recorder();
|
|
|
|
SkillEvents.SkillUsed += recorder.Handle;
|
|
try
|
|
{
|
|
var rolled = SkillCheck.Mobile_SkillCheckDirectTarget(from, SkillName.Mining, null, 0.5);
|
|
Assert.Equal(1, recorder.Calls);
|
|
Assert.Same(from, recorder.From);
|
|
Assert.Same(skill, recorder.Skill);
|
|
Assert.Equal(rolled, recorder.Success);
|
|
|
|
Assert.False(SkillCheck.Mobile_SkillCheckDirectTarget(from, SkillName.Mining, null, 0.0));
|
|
Assert.Equal(2, recorder.Calls);
|
|
Assert.False(recorder.Success);
|
|
}
|
|
finally
|
|
{
|
|
SkillEvents.SkillUsed -= recorder.Handle;
|
|
from.Delete();
|
|
}
|
|
}
|
|
|
|
[Fact]
|
|
public void ShortCircuits_StillRaise_WithTheHandlerOutcome()
|
|
{
|
|
var from = new Mobile();
|
|
var recorder = new Recorder();
|
|
|
|
SkillEvents.SkillUsed += recorder.Handle;
|
|
try
|
|
{
|
|
Assert.True(SkillCheck.Mobile_SkillCheckDirectLocation(from, SkillName.Mining, 1.0));
|
|
Assert.Equal(1, recorder.Calls);
|
|
Assert.True(recorder.Success);
|
|
|
|
Assert.False(SkillCheck.Mobile_SkillCheckDirectTarget(from, SkillName.Mining, null, -0.1));
|
|
Assert.Equal(2, recorder.Calls);
|
|
Assert.False(recorder.Success);
|
|
|
|
Assert.False(SkillCheck.Mobile_SkillCheckLocation(from, SkillName.Mining, 50.0, 100.0));
|
|
Assert.Equal(3, recorder.Calls);
|
|
Assert.False(recorder.Success);
|
|
|
|
Assert.True(SkillCheck.Mobile_SkillCheckTarget(from, SkillName.Mining, null, 0.0, 0.0));
|
|
Assert.Equal(4, recorder.Calls);
|
|
Assert.True(recorder.Success);
|
|
}
|
|
finally
|
|
{
|
|
SkillEvents.SkillUsed -= recorder.Handle;
|
|
from.Delete();
|
|
}
|
|
}
|
|
}
|