ModernUO/Projects/Server.Tests/Tests/Buffers/RawInterpolatedStringHandlerTests.cs
Kamron Batman 1e97ed50f6
fix: Harden Advanced Search: crash-safety, autosave, correct results & worker fixes (#2543)
## Summary

Hardens the **Advanced Search** engine (`Projects/UOContent/Engines/Advanced Search/`) — the GM entity finder that fans searches across background worker threads. A code review surfaced 14 defects (A–N), including a shard-crasher reachable from a single admin typo and a path that silently disables autosave for the rest of the shard's uptime. Each behavioral fix ships with a test.

Full `UOContent.Tests` suite: **530/530 green** (21 new AdvancedSearch tests).

## Fixes

### Crash / data-loss
- **A — Shard crash on a malformed Property Test.** `AdvancedSearchThreadWorker.Execute` had no `try/catch` and the worker `Thread` is foreground, so a parse throw (`Hits>abc`, `Layer=onehanded` — `Enum.Parse` was case-sensitive, `Hits>1@` — empty sub-expression indexing) terminated the process. Now: `ParseValue`/`CompareValues` use `TryParse`/`Enum.TryParse(ignoreCase)` and return no-match instead of throwing; the per-entity filter is wrapped in `try/catch` (logs + skips); empty expressions are guarded.
- **C — Overlapping searches corrupt state + brick autosave.** `_threadWorkers`/`_threadId` were `static` but `DoSearch` is an instance method; a second search (double-click / two admins) stomped shared worker state and could leave a drain waiting forever on the shared `AutoResetEvent`, so `AutoSave.SavesEnabled` was never restored. Now: an `Interlocked` re-entrancy guard rejects concurrent searches.
- **G — Autosave restore not guaranteed.** The restore lived only in the success callback. Now it's in a `finally` (plus an outer `catch` covering the synchronous setup and a `catch` on the drain body), so autosave + the guard are always released.

### Wrong results
- **D — `@`/`|` operator precedence.** `a@b|c` evaluated as `a && (b || c)` instead of `(a && b) || c`. OR now binds looser than AND (`AdvancedSearchUtilities.EvaluateBoolean`, unit-tested).
- **E — Descending sort, partial last page rendered blank** (the index decreased in descending mode and the `break` early-out killed the loop). Now a bounded `VisibleCount`-driven loop renders the last page in both directions.
- **F — Deleted entities** were not skipped (ghost rows). Now `DoEntitySearch` skips `entity.Deleted`.
- **N — Reference-type comparisons** threw (`Comparer<T>.Default.Compare` on non-`IComparable`) and compared references to a string. Now equality is by value and ordering is guarded to `IComparable` (no throw).

### Worker perf / hardening
- **H** busy-spin → `Thread.Yield()` in the drain; **I** `GetProperties()` cached per `Type`; **J** `HandleValidInternal` moved behind the cheap map/range/region filters; **K** worker threads are `IsBackground` + `Exit()` tolerates an already-terminated worker; **L** `_filter == null` guard; **M** consistent `Volatile` access on `_pause`/`_exit`.

### Documented
- **B** — the residual worker/event-loop read race is documented on `AdvancedSearchThreadWorker`: workers read live entity state concurrently with the loop, so value-type reads may be stale-but-safe and getter exceptions are swallowed; fully eliminating it would require snapshotting entity fields on the main thread (deferred).

## Notes
- New test-only seams (`TryBeginSearch`/`EndSearch`/`IsSearchInProgress`/`VisibleCount`/`TryParseValue`/`EvaluateBoolean`) are `internal` via the existing `InternalsVisibleTo("UOContent.Tests")`.
- Dead `public ParseValue<T>` removed.
- `ConcurrentDictionary` for the reflection cache is intentional — these workers are genuinely parallel.
2026-07-21 07:51:06 -07:00

96 lines
3.4 KiB
C#

using System;
using Server.Buffers;
using Xunit;
namespace Server.Tests.Buffers;
[Collection("Sequential Server Tests")]
public class RawInterpolatedStringHandlerTests
{
[Fact]
public void TestLowercaseFormatString()
{
var name = "Hello WORLD";
var handler = new RawInterpolatedStringHandler(0, 1);
handler.AppendFormatted(name, format: "L");
Assert.Equal("hello world", handler.Text.ToString());
handler.Clear();
}
[Fact]
public void TestLowercaseFormatEnum()
{
var handler = new RawInterpolatedStringHandler(0, 1);
handler.AppendFormatted(DayOfWeek.Wednesday, format: "L");
Assert.Equal("wednesday", handler.Text.ToString());
handler.Clear();
}
[Fact]
public void TestLowercaseFormatInt()
{
// Numerics have no uppercase chars; :L should be a no-op
var handler = new RawInterpolatedStringHandler(0, 1);
handler.AppendFormatted(42, format: "L");
Assert.Equal("42", handler.Text.ToString());
handler.Clear();
}
[Fact]
public void TestLowercaseFormatSpan()
{
var span = "MIXED Case TEXT".AsSpan();
var handler = new RawInterpolatedStringHandler(0, 1);
handler.AppendFormatted(span, alignment: 0, format: "L");
Assert.Equal("mixed case text", handler.Text.ToString());
handler.Clear();
}
[Fact]
public void TestLowercaseFormatWithAlignment()
{
// Right-aligned: "Gold" in width 8 with :L -> " gold"
var handler = new RawInterpolatedStringHandler(0, 1);
handler.AppendFormatted("Gold", alignment: 8, format: "L");
Assert.Equal(" gold", handler.Text.ToString());
handler.Clear();
}
[Fact]
public void TestNoFormatPreservesCase()
{
var handler = new RawInterpolatedStringHandler(0, 1);
handler.AppendFormatted("Hello WORLD");
Assert.Equal("Hello WORLD", handler.Text.ToString());
handler.Clear();
}
[Fact]
public void TestUnicodeLowercase()
{
// ToLowerInvariant on Greek letter
var handler = new RawInterpolatedStringHandler(0, 1);
handler.AppendFormatted("ΑΒΓ", format: "L");
Assert.Equal("αβγ", handler.Text.ToString());
handler.Clear();
}
[Fact]
public void TestLowercaseFormatSurrogatePairAtChunkBoundary()
{
// The chunked lowercase path uses a 256-char stackalloc temp buffer. Place a
// supplementary-plane code point (U+10400 DESERET CAPITAL LONG I, encoded as
// surrogate pair "𐐀") so its high half lands at offset 255 and its
// low half at offset 256 — straddling the chunk boundary. Without the
// surrogate-aware boundary trim, ToLowerInvariant would see two lone surrogates
// and pass them through unchanged, leaving the capital code point intact.
// With the trim, the chunk shrinks to 255 chars and the pair stays together
// in the next chunk, lowercasing correctly to U+10428 ("𐐨").
var input = new string('a', 255) + "𐐀" + new string('b', 10);
var handler = new RawInterpolatedStringHandler(0, 1);
handler.AppendFormatted(input, format: "L");
var expected = new string('a', 255) + "𐐨" + new string('b', 10);
Assert.Equal(expected, handler.Text.ToString());
handler.Clear();
}
}