ModernUO/Projects/UOContent/Multis/Boats
Kamron Batman ecbee17690
fix: Optimizes OPL using string interpolation (#1041)
## Breaking Changes (New API)
ObjectPropertyList supports the following API:
```cs
list.Add(500000);
list.Add(500001, stringArgument);
list.Add("Some text");
list.Add($"Some text with {argument}");
list.Add(500002, $"{arg1}\t{arg2}");
```

## Notes
1. All API uses that require a formatter like this:
    ```cs
    list.Add(500002, "{0}\t{1}", arg1, arg2);
    ```
    Should be changed to use string interpolation, for example:
    ```cs
    list.Add(500002, $"{arg1}\t{arg2}");
    ```
2. The following paradigm should no longer be used:
    ```cs
    list.Add(1061170, prop.ToString()); // strength requirement ~1_val~
    ```
    The new string interpolation API will avoid having to convert the argument to a string before writing it to the packet. Instead use the following:
    ```cs
    list.Add(1061170, $"{prop}"); // strength requirement ~1_val~
    ```

### Benchmarks
```cs
|                         Method |     Mean |   Error |  StdDev |  Gen 0 | Allocated |
|------------------------------- |---------:|--------:|--------:|-------:|----------:|
|                BenchmarkOldOPL | 241.0 ns | 0.56 ns | 0.47 ns | 0.0105 |      88 B |
| BenchmarkStringInterpolatedOPL | 199.9 ns | 2.44 ns | 2.39 ns |      - |         - |
```

### Changes
- [X] Removes crash in STArray.Return when array is null.
- [X] Fixes NPE in OPL when entity is null. Serial in packet will be 0 when entity is null.
- [X] Fixes NPE in AosAttributes when Parent is null.
- [X] Changes OPL to use string interpolation.
- [X] Introduces `IPropertyList` to allow extending PropertyList for other uses.
2022-06-02 10:09:53 -07:00
..
BaseBoat.cs chore: Cleans up pattern checks. (#892) 2021-12-24 15:53:59 -08:00
BaseBoatDeed.cs fix: Cleans up Point checks and removes statics (#966) 2022-03-20 23:15:59 -07:00
BaseDockedBoat.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
BoatPackets.cs fix(core): Fixes item mask in incoming mobile packet (#568) 2021-04-10 21:48:07 -07:00
ConfirmDryDockGump.cs Fixes brace style (#248) 2020-09-13 21:49:46 -07:00
Hold.cs Fixes random NPEs (#378) 2021-01-01 02:16:23 -08:00
LargeBoat.cs C# 9 Cleanup (#325) 2020-11-27 00:29:21 -08:00
LargeDragonBoat.cs C# 9 Cleanup (#325) 2020-11-27 00:29:21 -08:00
MediumBoat.cs C# 9 Cleanup (#325) 2020-11-27 00:29:21 -08:00
MediumDragonBoat.cs C# 9 Cleanup (#325) 2020-11-27 00:29:21 -08:00
Plank.cs chore: Cleans up pattern checks. (#892) 2021-12-24 15:53:59 -08:00
RenameBoatPrompt.cs Formats UO Content (#201) 2020-08-27 18:30:38 -07:00
SmallBoat.cs C# 9 Cleanup (#325) 2020-11-27 00:29:21 -08:00
SmallDragonBoat.cs C# 9 Cleanup (#325) 2020-11-27 00:29:21 -08:00
Strandedness.cs C# 9 Cleanup (#325) 2020-11-27 00:29:21 -08:00
TillerMan.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00