ecbee17690
## Breaking Changes (New API)
ObjectPropertyList supports the following API:
```cs
list.Add(500000);
list.Add(500001, stringArgument);
list.Add("Some text");
list.Add($"Some text with {argument}");
list.Add(500002, $"{arg1}\t{arg2}");
```
## Notes
1. All API uses that require a formatter like this:
```cs
list.Add(500002, "{0}\t{1}", arg1, arg2);
```
Should be changed to use string interpolation, for example:
```cs
list.Add(500002, $"{arg1}\t{arg2}");
```
2. The following paradigm should no longer be used:
```cs
list.Add(1061170, prop.ToString()); // strength requirement ~1_val~
```
The new string interpolation API will avoid having to convert the argument to a string before writing it to the packet. Instead use the following:
```cs
list.Add(1061170, $"{prop}"); // strength requirement ~1_val~
```
### Benchmarks
```cs
| Method | Mean | Error | StdDev | Gen 0 | Allocated |
|------------------------------- |---------:|--------:|--------:|-------:|----------:|
| BenchmarkOldOPL | 241.0 ns | 0.56 ns | 0.47 ns | 0.0105 | 88 B |
| BenchmarkStringInterpolatedOPL | 199.9 ns | 2.44 ns | 2.39 ns | - | - |
```
### Changes
- [X] Removes crash in STArray.Return when array is null.
- [X] Fixes NPE in OPL when entity is null. Serial in packet will be 0 when entity is null.
- [X] Fixes NPE in AosAttributes when Parent is null.
- [X] Changes OPL to use string interpolation.
- [X] Introduces `IPropertyList` to allow extending PropertyList for other uses.
157 lines
3.9 KiB
C#
157 lines
3.9 KiB
C#
namespace Server.Items
|
|
{
|
|
[Flippable(0x2328, 0x2329)]
|
|
public class Snowman : Item, IDyable
|
|
{
|
|
// All hail OSI staff
|
|
private static readonly string[] titles =
|
|
{
|
|
/* 1 */ "Backflash",
|
|
/* 2 */ "Carbon",
|
|
/* 3 */ "Colbalistic",
|
|
/* 4 */ "Comforl",
|
|
/* 5 */ "Coppacchia",
|
|
/* 6 */ "Cyrus",
|
|
/* 7 */ "DannyB",
|
|
/* 8 */ "DJSoul",
|
|
/* 9 */ "DraconisRex",
|
|
/* 10 */ "Earia",
|
|
/* 11 */ "Foster",
|
|
/* 12 */ "Gonzo",
|
|
/* 13 */ "Haan",
|
|
/* 14 */ "Halona",
|
|
/* 15 */ "Hugo",
|
|
/* 16 */ "Hyacinth",
|
|
/* 17 */ "Imirian",
|
|
/* 18 */ "Jinsol",
|
|
/* 19 */ "Liciatia",
|
|
/* 20 */ "Loewen",
|
|
/* 21 */ "Loke",
|
|
/* 22 */ "Magnus",
|
|
/* 23 */ "Maleki",
|
|
/* 24 */ "Morpheus",
|
|
/* 25 */ "Obberron",
|
|
/* 26 */ "Odee",
|
|
/* 27 */ "Orbeus",
|
|
/* 28 */ "Pax",
|
|
/* 29 */ "Phields",
|
|
/* 30 */ "Pigpen",
|
|
/* 31 */ "Platinum",
|
|
/* 32 */ "Polpol",
|
|
/* 33 */ "Prume",
|
|
/* 34 */ "Quinnly",
|
|
/* 35 */ "Ragnarok",
|
|
/* 36 */ "Rend",
|
|
/* 37 */ "Roland",
|
|
/* 38 */ "RyanM",
|
|
/* 39 */ "Screach",
|
|
/* 40 */ "Seraph",
|
|
/* 41 */ "Silvani",
|
|
/* 42 */ "Sherbear",
|
|
/* 43 */ "SkyWalker",
|
|
/* 44 */ "Snark",
|
|
/* 45 */ "Sowl",
|
|
/* 46 */ "Spada",
|
|
/* 47 */ "Starblade",
|
|
/* 48 */ "Tenacious",
|
|
/* 49 */ "Tnez",
|
|
/* 50 */ "Wasia",
|
|
/* 51 */ "Zilo",
|
|
/* 52 */ "Zippy",
|
|
/* 53 */ "Zoer"
|
|
};
|
|
|
|
private string m_Title;
|
|
|
|
[Constructible]
|
|
public Snowman() : this(Utility.RandomDyedHue())
|
|
{
|
|
}
|
|
|
|
[Constructible]
|
|
public Snowman(int hue) : this(hue, GetRandomTitle())
|
|
{
|
|
}
|
|
|
|
[Constructible]
|
|
public Snowman(string title) : this(Utility.RandomDyedHue(), title)
|
|
{
|
|
}
|
|
|
|
[Constructible]
|
|
public Snowman(int hue, string title) : base(Utility.Random(0x2328, 2))
|
|
{
|
|
Weight = 10.0;
|
|
Hue = hue;
|
|
LootType = LootType.Blessed;
|
|
|
|
m_Title = title;
|
|
}
|
|
|
|
public Snowman(Serial serial) : base(serial)
|
|
{
|
|
}
|
|
|
|
[CommandProperty(AccessLevel.GameMaster)]
|
|
public string Title
|
|
{
|
|
get => m_Title;
|
|
set
|
|
{
|
|
m_Title = value;
|
|
InvalidateProperties();
|
|
}
|
|
}
|
|
|
|
public bool Dye(Mobile from, DyeTub sender)
|
|
{
|
|
if (Deleted)
|
|
{
|
|
return false;
|
|
}
|
|
|
|
Hue = sender.DyedHue;
|
|
|
|
return true;
|
|
}
|
|
|
|
public static string GetRandomTitle() => titles.RandomElement();
|
|
|
|
public override void GetProperties(IPropertyList list)
|
|
{
|
|
base.GetProperties(list);
|
|
|
|
if (m_Title != null)
|
|
{
|
|
list.Add(1062841, m_Title); // ~1_NAME~ the Snowman
|
|
}
|
|
}
|
|
|
|
public override void Serialize(IGenericWriter writer)
|
|
{
|
|
base.Serialize(writer);
|
|
|
|
writer.Write(1); // version
|
|
|
|
writer.Write(m_Title);
|
|
}
|
|
|
|
public override void Deserialize(IGenericReader reader)
|
|
{
|
|
base.Deserialize(reader);
|
|
|
|
var version = reader.ReadInt();
|
|
|
|
switch (version)
|
|
{
|
|
case 1:
|
|
{
|
|
m_Title = reader.ReadString();
|
|
break;
|
|
}
|
|
}
|
|
|
|
Utility.Intern(ref m_Title);
|
|
}
|
|
}
|
|
}
|