ecbee17690
## Breaking Changes (New API)
ObjectPropertyList supports the following API:
```cs
list.Add(500000);
list.Add(500001, stringArgument);
list.Add("Some text");
list.Add($"Some text with {argument}");
list.Add(500002, $"{arg1}\t{arg2}");
```
## Notes
1. All API uses that require a formatter like this:
```cs
list.Add(500002, "{0}\t{1}", arg1, arg2);
```
Should be changed to use string interpolation, for example:
```cs
list.Add(500002, $"{arg1}\t{arg2}");
```
2. The following paradigm should no longer be used:
```cs
list.Add(1061170, prop.ToString()); // strength requirement ~1_val~
```
The new string interpolation API will avoid having to convert the argument to a string before writing it to the packet. Instead use the following:
```cs
list.Add(1061170, $"{prop}"); // strength requirement ~1_val~
```
### Benchmarks
```cs
| Method | Mean | Error | StdDev | Gen 0 | Allocated |
|------------------------------- |---------:|--------:|--------:|-------:|----------:|
| BenchmarkOldOPL | 241.0 ns | 0.56 ns | 0.47 ns | 0.0105 | 88 B |
| BenchmarkStringInterpolatedOPL | 199.9 ns | 2.44 ns | 2.39 ns | - | - |
```
### Changes
- [X] Removes crash in STArray.Return when array is null.
- [X] Fixes NPE in OPL when entity is null. Serial in packet will be 0 when entity is null.
- [X] Fixes NPE in AosAttributes when Parent is null.
- [X] Changes OPL to use string interpolation.
- [X] Introduces `IPropertyList` to allow extending PropertyList for other uses.
95 lines
2.4 KiB
C#
95 lines
2.4 KiB
C#
namespace Server.Items
|
|
{
|
|
[Flippable(0x236E, 0x2371)]
|
|
public class LightOfTheWinterSolstice : Item
|
|
{
|
|
private static readonly string[] m_StaffNames =
|
|
{
|
|
"Aenima",
|
|
"Alkiser",
|
|
"ASayre",
|
|
"David",
|
|
"Krrios",
|
|
"Mark",
|
|
"Merlin",
|
|
"Merlix", // LordMerlix
|
|
"Phantom",
|
|
"Phenos",
|
|
"psz",
|
|
"Ryan",
|
|
"Quantos",
|
|
"Outkast", // TheOutkastDev
|
|
"V", // Admin_V
|
|
"Zippy"
|
|
};
|
|
|
|
[Constructible]
|
|
public LightOfTheWinterSolstice(string dipper = null) : base(0x236E)
|
|
{
|
|
Dipper = dipper ?? m_StaffNames.RandomElement();
|
|
|
|
Weight = 1.0;
|
|
LootType = LootType.Blessed;
|
|
Light = LightType.Circle300;
|
|
Hue = Utility.RandomDyedHue();
|
|
}
|
|
|
|
public LightOfTheWinterSolstice(Serial serial) : base(serial)
|
|
{
|
|
}
|
|
|
|
[CommandProperty(AccessLevel.GameMaster)]
|
|
public string Dipper { get; set; }
|
|
|
|
public override void OnSingleClick(Mobile from)
|
|
{
|
|
base.OnSingleClick(from);
|
|
|
|
LabelTo(from, 1070881, Dipper); // Hand Dipped by ~1_name~
|
|
LabelTo(from, 1070880); // Winter 2004
|
|
}
|
|
|
|
public override void GetProperties(IPropertyList list)
|
|
{
|
|
base.GetProperties(list);
|
|
|
|
list.Add(1070881, Dipper); // Hand Dipped by ~1_name~
|
|
list.Add(1070880); // Winter 2004
|
|
}
|
|
|
|
public override void Serialize(IGenericWriter writer)
|
|
{
|
|
base.Serialize(writer);
|
|
|
|
writer.Write(1); // version
|
|
|
|
writer.Write(Dipper);
|
|
}
|
|
|
|
public override void Deserialize(IGenericReader reader)
|
|
{
|
|
base.Deserialize(reader);
|
|
|
|
var version = reader.ReadInt();
|
|
|
|
switch (version)
|
|
{
|
|
case 1:
|
|
{
|
|
Dipper = reader.ReadString();
|
|
break;
|
|
}
|
|
case 0:
|
|
{
|
|
Dipper = m_StaffNames.RandomElement();
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (Dipper != null)
|
|
{
|
|
Dipper = string.Intern(Dipper);
|
|
}
|
|
}
|
|
}
|
|
}
|