The shard owner, on a Starlink CGNAT address, was blocked by the imported reputation blocklist. The cause was not CrowdSec: the address was a literal line in ip-blocklist.txt, so BlocklistFilter denied it at accept and then promoted it. Clearing the CrowdSec decision could not fix it either, because the file entry re-reports within promoteSuppression of every reconnect. Reputation feeds list shared consumer address space constantly. On CGNAT one public address fronts many subscribers at the same time, so a single abusive customer gets the address listed and everyone else behind it is blocked with them; where leases rotate, a listing says little about whoever holds the address now. So exemptions go where they cost nothing, and escalation is driven by what a connection actually does. GENERATOR (tools/Export-IpBlocklist.ps1) - -AllowlistFile takes multiple paths, subtracted from the merged set before the output is written. Defaults to the operator's own ip-allowlist.txt (created once, never rewritten) plus one generated file per network carve-out. - Subtraction is range-correct: an allowlisted address inside a blocked CIDR splits that CIDR around the hole instead of being ignored. This also fixes -ExcludeAnonymizers, which parsed CIDR entries and then only subtracted singles. - Carve-outs are a table (name, ASN, reason, offline seed) rather than a hardcoded network, so covering another CGNAT provider is one row. -RefreshCarveouts re-fetches from the ASN's current routing announcements and collapses them; -Carveout '' subtracts none. Announcements rather than ownership records, because registry data disagrees with what is routed and caps its result sets. - Editing an allowlist bypasses -MinInterval, so a just-added exemption is not indistinguishable from the allowlist not working. - The shipped starlink carve-out costs ~0.1% of the list. ALLOWLISTS - FileAllowlist reads the same files the generator subtracts, so an operator entry means "leave this address alone" for real. Subtraction alone only covers being BLOCKED; behavioural detections never consult the blocklist, so without this a carve-out was quietly routed around and one scanner behind a shared address was enough to get everyone behind it firewalled. Reading the files also means an entry applies on the next reload rather than the next regeneration. - LoginAllowlist is earned by authenticating, with a 90 day TTL because an address that logged in years ago is a stranger. Its own store rather than Account.LoginIPs, which has no timestamps and cannot be backfilled. An entry is evidence rather than a licence: 10 suppressed contributions in an hour revokes it, and a fresh login forgives the tally. - Both are consulted only AFTER the blocklist has already matched, so a normal accept pays nothing for them and the accept gate stays allowlist-free. - BanExemptions combines them behind BanChannel.IsExempt. Suppresses escalation only; every local defence still applies. BEHAVIOURAL DETECTION - silent-connect (reaped having sent zero bytes) and invalid-seed (a zero seed) are contributed. Both were already disconnected. - ForeignProtocol positively identifies HTTP, TLS and SSH. Asking "is this a good UO client?" cannot work: LoginEncryption.ClientDecrypt is a byte-for-byte stream XOR, so a client with encryption on when the shard expects none sends a structurally perfect connection whose payload is noise. Nothing assumes arrival framing, since TCP has no message boundaries and a rule of the form "these bytes must arrive together" drops real players on poor links. - Keyed on bytes-received rather than elapsed time throughout. A connection that sent something and ran out of time is far more likely a slow link, and banning those makes the player retry, trip the rate limiter, and compound it. - AutoDenylist holds behavioural detections locally for 15 minutes, as an IConnectionFilter plus IBanReporter over one store so engine detection sites never reach into content. Closes the gap where a flood pays for a socket and a NetState per connection while waiting for an OS bouncer, and is the whole defence on a shard running none. Not persisted: a holding pen that survives restarts is a ban without a ban's review. - BanReasons centralises the slugs. IsBehavioral is an opt-in set, not "everything except manual", so a future reason escalates normally instead of silently inheriting an exemption. The first cut of the exemption swallowed manual admin bans; this is why. FIXES - BanConfiguration.Settings was null until Configure() ran while the reap path dereferences it every Slice(), so a harness driving NetState.Slice() directly hit an NRE that looked flaky because it depended on test ordering. - -AllowlistFile was typed [string] while documented and used as a list. LAYOUT AND DOCS Content network code moves out of Misc into UOContent/Network, one concern per folder. Namespaces are untouched, so these are pure file moves. dev-docs/ip-bans-and-allowlists.md documents the subsystem, leading with the operator process for unblocking a player -- including the three things that look sufficient and are not: deleting the CrowdSec decision alone, editing ip-blocklist.txt by hand, and cscli allowlists alone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
257 lines
8.7 KiB
C#
257 lines
8.7 KiB
C#
/*************************************************************************
|
|
* ModernUO *
|
|
* Copyright 2019-2026 - ModernUO Development Team *
|
|
* Email: hi@modernuo.com *
|
|
* File: FileAllowlist.cs *
|
|
* *
|
|
* This program is free software: you can redistribute it and/or modify *
|
|
* it under the terms of the GNU General Public License as published by *
|
|
* the Free Software Foundation, either version 3 of the License, or *
|
|
* (at your option) any later version. *
|
|
* *
|
|
* You should have received a copy of the GNU General Public License *
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>. *
|
|
*************************************************************************/
|
|
|
|
using System;
|
|
using System.IO;
|
|
using System.Net;
|
|
using System.Threading;
|
|
using System.Threading.Tasks;
|
|
using Server.Logging;
|
|
|
|
namespace Server.Network.Bans;
|
|
|
|
/// <summary>
|
|
/// The operator's own "leave this address alone" list, read from the same files
|
|
/// <c>tools/Export-IpBlocklist.ps1</c> subtracts at generation time.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// The generator already subtracts these from the blocklist, but that only covers being BLOCKED.
|
|
/// Behavioural detections never consult the blocklist, so without reading the files here a carve-out is
|
|
/// quietly routed around: one scanner behind a shared CGNAT address is enough to get the whole address
|
|
/// contributed and firewalled. Reading them also means an entry applies on the next reload rather than the
|
|
/// next regeneration. Unconditional, unlike <see cref="LoginAllowlist"/>, but still no shield against a
|
|
/// manual ban — see <see cref="BanExemptions"/>.
|
|
/// </remarks>
|
|
public static class FileAllowlist
|
|
{
|
|
private static readonly ILogger logger = LogFactory.GetLogger(typeof(FileAllowlist));
|
|
|
|
// Written by the reload poll (off-loop), read by the accept path (game loop): a single volatile
|
|
// reference swap is the whole synchronization story — readers see the old or the new snapshot, whole.
|
|
private static volatile BlocklistSnapshot _snapshot = BlocklistSnapshot.Empty;
|
|
|
|
private static string[] _paths = [];
|
|
private static TimeSpan _interval = TimeSpan.FromSeconds(60);
|
|
private static long _lastStamp;
|
|
private static CancellationTokenSource _cts;
|
|
|
|
public static int Count => _snapshot.Count;
|
|
|
|
/// <summary>True when an operator listed this address. Safe before <see cref="Initialize"/>.</summary>
|
|
public static bool Contains(IPAddress address) => address != null && _snapshot.Contains(address);
|
|
|
|
public static void Initialize()
|
|
{
|
|
// BlocklistFilter.Register ran during the Configure sweep, so the settings are populated.
|
|
var settings = BlocklistConfiguration.Settings;
|
|
if (settings == null)
|
|
{
|
|
return;
|
|
}
|
|
|
|
_paths = ResolvePaths(settings.AllowlistFiles);
|
|
_interval = settings.ReloadInterval <= TimeSpan.Zero ? TimeSpan.FromSeconds(60) : settings.ReloadInterval;
|
|
|
|
if (_paths.Length == 0)
|
|
{
|
|
logger.Information("File allowlist disabled (\"allowlistFiles\" empty in blocklist.json)");
|
|
return;
|
|
}
|
|
|
|
Reload();
|
|
|
|
_cts = CancellationTokenSource.CreateLinkedTokenSource(Core.ClosingTokenSource.Token);
|
|
_ = Task.Run(() => PollLoop(_cts.Token), _cts.Token);
|
|
}
|
|
|
|
public static void Stop()
|
|
{
|
|
_cts?.Cancel();
|
|
_cts?.Dispose();
|
|
_cts = null;
|
|
}
|
|
|
|
private static string[] ResolvePaths(string[] configured)
|
|
{
|
|
if (configured == null)
|
|
{
|
|
return [];
|
|
}
|
|
|
|
var resolved = new string[configured.Length];
|
|
var count = 0;
|
|
|
|
for (var i = 0; i < configured.Length; i++)
|
|
{
|
|
var path = configured[i];
|
|
if (string.IsNullOrWhiteSpace(path))
|
|
{
|
|
continue;
|
|
}
|
|
|
|
// Relative resolves against BaseDirectory, never the working directory, which differs when the
|
|
// shard is launched from elsewhere. Absolute is as-is, so shards can share a list.
|
|
resolved[count++] = Path.IsPathRooted(path) ? path : Path.Join(Core.BaseDirectory, path);
|
|
}
|
|
|
|
Array.Resize(ref resolved, count);
|
|
return resolved;
|
|
}
|
|
|
|
private static async ValueTask PollLoop(CancellationToken token)
|
|
{
|
|
while (!token.IsCancellationRequested)
|
|
{
|
|
try
|
|
{
|
|
await Task.Delay(_interval, token);
|
|
}
|
|
catch (OperationCanceledException)
|
|
{
|
|
return;
|
|
}
|
|
|
|
try
|
|
{
|
|
if (Stamp() != _lastStamp)
|
|
{
|
|
// A save owns the disk and nothing here is urgent.
|
|
// See the threading policy in CLAUDE.md (rules #3 and #10).
|
|
while (World.Saving || World.WorldState == WorldState.PendingSave)
|
|
{
|
|
await Task.Delay(TimeSpan.FromSeconds(1), token);
|
|
}
|
|
|
|
Reload();
|
|
}
|
|
}
|
|
catch (OperationCanceledException)
|
|
{
|
|
return;
|
|
}
|
|
catch (Exception e)
|
|
{
|
|
logger.Warning(e, "File allowlist reload check failed; keeping last snapshot ({Count})", Count);
|
|
}
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Change fingerprint across every configured file. A missing file contributes nothing, so creating or
|
|
/// deleting one also registers as a change.
|
|
/// </summary>
|
|
private static long Stamp()
|
|
{
|
|
var stamp = 0L;
|
|
|
|
for (var i = 0; i < _paths.Length; i++)
|
|
{
|
|
try
|
|
{
|
|
var info = new FileInfo(_paths[i]);
|
|
if (info.Exists)
|
|
{
|
|
stamp = stamp * 31 + info.LastWriteTimeUtc.Ticks + info.Length;
|
|
}
|
|
}
|
|
catch
|
|
{
|
|
// Mid-swap by the generator; the next poll picks it up.
|
|
}
|
|
}
|
|
|
|
return stamp;
|
|
}
|
|
|
|
private static void Reload()
|
|
{
|
|
// Fingerprint BEFORE parsing, so it describes the version being read. Capturing after could skip a
|
|
// version; a stale fingerprint only costs an extra reload.
|
|
var stamp = Stamp();
|
|
var combined = ReadAll(out var files);
|
|
|
|
// Reuses the blocklist parser and interval index: an address set is direction-agnostic.
|
|
var next = combined.Length == 0
|
|
? BlocklistSnapshot.Empty
|
|
: BlocklistSnapshot.Build(combined, out _, out _);
|
|
|
|
_snapshot = next; // single volatile swap; readers see old or new whole
|
|
_lastStamp = stamp;
|
|
|
|
logger.Information(
|
|
"File allowlist loaded {Count} range(s) from {Files} file(s)",
|
|
next.Count,
|
|
files
|
|
);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Concatenates every configured file into one buffer. The parser is line-based, so a newline join is
|
|
/// enough, and membership stays a single lookup.
|
|
/// </summary>
|
|
private static byte[] ReadAll(out int files)
|
|
{
|
|
files = 0;
|
|
|
|
var chunks = new byte[_paths.Length][];
|
|
var total = 0;
|
|
|
|
for (var i = 0; i < _paths.Length; i++)
|
|
{
|
|
try
|
|
{
|
|
if (!File.Exists(_paths[i]))
|
|
{
|
|
continue;
|
|
}
|
|
|
|
var bytes = File.ReadAllBytes(_paths[i]);
|
|
chunks[i] = bytes;
|
|
total += bytes.Length + 1; // + newline separator
|
|
files++;
|
|
}
|
|
catch (Exception e)
|
|
{
|
|
// Fail open per file: losing one entry beats refusing to load the rest.
|
|
logger.Warning(e, "Could not read allowlist \"{Path}\"", _paths[i]);
|
|
}
|
|
}
|
|
|
|
if (total == 0)
|
|
{
|
|
return [];
|
|
}
|
|
|
|
var combined = new byte[total];
|
|
var offset = 0;
|
|
|
|
for (var i = 0; i < chunks.Length; i++)
|
|
{
|
|
var chunk = chunks[i];
|
|
if (chunk == null)
|
|
{
|
|
continue;
|
|
}
|
|
|
|
Buffer.BlockCopy(chunk, 0, combined, offset, chunk.Length);
|
|
offset += chunk.Length;
|
|
combined[offset++] = (byte)'\n';
|
|
}
|
|
|
|
return combined;
|
|
}
|
|
|
|
internal static void LoadForTesting(BlocklistSnapshot snapshot) => _snapshot = snapshot ?? BlocklistSnapshot.Empty;
|
|
}
|