Every ISerializable carried SerializedThread/SerializedPosition/SerializedLength so WriteSnapshot could gather each entity's bytes from the worker heaps in dictionary order. The idx records absolute positions, so bin order is free - the snapshot can be written in worker-heap order instead, and the join inverts: - Chunks are persistence-homogeneous: SerializeAll declares the owner at each boundary, publishing the partial chunk on change. - Workers log segments (owner, slot range, heap start) plus one length per record as they serialize. Positions are implicit because a worker's writes are contiguous; identity comes from re-walking the same snapshot slots in the same order (guaranteed stable - mutations divert to the pending queues until PostWorldSave), or from an entities log on the fallback path. - WriteSnapshot routes segments by owner, emits idx entries during the re-walk, and writes each segment's heap bytes as a single span instead of one copy per entity, which also speeds up the background write phase. - Persistence self-payloads keep placement as three private fields on the ~dozens of persistence instances; PushSingle is now typed accordingly. Net effect: 9 bytes (plus padding) of resident state removed from every item, mobile, guild, and account on every shard; three interface-property stores per entity leave the drain hot path (stamping dirtied one cache line per entity mid-freeze - the lengths log is a single sequential stream); and the vestigial loader-side length stamp is gone. The transient cost is ~4 bytes per entity in pooled per-worker logs that are released after each write. The save format is unchanged (idx v3, same loader); only the write-side mechanics moved. Adds an end-to-end round-trip test that drives real workers through the chunk source, snapshots from the segment logs, and reloads. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
331 lines
9.2 KiB
C#
331 lines
9.2 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
using System.Net;
|
|
using Server.Accounting;
|
|
using Server.Network;
|
|
using Xunit;
|
|
|
|
namespace Server.Tests.Network;
|
|
|
|
[Collection("Sequential Server Tests")]
|
|
public class AccountPacketTests
|
|
{
|
|
private class MockedAccount : IAccount
|
|
{
|
|
public int TotalGold { get; }
|
|
public int TotalPlat { get; }
|
|
public bool DepositGold(int amount) => throw new NotImplementedException();
|
|
|
|
public bool DepositPlat(int amount) => throw new NotImplementedException();
|
|
|
|
public bool WithdrawGold(int amount) => throw new NotImplementedException();
|
|
|
|
public bool WithdrawPlat(int amount) => throw new NotImplementedException();
|
|
|
|
public long GetTotalGold() => throw new NotImplementedException();
|
|
|
|
public int CompareTo(IAccount other) => throw new NotImplementedException();
|
|
|
|
public string Username { get; }
|
|
public string Email { get; set; }
|
|
public AccessLevel AccessLevel { get; set; }
|
|
public int Length { get; }
|
|
public int Limit { get; }
|
|
public int Count { get; }
|
|
|
|
private Dictionary<int, Mobile> _mobiles = new();
|
|
|
|
public Mobile this[int index]
|
|
{
|
|
get => _mobiles[index];
|
|
set
|
|
{
|
|
_mobiles[index] = value;
|
|
if (value != null)
|
|
{
|
|
value.Account = this;
|
|
}
|
|
}
|
|
}
|
|
|
|
public DateTime Created { get; set; }
|
|
public Serial Serial { get; }
|
|
public void Deserialize(IGenericReader reader) => throw new NotImplementedException();
|
|
|
|
public void Serialize(IGenericWriter writer) => throw new NotImplementedException();
|
|
|
|
public bool Deleted { get; }
|
|
|
|
public void Delete() => throw new NotImplementedException();
|
|
public bool TrySetUsername(string username) => throw new NotImplementedException();
|
|
|
|
public void SetPassword(string password) => throw new NotImplementedException();
|
|
|
|
public bool CheckPassword(string password) => throw new NotImplementedException();
|
|
}
|
|
|
|
[Fact]
|
|
public void TestChangeCharacter()
|
|
{
|
|
var firstMobile = new Mobile((Serial)0x1);
|
|
firstMobile.DefaultMobileInit();
|
|
firstMobile.RawName = "Test Mobile";
|
|
|
|
var secondMobile = new Mobile((Serial)0x2);
|
|
secondMobile.DefaultMobileInit();
|
|
secondMobile.RawName = null;
|
|
|
|
var account = new MockedAccount
|
|
{
|
|
[0] = firstMobile,
|
|
[1] = null,
|
|
[2] = secondMobile
|
|
};
|
|
|
|
// var account = new MockAccount(new[] { firstMobile, null, secondMobile });
|
|
var expected = new ChangeCharacter(account).Compile();
|
|
|
|
using var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.SendChangeCharacter(account);
|
|
|
|
var result = ns.SendBuffer.GetReadSpan();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Fact]
|
|
public void TestClientVersionReq()
|
|
{
|
|
var expected = new ClientVersionReq().Compile();
|
|
|
|
using var ns = PacketTestUtilities.CreateTestNetState();
|
|
|
|
ns.SendClientVersionRequest();
|
|
|
|
var result = ns.SendBuffer.GetReadSpan();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Fact]
|
|
public void TestDeleteResult()
|
|
{
|
|
var expected = new DeleteResult(DeleteResultType.BadRequest).Compile();
|
|
|
|
using var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.SendCharacterDeleteResult(DeleteResultType.BadRequest);
|
|
|
|
var result = ns.SendBuffer.GetReadSpan();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Fact]
|
|
public void TestPopupMessage()
|
|
{
|
|
var expected = new PopupMessage(PMMessage.LoginSyncError).Compile();
|
|
|
|
using var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.SendPopupMessage(PMMessage.LoginSyncError);
|
|
|
|
var result = ns.SendBuffer.GetReadSpan();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Theory, InlineData(ProtocolChanges.Version70610), InlineData(ProtocolChanges.Version6000)]
|
|
public void TestSupportedFeatures(ProtocolChanges protocolChanges)
|
|
{
|
|
var firstMobile = new Mobile((Serial)0x1);
|
|
firstMobile.DefaultMobileInit();
|
|
firstMobile.Name = "Test Mobile";
|
|
|
|
var account = new MockedAccount
|
|
{
|
|
[0] = firstMobile,
|
|
[1] = null,
|
|
[2] = null,
|
|
[3] = null,
|
|
[4] = null
|
|
};
|
|
|
|
using var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.Account = account;
|
|
ns.ProtocolChanges = protocolChanges;
|
|
|
|
var expected = new SupportedFeatures(ns).Compile();
|
|
ns.SendSupportedFeature();
|
|
|
|
var result = ns.SendBuffer.GetReadSpan();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Fact]
|
|
public void TestLoginConfirm()
|
|
{
|
|
var m = new Mobile((Serial)0x1);
|
|
m.DefaultMobileInit();
|
|
m.Body = 0x100;
|
|
m.X = 100;
|
|
m.Y = 10;
|
|
m.Z = -10;
|
|
m.Direction = Direction.Down;
|
|
m.LogoutMap = Map.Felucca;
|
|
|
|
var expected = new LoginConfirm(m).Compile();
|
|
|
|
using var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.SendLoginConfirmation(m);
|
|
|
|
var result = ns.SendBuffer.GetReadSpan();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Fact]
|
|
public void TestLoginComplete()
|
|
{
|
|
var expected = new LoginComplete().Compile();
|
|
|
|
using var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.SendLoginComplete();
|
|
|
|
var result = ns.SendBuffer.GetReadSpan();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Fact]
|
|
public void TestCharacterListUpdate()
|
|
{
|
|
var firstMobile = new Mobile((Serial)0x1);
|
|
firstMobile.DefaultMobileInit();
|
|
firstMobile.RawName = "Test Mobile";
|
|
|
|
var account = new MockedAccount
|
|
{
|
|
[0] = null,
|
|
[1] = firstMobile,
|
|
[2] = null,
|
|
[3] = null,
|
|
[4] = null
|
|
};
|
|
|
|
var expected = new CharacterListUpdate(account).Compile();
|
|
|
|
using var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.SendCharacterListUpdate(account);
|
|
|
|
var result = ns.SendBuffer.GetReadSpan();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Fact]
|
|
public void TestCharacterList70130()
|
|
{
|
|
var firstMobile = new Mobile((Serial)0x1);
|
|
firstMobile.DefaultMobileInit();
|
|
firstMobile.Name = "Test Mobile";
|
|
|
|
var account = new MockedAccount
|
|
{
|
|
[0] = null,
|
|
[1] = firstMobile,
|
|
[2] = null,
|
|
[3] = null,
|
|
[4] = null
|
|
};
|
|
|
|
var info = new[]
|
|
{
|
|
new CityInfo("Test City", "Test Building", 50, 100, 10, -10)
|
|
};
|
|
|
|
var expected = new CharacterList(account, info).Compile();
|
|
|
|
using var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.CityInfo = info;
|
|
ns.Account = account;
|
|
ns.ProtocolChanges = ProtocolChanges.Version70130;
|
|
|
|
ns.SendCharacterList();
|
|
|
|
var result = ns.SendBuffer.GetReadSpan();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Fact]
|
|
public void TestCharacterListOld()
|
|
{
|
|
var firstMobile = new Mobile((Serial)0x1);
|
|
firstMobile.DefaultMobileInit();
|
|
firstMobile.Name = "Test Mobile";
|
|
|
|
var account = new MockedAccount
|
|
{
|
|
[0] = null,
|
|
[1] = firstMobile,
|
|
[2] = null,
|
|
[3] = null,
|
|
[4] = null
|
|
};
|
|
|
|
var info = new[]
|
|
{
|
|
new CityInfo("Test City", "Test Building", 50, 100, 10, -10)
|
|
};
|
|
|
|
var expected = new CharacterListOld(account, info).Compile();
|
|
|
|
using var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.CityInfo = info;
|
|
ns.Account = account;
|
|
|
|
ns.SendCharacterList();
|
|
|
|
var result = ns.SendBuffer.GetReadSpan();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Fact]
|
|
public void TestAccountLoginRej()
|
|
{
|
|
var reason = ALRReason.BadComm;
|
|
var expected = new AccountLoginRej(reason).Compile();
|
|
|
|
using var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.SendAccountLoginRejected(reason);
|
|
|
|
var result = ns.SendBuffer.GetReadSpan();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Fact]
|
|
public void TestAccountLoginAck()
|
|
{
|
|
var info = new[]
|
|
{
|
|
new ServerInfo("Test Server", 0, TimeZoneInfo.Local, IPEndPoint.Parse("127.0.0.1"))
|
|
};
|
|
|
|
var expected = new AccountLoginAck(info).Compile();
|
|
|
|
using var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.ServerInfo = info;
|
|
|
|
ns.SendAccountLoginAck();
|
|
|
|
var result = ns.SendBuffer.GetReadSpan();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Fact]
|
|
public void TestPlayServerAck()
|
|
{
|
|
var si = new ServerInfo("Test Server", 0, TimeZoneInfo.Local, IPEndPoint.Parse("127.0.0.1"));
|
|
const int authId = 0x123456;
|
|
|
|
var expected = new PlayServerAck(si, authId).Compile();
|
|
|
|
using var ns = PacketTestUtilities.CreateTestNetState();
|
|
|
|
ns.SendPlayServerAck(si, authId);
|
|
|
|
var result = ns.SendBuffer.GetReadSpan();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
}
|