Applies the house conventions consistently across this PR's own code rather than leaving them half-applied: BanChannel had Register/Stop converted while Start kept a foreach, and ConnectionFilters was foreach throughout. Converted every foreach over an array or List, and while doing so hoisted the _reporters/_filters static field reads into a local so the loops match the snapshot pattern Report/Retract/ShouldDeny already use. Left as foreach where there is no indexer: the Dictionary walks in Firewall.ExpireEntries, PromotedGuard.Sweep and BuildAlerts, and BuildAlerts' IEnumerable parameter. Dictionary field initializers become [] (it compiles, same lowering). The three remaining new List<T>(capacity) calls keep their form -- a collection expression cannot carry the capacity hint, and all three size the list exactly. Scoped to files this PR authored or moved; pre-existing loops in AdminGump, Main and Utility are left alone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
143 lines
4.9 KiB
C#
143 lines
4.9 KiB
C#
/*************************************************************************
|
|
* ModernUO *
|
|
* Copyright 2019-2026 - ModernUO Development Team *
|
|
* Email: hi@modernuo.com *
|
|
* File: BanChannel.cs *
|
|
* *
|
|
* This program is free software: you can redistribute it and/or modify *
|
|
* it under the terms of the GNU General Public License as published by *
|
|
* the Free Software Foundation, either version 3 of the License, or *
|
|
* (at your option) any later version. *
|
|
* *
|
|
* You should have received a copy of the GNU General Public License *
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>. *
|
|
*************************************************************************/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Net;
|
|
using System.Threading;
|
|
using Server.Logging;
|
|
|
|
namespace Server.Network.Bans;
|
|
|
|
/// <summary>
|
|
/// Coordinates the configured <see cref="IBanReporter"/> contribution sinks. Enforcement is NOT here —
|
|
/// the accept path asks <see cref="ConnectionFilters"/>. This channel only fans locally-decided bans out
|
|
/// to external systems (CrowdSec), which distribute them to OS-level bouncers.
|
|
/// </summary>
|
|
public static class BanChannel
|
|
{
|
|
private static readonly ILogger logger = LogFactory.GetLogger(typeof(BanChannel));
|
|
|
|
private static IBanReporter[] _reporters = [];
|
|
|
|
public static IReadOnlyList<IBanReporter> Reporters => _reporters;
|
|
|
|
/// <summary>
|
|
/// Registers a contribution sink from content (inversion of control). Idempotent by
|
|
/// <see cref="IBanReporter.Name"/>: a second registration of the same name is ignored. Configures the
|
|
/// reporter immediately so it is ready before <see cref="Start"/>.
|
|
/// </summary>
|
|
public static void Register(IBanReporter reporter)
|
|
{
|
|
if (reporter == null)
|
|
{
|
|
return;
|
|
}
|
|
|
|
var reporters = _reporters;
|
|
for (var i = 0; i < reporters.Length; i++)
|
|
{
|
|
if (reporters[i].Name == reporter.Name)
|
|
{
|
|
return;
|
|
}
|
|
}
|
|
|
|
reporter.Register();
|
|
|
|
var updated = new IBanReporter[_reporters.Length + 1];
|
|
Array.Copy(_reporters, updated, _reporters.Length);
|
|
updated[^1] = reporter;
|
|
_reporters = updated;
|
|
|
|
logger.Information("Ban channel registered reporter '{Name}'", reporter.Name);
|
|
}
|
|
|
|
internal static void ConfigureForTesting(IBanReporter[] reporters) => _reporters = reporters ?? [];
|
|
|
|
public static void Start(CancellationToken token)
|
|
{
|
|
var reporters = _reporters;
|
|
for (var i = 0; i < reporters.Length; i++)
|
|
{
|
|
var reporter = reporters[i];
|
|
try
|
|
{
|
|
reporter.Start(token);
|
|
}
|
|
catch (Exception e)
|
|
{
|
|
// A broken contribution path must not crash boot — enforcement is local and unaffected.
|
|
logger.Error(e, "Ban reporter '{Name}' failed to start; continuing without it", reporter.Name);
|
|
}
|
|
}
|
|
}
|
|
|
|
public static void Stop()
|
|
{
|
|
var reporters = _reporters;
|
|
for (var i = 0; i < reporters.Length; i++)
|
|
{
|
|
var reporter = reporters[i];
|
|
try
|
|
{
|
|
reporter.Stop();
|
|
}
|
|
catch (Exception e)
|
|
{
|
|
logger.Warning(e, "Ban reporter '{Name}' threw while stopping", reporter.Name);
|
|
}
|
|
}
|
|
}
|
|
|
|
/// <summary>Fans a locally-decided ban out to every reporter. Non-blocking; never throws.</summary>
|
|
public static void Report(IPAddress ip, TimeSpan ttl, string reason)
|
|
{
|
|
var reporters = _reporters;
|
|
for (var i = 0; i < reporters.Length; i++)
|
|
{
|
|
try
|
|
{
|
|
reporters[i].Report(ip, ttl, reason);
|
|
}
|
|
catch (Exception e)
|
|
{
|
|
logger.Warning(e, "Ban reporter '{Name}' threw during Report", reporters[i].Name);
|
|
}
|
|
}
|
|
}
|
|
|
|
/// <summary>Fans a retraction (manual unban) out to every retract-capable reporter.</summary>
|
|
public static void Retract(IPAddress ip)
|
|
{
|
|
var reporters = _reporters;
|
|
for (var i = 0; i < reporters.Length; i++)
|
|
{
|
|
if (!reporters[i].CanRetract)
|
|
{
|
|
continue;
|
|
}
|
|
|
|
try
|
|
{
|
|
reporters[i].Retract(ip);
|
|
}
|
|
catch (Exception e)
|
|
{
|
|
logger.Warning(e, "Ban reporter '{Name}' threw during Retract", reporters[i].Name);
|
|
}
|
|
}
|
|
}
|
|
}
|