9df169946c
Applies the house conventions consistently across this PR's own code rather than leaving them half-applied: BanChannel had Register/Stop converted while Start kept a foreach, and ConnectionFilters was foreach throughout. Converted every foreach over an array or List, and while doing so hoisted the _reporters/_filters static field reads into a local so the loops match the snapshot pattern Report/Retract/ShouldDeny already use. Left as foreach where there is no indexer: the Dictionary walks in Firewall.ExpireEntries, PromotedGuard.Sweep and BuildAlerts, and BuildAlerts' IEnumerable parameter. Dictionary field initializers become [] (it compiles, same lowering). The three remaining new List<T>(capacity) calls keep their form -- a collection expression cannot carry the capacity hint, and all three size the list exactly. Scoped to files this PR authored or moved; pre-existing loops in AdminGump, Main and Utility are left alone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
55 lines
2 KiB
C#
55 lines
2 KiB
C#
/*************************************************************************
|
|
* ModernUO *
|
|
* Copyright 2019-2026 - ModernUO Development Team *
|
|
* Email: hi@modernuo.com *
|
|
* File: PromotedGuard.cs *
|
|
* *
|
|
* This program is free software: you can redistribute it and/or modify *
|
|
* it under the terms of the GNU General Public License as published by *
|
|
* the Free Software Foundation, either version 3 of the License, or *
|
|
* (at your option) any later version. *
|
|
* *
|
|
* You should have received a copy of the GNU General Public License *
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>. *
|
|
*************************************************************************/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
|
|
namespace Server.Network.Bans;
|
|
|
|
/// <summary>Suppresses re-reporting the same IP within a TTL. Accept-path thread only.</summary>
|
|
public sealed class PromotedGuard
|
|
{
|
|
private readonly Dictionary<UInt128, long> _expiry = [];
|
|
|
|
public bool TryMark(UInt128 ip, long nowTicks, long ttlMs)
|
|
{
|
|
if (_expiry.TryGetValue(ip, out var exp) && exp - nowTicks > 0)
|
|
{
|
|
return false;
|
|
}
|
|
_expiry[ip] = nowTicks + ttlMs;
|
|
return true;
|
|
}
|
|
|
|
public void Sweep(long nowTicks)
|
|
{
|
|
if (_expiry.Count == 0)
|
|
{
|
|
return;
|
|
}
|
|
using var dead = Collections.PooledRefQueue<UInt128>.Create();
|
|
foreach (var (ip, exp) in _expiry)
|
|
{
|
|
if (exp - nowTicks <= 0)
|
|
{
|
|
dead.Enqueue(ip);
|
|
}
|
|
}
|
|
while (dead.Count > 0)
|
|
{
|
|
_expiry.Remove(dead.Dequeue());
|
|
}
|
|
}
|
|
}
|