### Changes/Fixes:
* Adds timer pooling.
* Allows pool to be configurable in ModernUO.json
* Pool replenishes itself asynchronously if depleted.
* Fixes an issue with barkeeps and town criers
* Fixes an issue with incognito buff icons not being removed
* Fixes an issue with polymorph name mod not being removed
* Fixes several places where timers go on forever even after an object is deleted, keeping a reference (memory leak)
* Eliminates the timer for MiningCart altogether.
* Deletes `AcidSlime` since it is a duplicate of `PoolOfAcid`
* Fixes HonorableExecution and standardizes the code for other Bushido moves.
## Changes to the Timer API:
```cs
public class Timer
{
// Creates a timer that will be returned to the pool once execution stops.
public static void StartTimer(Action callback);
public static void StartTimer(TimeSpan delay, Action callback);
public static void StartTimer(TimeSpan delay, TimeSpan interval, Action callback);
public static void StartTimer(TimeSpan interval, int count, Action callback);
public static void StartTimer(TimeSpan delay, TimeSpan interval, int count, Action callback);
// Creates a timer and returns a token for more control. Requires manual cancellation in order for the timer to be returned to the pool.
// If the token is dereferenced, the timer will be dereferenced too. While not returning a timer to the pool is not considered hazardous, it does defeat the purpose of pooled timers.
public static void StartTimer(Action callback, out TimerExecutionToken token);
public static void StartTimer(TimeSpan delay, Action callback, out TimerExecutionToken token);
public static void StartTimer(TimeSpan delay, TimeSpan interval, Action callback, out TimerExecutionToken token);
public static void StartTimer(TimeSpan interval, int count, Action callback, out TimerExecutionToken token);
public static void StartTimer(TimeSpan delay, TimeSpan interval, int count, Action callback, out TimerExecutionToken token);
// If you aren't sure how to use the API above, or you don't care about performance, then you can use the old RunUO Timer.DelayCall
public static DelayCallTimer DelayCall(Action callback);
public static DelayCallTimer DelayCall(TimeSpan delay, Action callback);
public static DelayCallTimer DelayCall(TimeSpan delay, TimeSpan interval, Action callback);
public static DelayCallTimer DelayCall(TimeSpan interval, int count, Action callback);
public static DelayCallTimer DelayCall(TimeSpan delay, TimeSpan interval, int count, Action callback);
}
public struct TimerExecutionToken
{
public bool Running { get; }
public int Index { get; }
public int RemainingCount { get; }
public DateTime Next { get; }
}
```
## When to use `TimerExecutionToken`?
Use tokens when you want to gain the performance benefit of using a pooled timer, but you need one of the following:
* Access to the next time the timer will tick:`token.Next`
* Access to which interval, how many intervals there are, or how many are remaining: `token.Index`, `token.Count`, and `token.RemainingCount`
* Stop a timer manually.
* Determine if the timer is running: `timer.Running`
* See notes below about requirements for using tokens!
## Notes about using the TimerExecutionToken:
When you opt-in to receive a token, you must call `Cancel()` to return the timer. This can be done inside of the callback, or outside of the callback at any time.
If this is not called and your timer is an infinite interval, then you will create a potential memory leak, or null pointer exception in your callback.
If the timer ends and is stopped, but cancel is not called, then the timer will never return to the pool and stay referenced until the token is deleted or cancel is called. (Memory leak)
## Is this thread safe?
No. The ModernUO timer system is not thread safe at all. If you require a thread safe timer system, contact me and I'll help adapt this system. Keep in mind that there is a massive performance hit to make this thread safe when there are literally no use cases for it.
If you need to synchronize execution, meaning you want to execute code from another thread on the core thread. Let's say you have a discord bot that is pushing commands to the game server. Then use `EventLoopContext.Post(SendOrPostCallback callback, object state);`.
189 lines
6.4 KiB
C#
189 lines
6.4 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
|
|
namespace Server.Engines.Quests.Naturalist
|
|
{
|
|
public class StudyNestsObjective : QuestObjective
|
|
{
|
|
private readonly List<NestArea> m_StudiedNests = new();
|
|
private NestArea m_CurrentNest;
|
|
private DateTime m_StudyBegin;
|
|
private StudyState m_StudyState;
|
|
|
|
public override object Message => 1054044;
|
|
|
|
public override int MaxProgress => NestArea.NonSpecialCount;
|
|
|
|
public bool StudiedSpecialNest { get; private set; }
|
|
|
|
public override bool GetTimerEvent() => true;
|
|
|
|
public override void CheckProgress()
|
|
{
|
|
var from = System.From;
|
|
|
|
if (m_CurrentNest != null)
|
|
{
|
|
var nest = m_CurrentNest;
|
|
|
|
if ((from.Map == Map.Trammel || from.Map == Map.Felucca) && nest.Contains(from))
|
|
{
|
|
if (m_StudyState != StudyState.Inactive)
|
|
{
|
|
var time = Core.Now - m_StudyBegin;
|
|
|
|
if (time > TimeSpan.FromSeconds(30.0))
|
|
{
|
|
m_StudiedNests.Add(nest);
|
|
m_StudyState = StudyState.Inactive;
|
|
|
|
if (m_CurrentNest.Special)
|
|
{
|
|
// You complete your examination of this bizarre Egg Nest. The Naturalist will undoubtedly be quite interested in these notes!
|
|
from.SendLocalizedMessage(1054057);
|
|
StudiedSpecialNest = true;
|
|
}
|
|
else
|
|
{
|
|
// You have completed your study of this Solen Egg Nest. You put your notes away.
|
|
from.SendLocalizedMessage(1054054);
|
|
CurProgress++;
|
|
}
|
|
}
|
|
else if (m_StudyState == StudyState.FirstStep && time > TimeSpan.FromSeconds(15.0))
|
|
{
|
|
if (!nest.Special)
|
|
{
|
|
// You begin recording your completed notes on a bit of parchment.
|
|
from.SendLocalizedMessage(1054058);
|
|
}
|
|
|
|
m_StudyState = StudyState.SecondStep;
|
|
}
|
|
}
|
|
}
|
|
else
|
|
{
|
|
if (m_StudyState != StudyState.Inactive)
|
|
{
|
|
// You abandon your study of the Solen Egg Nest without gathering the needed information.
|
|
from.SendLocalizedMessage(1054046);
|
|
}
|
|
|
|
m_CurrentNest = null;
|
|
}
|
|
}
|
|
else if (from.Map == Map.Trammel || from.Map == Map.Felucca)
|
|
{
|
|
var nest = NestArea.Find(from);
|
|
|
|
if (nest != null)
|
|
{
|
|
m_CurrentNest = nest;
|
|
m_StudyBegin = Core.Now;
|
|
|
|
if (m_StudiedNests.Contains(nest))
|
|
{
|
|
m_StudyState = StudyState.Inactive;
|
|
|
|
// You glance at the Egg Nest, realizing you've already studied this one.
|
|
from.SendLocalizedMessage(1054047);
|
|
}
|
|
else
|
|
{
|
|
m_StudyState = StudyState.FirstStep;
|
|
|
|
if (nest.Special)
|
|
{
|
|
// You notice something very odd about this Solen Egg Nest. You begin taking notes.
|
|
from.SendLocalizedMessage(105405);
|
|
}
|
|
else
|
|
{
|
|
// You begin studying the Solen Egg Nest to gather information.
|
|
from.SendLocalizedMessage(1054045);
|
|
}
|
|
|
|
if (from.Female)
|
|
{
|
|
from.PlaySound(0x30B);
|
|
}
|
|
else
|
|
{
|
|
from.PlaySound(0x419);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
public override void RenderProgress(BaseQuestGump gump)
|
|
{
|
|
if (!Completed)
|
|
{
|
|
gump.AddHtmlLocalized(70, 260, 270, 100, 1054055, BaseQuestGump.Blue); // Solen Nests Studied :
|
|
gump.AddLabel(70, 280, 0x64, CurProgress.ToString());
|
|
gump.AddLabel(100, 280, 0x64, "/");
|
|
gump.AddLabel(130, 280, 0x64, MaxProgress.ToString());
|
|
}
|
|
else
|
|
{
|
|
base.RenderProgress(gump);
|
|
}
|
|
}
|
|
|
|
public override void OnComplete()
|
|
{
|
|
System.AddObjective(new ReturnToNaturalistObjective());
|
|
}
|
|
|
|
public override void ChildDeserialize(IGenericReader reader)
|
|
{
|
|
var version = reader.ReadEncodedInt();
|
|
|
|
var count = reader.ReadEncodedInt();
|
|
for (var i = 0; i < count; i++)
|
|
{
|
|
var nest = NestArea.GetByID(reader.ReadEncodedInt());
|
|
m_StudiedNests.Add(nest);
|
|
}
|
|
|
|
StudiedSpecialNest = reader.ReadBool();
|
|
}
|
|
|
|
public override void ChildSerialize(IGenericWriter writer)
|
|
{
|
|
writer.WriteEncodedInt(0); // version
|
|
|
|
writer.WriteEncodedInt(m_StudiedNests.Count);
|
|
foreach (var nest in m_StudiedNests)
|
|
{
|
|
writer.WriteEncodedInt(nest.ID);
|
|
}
|
|
|
|
writer.Write(StudiedSpecialNest);
|
|
}
|
|
|
|
private enum StudyState
|
|
{
|
|
Inactive,
|
|
FirstStep,
|
|
SecondStep
|
|
}
|
|
}
|
|
|
|
public class ReturnToNaturalistObjective : QuestObjective
|
|
{
|
|
public override object Message => 1054048;
|
|
|
|
public override void RenderProgress(BaseQuestGump gump)
|
|
{
|
|
var count = NestArea.NonSpecialCount.ToString();
|
|
|
|
gump.AddHtmlLocalized(70, 260, 270, 100, 1054055, BaseQuestGump.Blue); // Solen Nests Studied :
|
|
gump.AddLabel(70, 280, 0x64, count);
|
|
gump.AddLabel(100, 280, 0x64, "/");
|
|
gump.AddLabel(130, 280, 0x64, count);
|
|
}
|
|
}
|
|
}
|