9066e8fd00
## Summary Builds on PR #2446's cache-direct A*. The previous PR conservatively routed players + creatures with capability flags entirely through the slow path. This PR pushes that line: most mobile classes now use the cache, with the right rule set layered on top per-mobile, and the cache fast-path now does the dynamic items / mobiles check that PR #2446 had silently skipped. ## What changed - **Non-GM players** now use the cache. Diagonal corner-cut applies the strict AND-rule (BOTH cardinal partners walkable) by reading the same source-cell mask byte the creature OR-rule reads — both rules are evaluable from one byte. - **Creatures with `CanOpenDoors` / `CanMoveOverObstacles`** now use the cache. Reading `MovementImpl` confirmed those flags only affect dynamic items, never static tiles, so they were over-conservatively excluded before. - **Swim creatures** now use the cache via a capability overlay. `StepProbe` bakes a second rule set (`canSwim=true, cantWalk=true`) producing `WetMask` + `SwimZ_*`. The algorithm composes `effectiveMask = (walkMask & !cantWalk) | (wetMask & canSwim)` per direction; walk Z preferred when both apply. - **Dynamic-obstacle pass.** Cache fast-path now mirrors `MovementImpl`'s per-cell items + mobiles collision check (`GetItemsAt` / `GetMobilesAt` at the target cell, with `CanOpenDoors` / `CanMoveOverObstacles` / spell-field overrides). This closes a correctness gap from PR #2446 — the cache fast-path was silently skipping dynamic obstacles entirely. - **`StepCache.TryGetMask` returns `StepMask` struct** instead of 11 out parameters. `HitKind` rolls into the struct with an `IsHit` accessor. Sets up wet/swim without ballooning the call site. - **`StepChunk.MultiZCells` is lazy-init.** Most chunks are entirely single-Z; allocating the 32-byte bitmap up-front wasted ~256KB at full cap. - **Admin commands.** `[PathCacheStats` (resident chunks + hit/miss/eviction counters) and `[PathCacheClear` (drop everything, zero counters). - **Feature flag.** `bitmap_pathfinding_cache` (default true) gates the cache fast-path. Flipped off, every cell expansion routes to `MovementImpl` — equivalent to PR #2446's slow-path-only behavior. Safety net for shipping the new behavior. `RequiresSlowPath` shrinks to just `CanFly` — flying creatures Z-jump arbitrarily, which the cache's static-Z model can't accommodate.
85 lines
2.8 KiB
C#
85 lines
2.8 KiB
C#
namespace Server.Engines.Pathing.Cache;
|
|
|
|
/// <summary>
|
|
/// Per-cell, per-direction static walkability data baked by <see cref="StepProbe"/>
|
|
/// and stored by <see cref="StepCache"/>. WalkMask + WalkZ_* applies under default-walker
|
|
/// rules (cantWalk=false, canSwim=false). WetMask + SwimZ_* applies under swim-only rules
|
|
/// (cantWalk=true, canSwim=true). Algorithms layer the right rules per mobile.
|
|
/// </summary>
|
|
public readonly struct StepMask(
|
|
byte walkMask,
|
|
byte wetMask,
|
|
sbyte walkZN,
|
|
sbyte walkZNE,
|
|
sbyte walkZE,
|
|
sbyte walkZSE,
|
|
sbyte walkZS,
|
|
sbyte walkZSW,
|
|
sbyte walkZW,
|
|
sbyte walkZNW,
|
|
sbyte swimZN,
|
|
sbyte swimZNE,
|
|
sbyte swimZE,
|
|
sbyte swimZSE,
|
|
sbyte swimZS,
|
|
sbyte swimZSW,
|
|
sbyte swimZW,
|
|
sbyte swimZNW,
|
|
CacheHitKind hitKind = CacheHitKind.Hit
|
|
)
|
|
{
|
|
public readonly byte WalkMask = walkMask;
|
|
public readonly byte WetMask = wetMask;
|
|
public readonly sbyte WalkZ_N = walkZN;
|
|
public readonly sbyte WalkZ_NE = walkZNE;
|
|
public readonly sbyte WalkZ_E = walkZE;
|
|
public readonly sbyte WalkZ_SE = walkZSE;
|
|
public readonly sbyte WalkZ_S = walkZS;
|
|
public readonly sbyte WalkZ_SW = walkZSW;
|
|
public readonly sbyte WalkZ_W = walkZW;
|
|
public readonly sbyte WalkZ_NW = walkZNW;
|
|
public readonly sbyte SwimZ_N = swimZN;
|
|
public readonly sbyte SwimZ_NE = swimZNE;
|
|
public readonly sbyte SwimZ_E = swimZE;
|
|
public readonly sbyte SwimZ_SE = swimZSE;
|
|
public readonly sbyte SwimZ_S = swimZS;
|
|
public readonly sbyte SwimZ_SW = swimZSW;
|
|
public readonly sbyte SwimZ_W = swimZW;
|
|
public readonly sbyte SwimZ_NW = swimZNW;
|
|
public readonly CacheHitKind HitKind = hitKind;
|
|
|
|
/// <summary>
|
|
/// True when the cache produced a usable answer (Hit / Miss_NotBuilt / Miss_DirtyRebuild).
|
|
/// False on Fallthrough_*, in which case the caller must use the slow path for this cell.
|
|
/// </summary>
|
|
public bool IsHit => HitKind <= CacheHitKind.Miss_DirtyRebuild;
|
|
|
|
public bool IsWalkable(Direction d) => (WalkMask & (1 << (int)d)) != 0;
|
|
public bool IsSwimmable(Direction d) => (WetMask & (1 << (int)d)) != 0;
|
|
|
|
public sbyte GetWalkZ(Direction d) => d switch
|
|
{
|
|
Direction.North => WalkZ_N,
|
|
Direction.Right => WalkZ_NE,
|
|
Direction.East => WalkZ_E,
|
|
Direction.Down => WalkZ_SE,
|
|
Direction.South => WalkZ_S,
|
|
Direction.Left => WalkZ_SW,
|
|
Direction.West => WalkZ_W,
|
|
Direction.Up => WalkZ_NW,
|
|
_ => 0
|
|
};
|
|
|
|
public sbyte GetSwimZ(Direction d) => d switch
|
|
{
|
|
Direction.North => SwimZ_N,
|
|
Direction.Right => SwimZ_NE,
|
|
Direction.East => SwimZ_E,
|
|
Direction.Down => SwimZ_SE,
|
|
Direction.South => SwimZ_S,
|
|
Direction.Left => SwimZ_SW,
|
|
Direction.West => SwimZ_W,
|
|
Direction.Up => SwimZ_NW,
|
|
_ => 0
|
|
};
|
|
}
|