# Bounty Boards <img width="717" height="382" alt="image" src="https://github.com/user-attachments/assets/455e5206-47d8-4449-805c-19b143d059e5" /> <img width="918" height="637" alt="image" src="https://github.com/user-attachments/assets/e78e1ca2-62b8-4abf-8f69-21438bb1b759" /> <img width="340" height="296" alt="image" src="https://github.com/user-attachments/assets/fd17d7e6-8c53-47df-ac58-a89ea3ef665e" /> ## Setup * Setup as part of decorate when bounty system is enabled * Several bounty board locations with a WarriorGuard spawner in front of the board. Guard spawns and idles around 5 range. ## Tests ### ReportBountyMurdererGump * Follows same behaviour as ReportMurdererGump * Extracted common logic * Didn't use staticgump due to several dynamic parts including input * Optional bounty with validation >0 and <bankbox.total * Murder report is honored either way ### Bounty boards * Open bounty board with many bounties, no bounties * Keep a bounty board open, invalidate a bounty by turning in the head, then try to click on the post of the now invalid post. As expected: does nothing * Bounty messages use the last murder time as their post date and expire in 14 days * Bounty boards/messages are not reliant on serialization; they use serialized fields from MurderContext to build messages when clicked. * Bounty messages use synthetic serials so they do not have to persist bounty messages as items. They are constructed and sent as raw packets when needed. * Players only appear on the bounty board if they are a murderer (though a non-murderer can technically still have a bounty if they decayed kills) * Tested skin/hair color descriptions vs a dozen spot checks ### Head turn in behaviour * Guard accepts head * Bounty -> gives bounty * No bounty -> generic response * Expired head (24h) -> generic response NOTE: CUO "latest" has a bug with bounty/bulletinmessages that causes overflow outside of the container. It has nothing to do with this PR. It is fixed here in CUO https://github.com/ClassicUO/ClassicUO/pull/1871 # Murderer title Bounty system and "murderer" title eliminated in [pub16](https://uo.com/wiki/ultima-online-wiki/technical/previous-publishes/2002-2/publish-16-part-2-5-23rd-july/). So UO:LBR and before had bounties and murderer title. # Pre-T2A caveat There were differences in pre-T2A, but this cannot be currently implemented because we do not have any pre-T2A systems in general, so at least for now, behavior is consistent with later eras. Pre-T2A was a whole other ballgame, but the bounty system still worked similarly.
179 lines
5.5 KiB
C#
179 lines
5.5 KiB
C#
using System;
|
|
using System.Buffers;
|
|
using System.Runtime.CompilerServices;
|
|
using ModernUO.Serialization;
|
|
using Server.Collections;
|
|
using Server.Network;
|
|
|
|
namespace Server.Items
|
|
{
|
|
public static class BulletinBoardSystem
|
|
{
|
|
// Threads will be removed six hours after the last post was made
|
|
public static TimeSpan ThreadDeletionTime { get; private set; }
|
|
|
|
// A player may only create a thread once every two minutes
|
|
public static TimeSpan ThreadCreateTime { get; private set; }
|
|
|
|
// A player may only reply once every thirty seconds
|
|
public static TimeSpan ThreadReplyTime { get; private set; }
|
|
|
|
public static void Configure()
|
|
{
|
|
ThreadCreateTime = ServerConfiguration.GetOrUpdateSetting("bulletinboards.creationTimeDelay", TimeSpan.FromMinutes(2.0));
|
|
ThreadDeletionTime = ServerConfiguration.GetOrUpdateSetting("bulletinboards.expireDuration", TimeSpan.FromHours(6.0));
|
|
ThreadReplyTime = ServerConfiguration.GetOrUpdateSetting("bulletinboards.replyDelay", TimeSpan.FromSeconds(30.0));
|
|
}
|
|
|
|
[MethodImpl(MethodImplOptions.AggressiveInlining)]
|
|
public static bool CheckCreateTime(DateTime time) => time + ThreadCreateTime < Core.Now;
|
|
|
|
[MethodImpl(MethodImplOptions.AggressiveInlining)]
|
|
public static bool CheckDeletionTime(DateTime time) => time + ThreadDeletionTime < Core.Now;
|
|
|
|
[MethodImpl(MethodImplOptions.AggressiveInlining)]
|
|
public static bool CheckReplyTime(DateTime time) => time + ThreadReplyTime < Core.Now;
|
|
}
|
|
|
|
[SerializationGenerator(0, false)]
|
|
[Flippable(0x1E5E, 0x1E5F)]
|
|
public partial class BulletinBoard : BaseBulletinBoard
|
|
{
|
|
[Constructible]
|
|
public BulletinBoard() : base(0x1E5E)
|
|
{
|
|
}
|
|
}
|
|
|
|
[SerializationGenerator(0, false)]
|
|
public abstract partial class BaseBulletinBoard : Item
|
|
{
|
|
[SerializableField(0)]
|
|
[SerializedCommandProperty(AccessLevel.GameMaster)]
|
|
private string _boardName;
|
|
|
|
public BaseBulletinBoard(int itemID) : base(itemID)
|
|
{
|
|
BoardName = "bulletin board";
|
|
Movable = false;
|
|
}
|
|
|
|
[AfterDeserialization(false)]
|
|
public void Cleanup()
|
|
{
|
|
var items = Items;
|
|
var queue = PooledRefQueue<Item>.Create();
|
|
|
|
for (var i = items.Count - 1; i >= 0; --i)
|
|
{
|
|
if (i >= items.Count)
|
|
{
|
|
continue;
|
|
}
|
|
|
|
if (items[i] is not BulletinMessage msg || msg.Deleted)
|
|
{
|
|
continue;
|
|
}
|
|
|
|
// Top level thread expired
|
|
if (msg.Thread == null && BulletinBoardSystem.CheckDeletionTime(msg.LastPostTime))
|
|
{
|
|
queue.Enqueue(msg);
|
|
}
|
|
}
|
|
|
|
while (queue.Count > 0)
|
|
{
|
|
var msg = (BulletinMessage)queue.Dequeue();
|
|
RecurseDelete(msg, ref queue);
|
|
msg.Delete();
|
|
}
|
|
|
|
queue.Dispose();
|
|
}
|
|
|
|
private void RecurseDelete(BulletinMessage msg, ref PooledRefQueue<Item> queue)
|
|
{
|
|
var items = Items;
|
|
|
|
// All messages and sub-threads are also in the same bulletin board container
|
|
for (var i = items.Count - 1; i >= 0; --i)
|
|
{
|
|
if (i >= items.Count)
|
|
{
|
|
continue;
|
|
}
|
|
|
|
if (items[i] is not BulletinMessage check || check.Deleted)
|
|
{
|
|
continue;
|
|
}
|
|
|
|
if (check.Thread == msg)
|
|
{
|
|
queue.Enqueue(check);
|
|
}
|
|
}
|
|
}
|
|
|
|
public virtual bool GetLastPostTime(Mobile poster, bool onlyCheckRoot, out DateTime lastPostTime)
|
|
{
|
|
lastPostTime = DateTime.MinValue;
|
|
var items = Items;
|
|
var wasSet = false;
|
|
|
|
for (var i = 0; i < items.Count; ++i)
|
|
{
|
|
if (items[i] is not BulletinMessage msg || msg.Poster != poster)
|
|
{
|
|
continue;
|
|
}
|
|
|
|
if (onlyCheckRoot && msg.Thread != null)
|
|
{
|
|
continue;
|
|
}
|
|
|
|
if (msg.Time > lastPostTime)
|
|
{
|
|
wasSet = true;
|
|
lastPostTime = msg.Time;
|
|
}
|
|
}
|
|
|
|
return wasSet;
|
|
}
|
|
|
|
public override void OnDoubleClick(Mobile from)
|
|
{
|
|
if (!CheckRange(from))
|
|
{
|
|
from.LocalOverheadMessage(MessageType.Regular, 0x3B2, 1019045); // I can't reach that.
|
|
return;
|
|
}
|
|
|
|
Cleanup();
|
|
|
|
var state = from.NetState;
|
|
|
|
state.SendBBDisplayBoard(this);
|
|
state.SendContainerContent(from, this);
|
|
}
|
|
|
|
public virtual bool CheckRange(Mobile from) =>
|
|
from.AccessLevel >= AccessLevel.GameMaster || from.Map == Map && from.InRange(GetWorldLocation(), 2);
|
|
|
|
public virtual bool HandleBBRequest(int packetID, Mobile from, SpanReader reader) => false;
|
|
|
|
public virtual void PostMessage(Mobile from, BulletinMessage thread, string subject, string[] lines)
|
|
{
|
|
if (thread != null)
|
|
{
|
|
thread.LastPostTime = Core.Now;
|
|
}
|
|
|
|
AddItem(new BulletinMessage(from, thread, subject, lines));
|
|
}
|
|
}
|
|
}
|