ModernUO/Projects/UOContent/Engines/Craft/Core/CraftGump.cs
Kamron Batman a4cabe2fa4
fix: Optimizes FindItemsByType by removing allocations. (#1515)
### Summary
Container enumeration is in dire need of optimization. Thanks to @stefanomerotta for initiating this work with PR #1443. This PR handles a small part of what Stefan started. Also included are some bug fixes.

### Method Signatures

```cs
// Use with foreach without moving/deleting items
FindItemsByTypeEnumerator<T> FindItemsByType<T>(bool recurse = true, Predicate<T> predicate = null)

// Use with foreach when moving/deleting items
QueuedItemsEnumerator<T> EnumerateItemsByType<T>(bool recurse = true, Predicate<T> predicate = null)

// Use when iterating multiple times or queuing
PooledRefQueue<T> QueueItemsByType<T>(bool recurse = true, Predicate<T> predicate = null)

// Use when iterating multiples times or manipulating elements without traversing
PooledRefList<T> ListItemsByType<T>(bool recurse = true, Predicate<T> predicate = null)
```

* `FindItemsByType<T>` has changed from returning `List<T>` to `FindItemsByTypeEnumerator<T>` - This method is not safe to use in situations where an item may get consumed, deleted, or moved.

* `EnumerateItemsByType<T>` was added as a safe way to iterate and manipulate items.
  * **Note**: EnumerateItemsByType will _completely traverse the container_ before iteration starts because it uses `QueueItemsByType` under the hood.

* `QueueItemsByType<T>`  and `ListItemsByType<T>` was added to return a queue or list of items to iterate multiple times and manipulate the items. This isn't the most efficient since it uses a predicate and can result in 2 or 3 total iterations unnecessarily.

### Bug Fixes
- [X] Fishing had an error in the random check that may have caused slight bias.
2023-09-28 19:36:45 -07:00

738 lines
26 KiB
C#

using System;
using Server.Gumps;
using Server.Items;
using Server.Network;
namespace Server.Engines.Craft
{
public class CraftGump : Gump
{
public enum CraftPage
{
None,
PickResource,
PickResource2
}
private const int LabelHue = 0x480;
private const int LabelColor = 0x7FFF;
private const int FontColor = 0xFFFFFF;
private readonly CraftSystem m_CraftSystem;
private readonly Mobile m_From;
private readonly CraftPage m_Page;
private readonly BaseTool m_Tool;
public CraftGump(
Mobile from, CraftSystem craftSystem, BaseTool tool, TextDefinition notice, CraftPage page = CraftPage.None
) : base(40, 40)
{
m_From = from;
m_CraftSystem = craftSystem;
m_Tool = tool;
m_Page = page;
var context = craftSystem.GetContext(from);
from.CloseGump<CraftGump>();
from.CloseGump<CraftGumpItem>();
AddPage(0);
AddBackground(0, 0, 530, 437, 5054);
AddImageTiled(10, 10, 510, 22, 2624);
AddImageTiled(10, 292, 150, 45, 2624);
AddImageTiled(165, 292, 355, 45, 2624);
AddImageTiled(10, 342, 510, 85, 2624);
AddImageTiled(10, 37, 200, 250, 2624);
AddImageTiled(215, 37, 305, 250, 2624);
AddAlphaRegion(10, 10, 510, 417);
if (craftSystem.GumpTitle.Number > 0)
{
AddHtmlLocalized(10, 12, 510, 20, craftSystem.GumpTitle.Number, LabelColor);
}
else
{
AddHtml(10, 12, 510, 20, craftSystem.GumpTitle.String);
}
AddHtmlLocalized(10, 37, 200, 22, 1044010, LabelColor); // <CENTER>CATEGORIES</CENTER>
AddHtmlLocalized(215, 37, 305, 22, 1044011, LabelColor); // <CENTER>SELECTIONS</CENTER>
AddHtmlLocalized(10, 302, 150, 25, 1044012, LabelColor); // <CENTER>NOTICES</CENTER>
AddButton(15, 402, 4017, 4019, 0);
AddHtmlLocalized(50, 405, 150, 18, 1011441, LabelColor); // EXIT
AddButton(270, 402, 4005, 4007, GetButtonID(6, 2));
AddHtmlLocalized(305, 405, 150, 18, 1044013, LabelColor); // MAKE LAST
// Mark option
if (craftSystem.MarkOption)
{
AddButton(270, 362, 4005, 4007, GetButtonID(6, 6));
AddHtmlLocalized(
305,
365,
150,
18,
1044017 + (int)(context?.MarkOption ?? CraftMarkOption.MarkItem), // MARK ITEM
LabelColor
);
}
// ****************************************
// Resmelt option
if (craftSystem.Resmelt)
{
AddButton(15, 342, 4005, 4007, GetButtonID(6, 1));
AddHtmlLocalized(50, 345, 150, 18, 1044259, LabelColor); // SMELT ITEM
}
// ****************************************
// Repair option
if (craftSystem.Repair)
{
AddButton(270, 342, 4005, 4007, GetButtonID(6, 5));
AddHtmlLocalized(305, 345, 150, 18, 1044260, LabelColor); // REPAIR ITEM
}
// ****************************************
// Enhance option
if (craftSystem.CanEnhance)
{
AddButton(270, 382, 4005, 4007, GetButtonID(6, 8));
AddHtmlLocalized(305, 385, 150, 18, 1061001, LabelColor); // ENHANCE ITEM
}
// ****************************************
if (notice != null)
{
if (notice.Number > 0)
{
AddHtmlLocalized(170, 295, 350, 40, notice.Number, LabelColor);
}
else
{
AddHtml(170, 295, 350, 40, $"<BASEFONT COLOR=#{FontColor:X6}>{notice.String}</BASEFONT>");
}
}
// If the system has more than one resource
if (craftSystem.CraftSubRes.Init)
{
var nameString = craftSystem.CraftSubRes.Name.String;
var nameNumber = craftSystem.CraftSubRes.Name.Number;
var resIndex = context?.LastResourceIndex ?? -1;
var resourceType = craftSystem.CraftSubRes.ResType;
if (resIndex > -1)
{
var subResource = craftSystem.CraftSubRes.GetAt(resIndex);
nameString = subResource.Name.String;
nameNumber = subResource.Name.Number;
resourceType = subResource.ItemType;
}
var resourceCount = 0;
if (from.Backpack != null)
{
foreach (var item in from.Backpack.FindItemsByType())
{
if (resourceType.IsInstanceOfType(item))
{
resourceCount += item.Amount;
}
}
}
AddButton(15, 362, 4005, 4007, GetButtonID(6, 0));
if (nameNumber > 0)
{
AddHtmlLocalized(50, 365, 250, 18, nameNumber, resourceCount.ToString(), LabelColor);
}
else
{
AddLabel(50, 362, LabelHue, $"{nameString} ({resourceCount} Available)");
}
}
// ****************************************
// For dragon scales
if (craftSystem.CraftSubRes2.Init)
{
var nameString = craftSystem.CraftSubRes2.Name.String;
var nameNumber = craftSystem.CraftSubRes2.Name.Number;
var resIndex = context?.LastResourceIndex2 ?? -1;
var resourceType = craftSystem.CraftSubRes2.ResType;
if (resIndex > -1)
{
var subResource = craftSystem.CraftSubRes2.GetAt(resIndex);
nameString = subResource.Name.String;
nameNumber = subResource.Name.Number;
resourceType = subResource.ItemType;
}
var resourceCount = 0;
if (from.Backpack != null)
{
foreach (var item in from.Backpack.FindItemsByType())
{
if (resourceType.IsInstanceOfType(item))
{
resourceCount += item.Amount;
}
}
}
AddButton(15, 382, 4005, 4007, GetButtonID(6, 7));
if (nameNumber > 0)
{
AddHtmlLocalized(50, 385, 250, 18, nameNumber, resourceCount.ToString(), LabelColor);
}
else
{
AddLabel(50, 385, LabelHue, $"{nameString} ({resourceCount} Available)");
}
}
// ****************************************
CreateGroupList();
if (page == CraftPage.PickResource)
{
CreateResList(false, from);
}
else if (page == CraftPage.PickResource2)
{
CreateResList(true, from);
}
else if (context?.LastGroupIndex > -1)
{
CreateItemList(context.LastGroupIndex);
}
}
public void CreateResList(bool opt, Mobile from)
{
var res = opt ? m_CraftSystem.CraftSubRes2 : m_CraftSystem.CraftSubRes;
for (var i = 0; i < res.Count; ++i)
{
var index = i % 10;
var subResource = res[i];
if (index == 0)
{
if (i > 0)
{
AddButton(485, 260, 4005, 4007, 0, GumpButtonType.Page, i / 10 + 1);
}
AddPage(i / 10 + 1);
if (i > 0)
{
AddButton(455, 260, 4014, 4015, 0, GumpButtonType.Page, i / 10);
}
var context = m_CraftSystem.GetContext(m_From);
AddButton(220, 260, 4005, 4007, GetButtonID(6, 4));
AddHtmlLocalized(
255,
263,
200,
18,
context?.DoNotColor != true ? 1061591 : 1061590,
LabelColor
);
}
var resourceCount = 0;
if (from.Backpack != null)
{
var type = subResource.ItemType;
foreach (var item in from.Backpack.FindItemsByType())
{
if (type.IsInstanceOfType(item))
{
resourceCount += item.Amount;
}
}
}
AddButton(220, 60 + index * 20, 4005, 4007, GetButtonID(5, i));
if (subResource.Name.Number > 0)
{
AddHtmlLocalized(
255,
63 + index * 20,
250,
18,
subResource.Name.Number,
resourceCount.ToString(),
LabelColor
);
}
else
{
AddLabel(255, 60 + index * 20, LabelHue, $"{subResource.Name.String} ({resourceCount})");
}
}
}
public void CreateMakeLastList()
{
var context = m_CraftSystem.GetContext(m_From);
if (context == null)
{
return;
}
var items = context.Items;
if (items.Count > 0)
{
for (var i = 0; i < items.Count; ++i)
{
var index = i % 10;
var craftItem = items[i];
if (index == 0)
{
if (i > 0)
{
AddButton(370, 260, 4005, 4007, 0, GumpButtonType.Page, i / 10 + 1);
AddHtmlLocalized(405, 263, 100, 18, 1044045, LabelColor); // NEXT PAGE
}
AddPage(i / 10 + 1);
if (i > 0)
{
AddButton(220, 260, 4014, 4015, 0, GumpButtonType.Page, i / 10);
AddHtmlLocalized(255, 263, 100, 18, 1044044, LabelColor); // PREV PAGE
}
}
AddButton(220, 60 + index * 20, 4005, 4007, GetButtonID(3, i));
if (craftItem.NameNumber > 0)
{
AddHtmlLocalized(255, 63 + index * 20, 220, 18, craftItem.NameNumber, LabelColor);
}
else
{
AddLabel(255, 60 + index * 20, LabelHue, craftItem.NameString);
}
AddButton(480, 60 + index * 20, 4011, 4012, GetButtonID(4, i));
}
}
else
{
AddHtmlLocalized(230, 62, 200, 22, 1044165, LabelColor); // You haven't made anything yet.
}
}
public void CreateItemList(int selectedGroup)
{
if (selectedGroup == 501) // 501 : Last 10
{
CreateMakeLastList();
return;
}
var craftGroup = m_CraftSystem.CraftGroups[selectedGroup];
var craftItemCol = craftGroup.CraftItems;
for (var i = 0; i < craftItemCol.Count; ++i)
{
var index = i % 10;
var craftItem = craftItemCol[i];
if (index == 0)
{
if (i > 0)
{
AddButton(370, 260, 4005, 4007, 0, GumpButtonType.Page, i / 10 + 1);
AddHtmlLocalized(405, 263, 100, 18, 1044045, LabelColor); // NEXT PAGE
}
AddPage(i / 10 + 1);
if (i > 0)
{
AddButton(220, 260, 4014, 4015, 0, GumpButtonType.Page, i / 10);
AddHtmlLocalized(255, 263, 100, 18, 1044044, LabelColor); // PREV PAGE
}
}
AddButton(220, 60 + index * 20, 4005, 4007, GetButtonID(1, i));
if (craftItem.NameNumber > 0)
{
AddHtmlLocalized(255, 63 + index * 20, 220, 18, craftItem.NameNumber, LabelColor);
}
else
{
AddLabel(255, 60 + index * 20, LabelHue, craftItem.NameString);
}
AddButton(480, 60 + index * 20, 4011, 4012, GetButtonID(2, i));
}
}
public int CreateGroupList()
{
var craftGroupCol = m_CraftSystem.CraftGroups;
AddButton(15, 60, 4005, 4007, GetButtonID(6, 3));
AddHtmlLocalized(50, 63, 150, 18, 1044014, LabelColor); // LAST TEN
for (var i = 0; i < craftGroupCol.Count; i++)
{
var craftGroup = craftGroupCol[i];
AddButton(15, 80 + i * 20, 4005, 4007, GetButtonID(0, i));
if (craftGroup.NameNumber > 0)
{
AddHtmlLocalized(50, 83 + i * 20, 150, 18, craftGroup.NameNumber, LabelColor);
}
else
{
AddLabel(50, 80 + i * 20, LabelHue, craftGroup.NameString);
}
}
return craftGroupCol.Count;
}
public static int GetButtonID(int type, int index) => 1 + type + index * 7;
public void CraftItem(CraftItem item)
{
var num = m_CraftSystem.CanCraft(m_From, m_Tool, item.ItemType);
if (num > 0)
{
m_From.SendGump(new CraftGump(m_From, m_CraftSystem, m_Tool, num));
}
else
{
Type type = null;
var context = m_CraftSystem.GetContext(m_From);
if (context != null)
{
var res = item.UseSubRes2 ? m_CraftSystem.CraftSubRes2 : m_CraftSystem.CraftSubRes;
var resIndex = item.UseSubRes2 ? context.LastResourceIndex2 : context.LastResourceIndex;
if (resIndex >= 0 && resIndex < res.Count)
{
type = res.GetAt(resIndex).ItemType;
}
}
m_CraftSystem.CreateItem(m_From, item.ItemType, type, m_Tool, item);
}
}
public override void OnResponse(NetState sender, RelayInfo info)
{
if (info.ButtonID <= 0)
{
return; // Canceled
}
var buttonID = info.ButtonID - 1;
var type = buttonID % 7;
var index = buttonID / 7;
var system = m_CraftSystem;
var groups = system.CraftGroups;
var context = system.GetContext(m_From);
switch (type)
{
case 0: // Show group
{
if (context == null)
{
break;
}
if (index >= 0 && index < groups.Count)
{
context.LastGroupIndex = index;
m_From.SendGump(new CraftGump(m_From, system, m_Tool, null));
}
break;
}
case 1: // Create item
{
if (context == null)
{
break;
}
var groupIndex = context.LastGroupIndex;
if (groupIndex >= 0 && groupIndex < groups.Count)
{
var group = groups[groupIndex];
if (index >= 0 && index < group.CraftItems.Count)
{
CraftItem(group.CraftItems[index]);
}
}
break;
}
case 2: // Item details
{
if (context == null)
{
break;
}
var groupIndex = context.LastGroupIndex;
if (groupIndex >= 0 && groupIndex < groups.Count)
{
var group = groups[groupIndex];
if (index >= 0 && index < group.CraftItems.Count)
{
m_From.SendGump(new CraftGumpItem(m_From, system, group.CraftItems[index], m_Tool));
}
}
break;
}
case 3: // Create item (last 10)
{
if (context == null)
{
break;
}
var lastTen = context.Items;
if (index >= 0 && index < lastTen.Count)
{
CraftItem(lastTen[index]);
}
break;
}
case 4: // Item details (last 10)
{
if (context == null)
{
break;
}
var lastTen = context.Items;
if (index >= 0 && index < lastTen.Count)
{
m_From.SendGump(new CraftGumpItem(m_From, system, lastTen[index], m_Tool));
}
break;
}
case 5: // Resource selected
{
if (m_Page == CraftPage.PickResource && index >= 0 && index < system.CraftSubRes.Count)
{
var res = system.CraftSubRes.GetAt(index);
if (m_From.Skills[system.MainSkill].Base < res.RequiredSkill)
{
m_From.SendGump(new CraftGump(m_From, system, m_Tool, res.Message));
}
else
{
if (context != null)
{
context.LastResourceIndex = index;
}
m_From.SendGump(new CraftGump(m_From, system, m_Tool, null));
}
}
else if (m_Page == CraftPage.PickResource2 && index >= 0 && index < system.CraftSubRes2.Count)
{
var res = system.CraftSubRes2.GetAt(index);
if (m_From.Skills[system.MainSkill].Base < res.RequiredSkill)
{
m_From.SendGump(new CraftGump(m_From, system, m_Tool, res.Message));
}
else
{
if (context != null)
{
context.LastResourceIndex2 = index;
}
m_From.SendGump(new CraftGump(m_From, system, m_Tool, null));
}
}
break;
}
case 6: // Misc. buttons
{
switch (index)
{
case 0: // Resource selection
{
if (system.CraftSubRes.Init)
{
m_From.SendGump(new CraftGump(m_From, system, m_Tool, null, CraftPage.PickResource));
}
break;
}
case 1: // Smelt item
{
if (system.Resmelt)
{
Resmelt.Do(m_From, system, m_Tool);
}
break;
}
case 2: // Make last
{
if (context == null)
{
break;
}
var item = context.LastMade;
if (item != null)
{
CraftItem(item);
}
else
{
m_From.SendGump(
new CraftGump(
m_From,
m_CraftSystem,
m_Tool,
1044165, // You haven't made anything yet.
m_Page
)
);
}
break;
}
case 3: // Last 10
{
if (context == null)
{
break;
}
context.LastGroupIndex = 501;
m_From.SendGump(new CraftGump(m_From, system, m_Tool, null));
break;
}
case 4: // Toggle use resource hue
{
if (context == null)
{
break;
}
context.DoNotColor = !context.DoNotColor;
m_From.SendGump(new CraftGump(m_From, m_CraftSystem, m_Tool, null, m_Page));
break;
}
case 5: // Repair item
{
if (system.Repair)
{
Repair.Do(m_From, system, m_Tool);
}
break;
}
case 6: // Toggle mark option
{
if (context == null || !system.MarkOption)
{
break;
}
context.MarkOption = context.MarkOption switch
{
CraftMarkOption.MarkItem => CraftMarkOption.DoNotMark,
CraftMarkOption.DoNotMark => CraftMarkOption.PromptForMark,
CraftMarkOption.PromptForMark => CraftMarkOption.MarkItem,
_ => context.MarkOption
};
m_From.SendGump(new CraftGump(m_From, m_CraftSystem, m_Tool, null, m_Page));
break;
}
case 7: // Resource selection 2
{
if (system.CraftSubRes2.Init)
{
m_From.SendGump(
new CraftGump(m_From, system, m_Tool, null, CraftPage.PickResource2)
);
}
break;
}
case 8: // Enhance item
{
if (system.CanEnhance)
{
Enhance.BeginTarget(m_From, system, m_Tool);
}
break;
}
}
break;
}
}
}
}
}