ModernUO/Projects/UOContent/Gumps/Props/SetGump.cs
Kamron Batman 8a34903326
feat: Consolidates staff gump layouts (#2404)
## Summary
- Creates `PropsLayoutExtensions.cs` with reusable extension methods for both legacy `Gump` and `DynamicGumpBuilder` that encapsulate the repeating PropsConfig-style layout patterns (frame, header navigation, entry rows)
- Converts all 12 standardized staff gumps to use the new extensions, reducing ~570 lines of duplicated layout code
- Adds Type and Serial display to PropsGump and SkillsGump headers (e.g. `PlayerMobile (0x1)`)

### Extension methods provided
| Method | Pattern |
|--------|---------|
| `AddPropsFrame` | Background + offset region + origin coordinates |
| `AddPropsHeader` | 3-column: [Prev] [Title] [Next] |
| `AddPropsHeaderWithBack` | 4-column: [Back] [Title] [Prev] [Next] |
| `AddPropsEntryButton` | Label + action button |
| `AddPropsEntryNameValue` | Name + Value + action button |
| `AddPropsEntryTextInput` | Text input + action button |
| `AddPropsEntryLabel` | Label only (no button) |
| `AddPropsEntryType` | Full-width type label |
| `AddPropsEntryBlank` | Separator row |

### Gumps converted
PropsGump, GoGump, WhoGump, SkillsGump (frame+header), EditSkillGump, SetGump, SetObjectGump, SetPoint2DGump, SetPoint3DGump, SetTimeSpanGump (frame), SetListOptionGump (frame+header), CategorizedAddGump (frame+header)

## Test plan
- [x] Verify `[props` gump displays correctly with type + serial in header
- [x] Verify `[skills` gump displays correctly with type + serial in header
- [x] Verify `[go` navigation gump works (prev/next/back)
- [x] Verify property editing gumps (Set, SetObject, SetPoint2D, SetPoint3D, SetTimeSpan, SetListOption)
- [x] Verify `[categorizedadd` gump works
- [x] Verify `[who` gump works with pagination
2026-04-08 11:42:46 -06:00

171 lines
5.6 KiB
C#

using System.Reflection;
using Server.Commands;
using Server.HuePickers;
using Server.Network;
using static Server.Gumps.PropsConfig;
namespace Server.Gumps
{
public class SetGump : Gump
{
private const int EntryWidth = 212;
private const int TotalWidth = OffsetSize + EntryWidth + OffsetSize + SetWidth + OffsetSize;
private readonly Mobile m_Mobile;
private readonly object m_Object;
private readonly PropertyInfo m_Property;
private readonly PropertiesGump m_PropertiesGump;
public SetGump(PropertyInfo prop, Mobile from, object o, PropertiesGump propertiesGump) : base(GumpOffsetX, GumpOffsetY)
{
m_Mobile = from;
m_Object = o;
m_Property = prop;
m_PropertiesGump = propertiesGump;
var canNull = !prop.PropertyType.IsValueType;
var canDye = prop.IsDefined(typeof(HueAttribute), false);
var val = prop.GetValue(m_Object, null);
var initialText = val switch
{
null => "",
TextDefinition definition => definition.GetValue(),
_ => val.ToString()
};
var rowCount = 2 + (canNull ? 1 : 0) + (canDye ? 1 : 0);
AddPage(0);
this.AddPropsFrame(TotalWidth, rowCount, out var x, out var y);
this.AddPropsEntryLabel(ref x, ref y, EntryWidth, prop.Name);
PropsLayout.NextRow(ref x, ref y);
this.AddPropsEntryTextInput(ref x, ref y, EntryWidth, 0, initialText, true, 1);
if (canNull)
{
PropsLayout.NextRow(ref x, ref y);
this.AddPropsEntryButton(ref x, ref y, EntryWidth, "Null", true, 2);
}
if (canDye)
{
PropsLayout.NextRow(ref x, ref y);
this.AddPropsEntryButton(ref x, ref y, EntryWidth, "Hue Picker", true, 3);
}
}
public override void OnResponse(NetState sender, in RelayInfo info)
{
object toSet = null;
bool shouldSet, shouldSend = true;
switch (info.ButtonID)
{
case 1:
{
var text = info.GetTextEntry(0)?.Trim();
if (text?.Length > 0)
{
try
{
Types.TryParse(m_Property.PropertyType, text, out toSet);
shouldSet = true;
}
catch
{
toSet = null;
shouldSet = false;
m_Mobile.SendMessage("Bad format");
}
}
else
{
shouldSet = false;
}
break;
}
case 2: // Null
{
shouldSet = true;
break;
}
case 3: // Hue Picker
{
shouldSet = false;
shouldSend = false;
m_Mobile.SendHuePicker(new InternalPicker(m_Property, m_Mobile, m_Object, m_PropertiesGump));
break;
}
default:
{
shouldSet = false;
break;
}
}
if (shouldSet)
{
try
{
CommandLogging.LogChangeProperty(
m_Mobile,
m_Object,
m_Property.Name,
toSet?.ToString() ?? "(null)"
);
m_Property.SetValue(m_Object, toSet, null);
m_PropertiesGump.OnValueChanged(m_Object, m_Property);
}
catch
{
m_Mobile.SendMessage("An exception was caught. The property may not have changed.");
}
}
if (shouldSend)
{
m_PropertiesGump.SendPropertiesGump();
}
}
private class InternalPicker : HuePicker
{
private readonly Mobile m_Mobile;
private readonly object m_Object;
private readonly PropertyInfo m_Property;
private readonly PropertiesGump m_PropertiesGump;
public InternalPicker(PropertyInfo prop, Mobile mobile, object o, PropertiesGump propertiesGump)
: base(((IHued)o).HuedItemID)
{
m_Property = prop;
m_Mobile = mobile;
m_Object = o;
m_PropertiesGump = propertiesGump;
}
public override void OnResponse(int hue)
{
try
{
CommandLogging.LogChangeProperty(m_Mobile, m_Object, m_Property.Name, hue.ToString());
m_Property.SetValue(m_Object, hue, null);
m_PropertiesGump.OnValueChanged(m_Object, m_Property);
}
catch
{
m_Mobile.SendMessage("An exception was caught. The property may not have changed.");
}
m_PropertiesGump.SendPropertiesGump();
}
}
}
}