50599e0453
## Summary Migrates five legacy `Gump`-derived UI dialogs in the NPC and Skill domains to the modern `DynamicGump` builder pipeline. All five gumps were chosen as `DynamicGump` rather than `StaticGump<T>` because their layout shape varies per instance, and several of them carry per-instance localization numbers (cliloc IDs) that the static cache cannot bake (see CLAUDE.md gump-system rule and `dev-docs/gump-system.md`). Per-gump rationale: - **`TownCrierGump` (`Mobiles/Townfolk/TownCrier.cs`)** - DynamicGump. Announcement count varies, expiration text is rebuilt per render via `ValueStringBuilder`, and one button per entry is emitted in a loop. - **`ClaimListGump` (`Mobiles/Vendors/NPC/AnimalTrainer.cs`)** - DynamicGump. The pet list and resulting background/alpha-region heights vary per stabling player. - **`AnimalLoreGump` (`Skills/AnimalLore.cs`)** - DynamicGump. Page count itself varies (3 pages pre-AOS, 5 pages on AOS) and several `AddHtmlLocalized` calls use cliloc IDs computed from per-creature data (loyalty rating `1049595 + c.Loyalty / 10`, food preference, pack instinct), which violates the StaticGump cliloc-bake rule. - **`DisguiseGump` (`Items/Skill Items/Thief/DisguiseKit.cs`)** - DynamicGump. Page count and entry order shift on `from.Female`, `Body.IsFemale`, and `startAtHair`. - **`CommentsGump` (`Gumps/CommentsGump.cs`)** - DynamicGump. Comment list and pagination depend on `Account.Comments` size; the title label encodes the variable account username string. All five are now `Singleton => true`, have `private` constructors, and expose static `DisplayTo(...)` entry points that validate prerequisites before constructing - guaranteeing no empty gumps (CLAUDE.md Sec.13). All internal refresh paths (prompts, `OnDoubleClick`, command handlers, target callbacks) were updated to call `DisplayTo` rather than `new XGump(...)`. Legacy `m_`-prefixed fields renamed to `_camelCase` (CLAUDE.md Sec.12), and `DisguiseEntry`'s `m_`-prefixed public readonly fields converted to PascalCase auto-properties. `OnResponse` signatures updated to `in RelayInfo info`. No external callers needed updating - all `new XGump(...)` sites lived inside the same files.
444 lines
16 KiB
C#
444 lines
16 KiB
C#
using System;
|
|
using Server.Gumps;
|
|
using Server.Items;
|
|
using Server.Mobiles;
|
|
using Server.Targeting;
|
|
|
|
namespace Server.SkillHandlers
|
|
{
|
|
public static class AnimalLore
|
|
{
|
|
public static void Initialize()
|
|
{
|
|
SkillInfo.Table[(int)SkillName.AnimalLore].Callback = OnUse;
|
|
}
|
|
|
|
public static TimeSpan OnUse(Mobile m)
|
|
{
|
|
m.Target = new InternalTarget();
|
|
|
|
m.SendLocalizedMessage(500328); // What animal should I look at?
|
|
|
|
return TimeSpan.FromSeconds(1.0);
|
|
}
|
|
|
|
private class InternalTarget : Target
|
|
{
|
|
public InternalTarget() : base(8, false, TargetFlags.None)
|
|
{
|
|
}
|
|
|
|
protected override void OnTarget(Mobile from, object targeted)
|
|
{
|
|
if (!from.Alive)
|
|
{
|
|
from.SendLocalizedMessage(500331); // The spirits of the dead are not the province of animal lore.
|
|
}
|
|
else if (targeted is not BaseCreature c)
|
|
{
|
|
from.SendLocalizedMessage(500329); // That's not an animal!
|
|
}
|
|
else if (c.IsDeadPet)
|
|
{
|
|
from.SendLocalizedMessage(500331); // The spirits of the dead are not the province of animal lore.
|
|
}
|
|
else if (!c.Body.IsAnimal && c.Body is { IsMonster: false, IsSea: false })
|
|
{
|
|
from.SendLocalizedMessage(500329); // That's not an animal!
|
|
}
|
|
else if (!c.Controlled && from.Skills.AnimalLore.Value < 100.0)
|
|
{
|
|
// At your skill level, you can only lore tamed creatures.
|
|
from.SendLocalizedMessage(1049674);
|
|
}
|
|
else if (!c.Controlled && !c.Tamable && from.Skills.AnimalLore.Value < 110.0)
|
|
{
|
|
// At your skill level, you can only lore tamed or tameable creatures.
|
|
from.SendLocalizedMessage(1049675);
|
|
}
|
|
else if (!from.CheckTargetSkill(SkillName.AnimalLore, c, 0.0, 120.0))
|
|
{
|
|
from.SendLocalizedMessage(500334); // You can't think of anything you know offhand.
|
|
}
|
|
else
|
|
{
|
|
AnimalLoreGump.DisplayTo(from, c);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
public class AnimalLoreGump : DynamicGump
|
|
{
|
|
private const int LabelColor = 0x24E5;
|
|
|
|
private readonly BaseCreature _creature;
|
|
|
|
public override bool Singleton => true;
|
|
|
|
private AnimalLoreGump(BaseCreature c) : base(250, 50) => _creature = c;
|
|
|
|
public static void DisplayTo(Mobile from, BaseCreature c)
|
|
{
|
|
if (from?.NetState == null || c == null || c.Deleted)
|
|
{
|
|
return;
|
|
}
|
|
|
|
from.SendGump(new AnimalLoreGump(c));
|
|
}
|
|
|
|
protected override void BuildLayout(ref DynamicGumpBuilder builder)
|
|
{
|
|
var c = _creature;
|
|
|
|
builder.AddPage(0);
|
|
|
|
builder.AddImage(100, 100, 2080);
|
|
builder.AddImage(118, 137, 2081);
|
|
builder.AddImage(118, 207, 2081);
|
|
builder.AddImage(118, 277, 2081);
|
|
builder.AddImage(118, 347, 2083);
|
|
|
|
builder.AddHtml(147, 108, 210, 18, $"<center><i>{c.Name}</i></center>");
|
|
|
|
builder.AddButton(240, 77, 2093, 2093, 2);
|
|
|
|
builder.AddImage(140, 138, 2091);
|
|
builder.AddImage(140, 335, 2091);
|
|
|
|
var pages = Core.AOS ? 5 : 3;
|
|
var page = 0;
|
|
|
|
builder.AddPage(++page);
|
|
|
|
builder.AddImage(128, 152, 2086);
|
|
builder.AddHtmlLocalized(147, 150, 160, 18, 1049593, 200); // Attributes
|
|
|
|
builder.AddHtmlLocalized(153, 168, 160, 18, 1049578, LabelColor); // Hits
|
|
builder.AddHtml(280, 168, 75, 18, FormatAttributes(c.Hits, c.HitsMax));
|
|
|
|
builder.AddHtmlLocalized(153, 186, 160, 18, 1049579, LabelColor); // Stamina
|
|
builder.AddHtml(280, 186, 75, 18, FormatAttributes(c.Stam, c.StamMax));
|
|
|
|
builder.AddHtmlLocalized(153, 204, 160, 18, 1049580, LabelColor); // Mana
|
|
builder.AddHtml(280, 204, 75, 18, FormatAttributes(c.Mana, c.ManaMax));
|
|
|
|
builder.AddHtmlLocalized(153, 222, 160, 18, 1028335, LabelColor); // Strength
|
|
builder.AddHtml(320, 222, 35, 18, FormatStat(c.Str));
|
|
|
|
builder.AddHtmlLocalized(153, 240, 160, 18, 3000113, LabelColor); // Dexterity
|
|
builder.AddHtml(320, 240, 35, 18, FormatStat(c.Dex));
|
|
|
|
builder.AddHtmlLocalized(153, 258, 160, 18, 3000112, LabelColor); // Intelligence
|
|
builder.AddHtml(320, 258, 35, 18, FormatStat(c.Int));
|
|
|
|
if (Core.AOS)
|
|
{
|
|
var y = 276;
|
|
|
|
if (Core.SE)
|
|
{
|
|
var bd = BaseInstrument.GetBaseDifficulty(c);
|
|
if (c.Uncalmable)
|
|
{
|
|
bd = 0;
|
|
}
|
|
|
|
builder.AddHtmlLocalized(153, 276, 160, 18, 1070793, LabelColor); // Barding Difficulty
|
|
builder.AddHtml(320, y, 35, 18, FormatDouble(bd));
|
|
|
|
y += 18;
|
|
}
|
|
|
|
builder.AddImage(128, y + 2, 2086);
|
|
builder.AddHtmlLocalized(147, y, 160, 18, 1049594, 200); // Loyalty Rating
|
|
y += 18;
|
|
|
|
builder.AddHtmlLocalized(
|
|
153,
|
|
y,
|
|
160,
|
|
18,
|
|
!c.Controlled || c.Loyalty == 0 ? 1061643 : 1049595 + c.Loyalty / 10,
|
|
LabelColor
|
|
);
|
|
}
|
|
else
|
|
{
|
|
builder.AddImage(128, 278, 2086);
|
|
builder.AddHtmlLocalized(147, 276, 160, 18, 3001016, 200); // Miscellaneous
|
|
|
|
builder.AddHtmlLocalized(153, 294, 160, 18, 1049581, LabelColor); // Armor Rating
|
|
builder.AddHtml(320, 294, 35, 18, FormatStat(c.VirtualArmor));
|
|
}
|
|
|
|
builder.AddButton(340, 358, 5601, 5605, 0, GumpButtonType.Page, page + 1);
|
|
builder.AddButton(317, 358, 5603, 5607, 0, GumpButtonType.Page, pages);
|
|
|
|
if (Core.AOS)
|
|
{
|
|
builder.AddPage(++page);
|
|
|
|
builder.AddImage(128, 152, 2086);
|
|
builder.AddHtmlLocalized(147, 150, 160, 18, 1061645, 200); // Resistances
|
|
|
|
builder.AddHtmlLocalized(153, 168, 160, 18, 1061646, LabelColor); // Physical
|
|
builder.AddHtml(320, 168, 35, 18, FormatElement(c.PhysicalResistance));
|
|
|
|
builder.AddHtmlLocalized(153, 186, 160, 18, 1061647, LabelColor); // Fire
|
|
builder.AddHtml(320, 186, 35, 18, FormatElement(c.FireResistance, "#FF0000"));
|
|
|
|
builder.AddHtmlLocalized(153, 204, 160, 18, 1061648, LabelColor); // Cold
|
|
builder.AddHtml(320, 204, 35, 18, FormatElement(c.ColdResistance, "#000080"));
|
|
|
|
builder.AddHtmlLocalized(153, 222, 160, 18, 1061649, LabelColor); // Poison
|
|
builder.AddHtml(320, 222, 35, 18, FormatElement(c.PoisonResistance, "#008000"));
|
|
|
|
builder.AddHtmlLocalized(153, 240, 160, 18, 1061650, LabelColor); // Energy
|
|
builder.AddHtml(320, 240, 35, 18, FormatElement(c.EnergyResistance, "#BF80FF"));
|
|
|
|
builder.AddButton(340, 358, 5601, 5605, 0, GumpButtonType.Page, page + 1);
|
|
builder.AddButton(317, 358, 5603, 5607, 0, GumpButtonType.Page, page - 1);
|
|
|
|
builder.AddPage(++page);
|
|
|
|
builder.AddImage(128, 152, 2086);
|
|
builder.AddHtmlLocalized(147, 150, 160, 18, 1017319, 200); // Damage
|
|
|
|
builder.AddHtmlLocalized(153, 168, 160, 18, 1061646, LabelColor); // Physical
|
|
builder.AddHtml(320, 168, 35, 18, FormatElement(c.PhysicalDamage));
|
|
|
|
builder.AddHtmlLocalized(153, 186, 160, 18, 1061647, LabelColor); // Fire
|
|
builder.AddHtml(320, 186, 35, 18, FormatElement(c.FireDamage, "#FF0000"));
|
|
|
|
builder.AddHtmlLocalized(153, 204, 160, 18, 1061648, LabelColor); // Cold
|
|
builder.AddHtml(320, 204, 35, 18, FormatElement(c.ColdDamage, "#000080"));
|
|
|
|
builder.AddHtmlLocalized(153, 222, 160, 18, 1061649, LabelColor); // Poison
|
|
builder.AddHtml(320, 222, 35, 18, FormatElement(c.PoisonDamage, "#008000"));
|
|
|
|
builder.AddHtmlLocalized(153, 240, 160, 18, 1061650, LabelColor); // Energy
|
|
builder.AddHtml(320, 240, 35, 18, FormatElement(c.EnergyDamage, "#BF80FF"));
|
|
|
|
if (Core.ML)
|
|
{
|
|
builder.AddHtmlLocalized(153, 258, 160, 18, 1076750, LabelColor); // Base Damage
|
|
builder.AddHtml(300, 258, 55, 18, FormatDamage(c.DamageMin, c.DamageMax));
|
|
}
|
|
|
|
builder.AddButton(340, 358, 5601, 5605, 0, GumpButtonType.Page, page + 1);
|
|
builder.AddButton(317, 358, 5603, 5607, 0, GumpButtonType.Page, page - 1);
|
|
}
|
|
|
|
builder.AddPage(++page);
|
|
|
|
builder.AddImage(128, 152, 2086);
|
|
builder.AddHtmlLocalized(147, 150, 160, 18, 3001030, 200); // Combat Ratings
|
|
|
|
builder.AddHtmlLocalized(153, 168, 160, 18, 1044103, LabelColor); // Wrestling
|
|
builder.AddHtml(320, 168, 35, 18, FormatSkill(c, SkillName.Wrestling));
|
|
|
|
builder.AddHtmlLocalized(153, 186, 160, 18, 1044087, LabelColor); // Tactics
|
|
builder.AddHtml(320, 186, 35, 18, FormatSkill(c, SkillName.Tactics));
|
|
|
|
builder.AddHtmlLocalized(153, 204, 160, 18, 1044086, LabelColor); // Magic Resistance
|
|
builder.AddHtml(320, 204, 35, 18, FormatSkill(c, SkillName.MagicResist));
|
|
|
|
builder.AddHtmlLocalized(153, 222, 160, 18, 1044061, LabelColor); // Anatomy
|
|
builder.AddHtml(320, 222, 35, 18, FormatSkill(c, SkillName.Anatomy));
|
|
|
|
if (c is CuSidhe)
|
|
{
|
|
builder.AddHtmlLocalized(153, 240, 160, 18, 1044077, LabelColor); // Healing
|
|
builder.AddHtml(320, 240, 35, 18, FormatSkill(c, SkillName.Healing));
|
|
}
|
|
else
|
|
{
|
|
builder.AddHtmlLocalized(153, 240, 160, 18, 1044090, LabelColor); // Poisoning
|
|
builder.AddHtml(320, 240, 35, 18, FormatSkill(c, SkillName.Poisoning));
|
|
}
|
|
|
|
// TODO: Add remaining combat skills
|
|
|
|
builder.AddImage(128, 260, 2086);
|
|
builder.AddHtmlLocalized(147, 258, 160, 18, 3001032, 200); // Lore & Knowledge
|
|
|
|
builder.AddHtmlLocalized(153, 276, 160, 18, 1044085, LabelColor); // Magery
|
|
builder.AddHtml(320, 276, 35, 18, FormatSkill(c, SkillName.Magery));
|
|
|
|
builder.AddHtmlLocalized(153, 294, 160, 18, 1044076, LabelColor); // Evaluating Intelligence
|
|
builder.AddHtml(320, 294, 35, 18, FormatSkill(c, SkillName.EvalInt));
|
|
|
|
builder.AddHtmlLocalized(153, 312, 160, 18, 1044106, LabelColor); // Meditation
|
|
builder.AddHtml(320, 312, 35, 18, FormatSkill(c, SkillName.Meditation));
|
|
|
|
// TODO: Add remaining skills
|
|
|
|
builder.AddButton(340, 358, 5601, 5605, 0, GumpButtonType.Page, page + 1);
|
|
builder.AddButton(317, 358, 5603, 5607, 0, GumpButtonType.Page, page - 1);
|
|
|
|
builder.AddPage(++page);
|
|
|
|
builder.AddImage(128, 152, 2086);
|
|
builder.AddHtmlLocalized(147, 150, 160, 18, 1049563, 200); // Preferred Foods
|
|
|
|
var foodPref = 3000340;
|
|
|
|
if ((c.FavoriteFood & FoodType.Meat) != 0)
|
|
{
|
|
foodPref = 1049564; // Meat
|
|
}
|
|
else if ((c.FavoriteFood & FoodType.FruitsAndVeggies) != 0)
|
|
{
|
|
foodPref = 1049565; // Fruits and Vegetables
|
|
}
|
|
else if ((c.FavoriteFood & FoodType.GrainsAndHay) != 0)
|
|
{
|
|
foodPref = 1049566; // Grains and Hay
|
|
}
|
|
else if ((c.FavoriteFood & FoodType.Fish) != 0)
|
|
{
|
|
foodPref = 1049568; // Fish
|
|
}
|
|
else if ((c.FavoriteFood & FoodType.Metal) != 0)
|
|
{
|
|
foodPref = 1049567; // Metal
|
|
}
|
|
else if ((c.FavoriteFood & FoodType.Eggs) != 0)
|
|
{
|
|
foodPref = 1044477; // Eggs
|
|
}
|
|
|
|
// TODO: Add 1115752 "Blackrock Stew" as a food type
|
|
|
|
builder.AddHtmlLocalized(153, 168, 160, 18, foodPref, LabelColor);
|
|
|
|
builder.AddImage(128, 188, 2086);
|
|
builder.AddHtmlLocalized(147, 186, 160, 18, 1049569, 200); // Pack Instincts
|
|
|
|
var packInstinct = 3000340;
|
|
|
|
if ((c.PackInstinct & PackInstinct.Canine) != 0)
|
|
{
|
|
packInstinct = 1049570; // Canine
|
|
}
|
|
else if ((c.PackInstinct & PackInstinct.Ostard) != 0)
|
|
{
|
|
packInstinct = 1049571; // Ostard
|
|
}
|
|
else if ((c.PackInstinct & PackInstinct.Feline) != 0)
|
|
{
|
|
packInstinct = 1049572; // Feline
|
|
}
|
|
else if ((c.PackInstinct & PackInstinct.Arachnid) != 0)
|
|
{
|
|
packInstinct = 1049573; // Arachnid
|
|
}
|
|
else if ((c.PackInstinct & PackInstinct.Daemon) != 0)
|
|
{
|
|
packInstinct = 1049574; // Daemon
|
|
}
|
|
else if ((c.PackInstinct & PackInstinct.Bear) != 0)
|
|
{
|
|
packInstinct = 1049575; // Bear
|
|
}
|
|
else if ((c.PackInstinct & PackInstinct.Equine) != 0)
|
|
{
|
|
packInstinct = 1049576; // Equine
|
|
}
|
|
else if ((c.PackInstinct & PackInstinct.Bull) != 0)
|
|
{
|
|
packInstinct = 1049577; // Bull
|
|
}
|
|
|
|
builder.AddHtmlLocalized(153, 204, 160, 18, packInstinct, LabelColor);
|
|
|
|
// TODO: Add Pet Slots
|
|
|
|
// TODO: Add Abilities
|
|
|
|
if (!Core.AOS)
|
|
{
|
|
builder.AddImage(128, 224, 2086);
|
|
builder.AddHtmlLocalized(147, 222, 160, 18, 1049594, 200); // Loyalty Rating
|
|
|
|
builder.AddHtmlLocalized(
|
|
153,
|
|
240,
|
|
160,
|
|
18,
|
|
!c.Controlled || c.Loyalty == 0 ? 1061643 : 1049595 + c.Loyalty / 10,
|
|
LabelColor
|
|
);
|
|
}
|
|
|
|
builder.AddButton(340, 358, 5601, 5605, 0, GumpButtonType.Page, 1);
|
|
builder.AddButton(317, 358, 5603, 5607, 0, GumpButtonType.Page, page - 1);
|
|
}
|
|
|
|
private static string FormatSkill(BaseCreature c, SkillName name)
|
|
{
|
|
var skill = c.Skills[name];
|
|
|
|
if (skill.Base < 10.0)
|
|
{
|
|
return "<div align=right>---</div>";
|
|
}
|
|
|
|
return $"<div align=right>{skill.Value:F1}</div>";
|
|
}
|
|
|
|
private static string FormatAttributes(int cur, int max)
|
|
{
|
|
if (max == 0)
|
|
{
|
|
return "<div align=right>---</div>";
|
|
}
|
|
|
|
return $"<div align=right>{cur}/{max}</div>";
|
|
}
|
|
|
|
private static string FormatStat(int val)
|
|
{
|
|
if (val == 0)
|
|
{
|
|
return "<div align=right>---</div>";
|
|
}
|
|
|
|
return $"<div align=right>{val}</div>";
|
|
}
|
|
|
|
private static string FormatDouble(double val)
|
|
{
|
|
if (val == 0)
|
|
{
|
|
return "<div align=right>---</div>";
|
|
}
|
|
|
|
return $"<div align=right>{val:F1}</div>";
|
|
}
|
|
|
|
private static string FormatElement(int val, string color = null)
|
|
{
|
|
if (color == null)
|
|
{
|
|
return val == 0 ? "<div align=right>---</div>" : $"<div align=right>{val}%</div>";
|
|
}
|
|
|
|
return val == 0
|
|
? $"<BASEFONT COLOR={color}><div align=right>---</div>"
|
|
: $"<BASEFONT COLOR={color}><div align=right>{val}%</div>";
|
|
}
|
|
|
|
private static string FormatDamage(int min, int max)
|
|
{
|
|
if (min <= 0 || max <= 0)
|
|
{
|
|
return "<div align=right>---</div>";
|
|
}
|
|
|
|
return $"<div align=right>{min}-{max}</div>";
|
|
}
|
|
}
|
|
}
|