ModernUO/Projects/UOContent/Skills/Hiding.cs
Kamron Batman 28c06c1cc0
fix: Changes Map.Sector.Mobiles to link list & Fixes various related crash bugs (#1553)
### Summary

Eliminates `IPooledEnumerable<T>` and `eable.Free()` from `Map` for mobiles. This drastically simplifies code that iterates in range, for example:

```cs
foreach (var m in m.GetMobilesInRange(5))
{
}
```
The code above no longer requires an eable and calling `Free()`.

- [X] Fixed several locations where an NPC that was damaged would cause a server crash.
- [X] Removed an unnecessary allocation in guard fake calls (NPCs calling guards on you)
- [X] Fixes damage precision loss in Poison Strike Spell
- [X] BogThing no longer attempts to "search" for boglings to eat when it is at full health
2023-10-29 22:42:46 -07:00

101 lines
3.1 KiB
C#

using System;
using Server.Multis;
using Server.Spells.Sixth;
using Server.Targeting;
namespace Server.SkillHandlers
{
public static class Hiding
{
public static bool CombatOverride { get; set; }
public static void Initialize()
{
SkillInfo.Table[21].Callback = OnUse;
}
public static TimeSpan OnUse(Mobile m)
{
if (m.Spell != null)
{
m.SendLocalizedMessage(501238); // You are busy doing something else and cannot hide.
return TimeSpan.FromSeconds(1.0);
}
if (Core.ML && m.Target != null)
{
Target.Cancel(m);
}
var bonus = 0.0;
var house = BaseHouse.FindHouseAt(m);
if (house?.IsFriend(m) == true)
{
bonus = 100.0;
}
else if (!Core.AOS)
{
house ??= BaseHouse.FindHouseAt(new Point3D(m.X - 1, m.Y, 127), m.Map, 16) ??
BaseHouse.FindHouseAt(new Point3D(m.X + 1, m.Y, 127), m.Map, 16) ??
BaseHouse.FindHouseAt(new Point3D(m.X, m.Y - 1, 127), m.Map, 16) ??
BaseHouse.FindHouseAt(new Point3D(m.X, m.Y + 1, 127), m.Map, 16);
if (house != null)
{
bonus = 50.0;
}
}
// int range = 18 - (int)(m.Skills.Hiding.Value / 10);
// Cap of 18 not OSI-exact, intentional difference
var range = Math.Min((int)((100 - m.Skills.Hiding.Value) / 2) + 8, 18);
var badCombat = !CombatOverride && m.Combatant != null && m.InRange(m.Combatant.Location, range) &&
m.Combatant.InLOS(m);
var ok = !badCombat;
if (ok)
{
if (!CombatOverride)
{
foreach (var check in m.GetMobilesInRange(range))
{
if (check.InLOS(m) && check.Combatant == m)
{
badCombat = true;
break;
}
}
}
ok = !badCombat && m.CheckSkill(SkillName.Hiding, 0.0 - bonus, 100.0 - bonus);
}
if (badCombat)
{
m.RevealingAction();
m.LocalOverheadMessage(MessageType.Regular, 0x22, 501237); // You can't seem to hide right now.
return TimeSpan.FromSeconds(1.0);
}
if (ok)
{
m.Hidden = true;
m.Warmode = false;
m.LocalOverheadMessage(MessageType.Regular, 0x1F4, 501240); // You have hidden yourself well.
InvisibilitySpell.StopTimer(m);
}
else
{
m.RevealingAction();
m.LocalOverheadMessage(MessageType.Regular, 0x22, 501241); // You can't seem to hide here.
}
return TimeSpan.FromSeconds(10.0);
}
}
}