## Summary Migrates 16 player-facing legacy `Gump` subclasses in the Veteran Rewards system to `DynamicGump` or `StaticGump<T>`, renames every nested `InternalGump`/`ConfirmGump` to system-prefixed names, and updates external callers to use new static `DisplayTo` entry points. ### Reward chain (Engines/Veteran Rewards) | Gump | Base type | Reasoning | |---|---|---| | `RewardNoticeGump` | `StaticGump<T>` | Fixed layout | | `RewardChoiceGump` | `DynamicGump` | Layout shape varies (per-player categories, entries, pages) | | `RewardConfirmGump` | `DynamicGump` | `entry.Name` is a dynamic cliloc per reward (cliloc rule) | | `RewardOptionGump` | `DynamicGump` | Title cliloc and per-option clilocs are dynamic (cliloc rule) | | `RewardDemolitionGump` | `DynamicGump` | `question` cliloc is dynamic per caller (cliloc rule) | ### Statue (Engines/Veteran Rewards/Character Statue Maker) | Gump | Base type | Reasoning | |---|---|---| | `CharacterStatueGump` | `DynamicGump` | Pose/Direction/Material labels are dynamic clilocs (cliloc rule) | | `CharacterPlinthGump` | `DynamicGump` | `statue.Name`, sculpted-on date, and statue-type cliloc are dynamic (cliloc rule) | ### Decorations (Items/Special/Veteran Rewards) — every `InternalGump` renamed | Original | New name | Base type | Reasoning | |---|---|---|---| | `Banner.InternalGump` | `BannerGump` | `StaticGump<T>` | Fully fixed item-id picker over `Start..End` range | | `Brazier.InternalGump` | `BrazierGump` | `StaticGump<T>` | Fixed two-item picker | | `Cannon.InternalGump` | `CannonGump` | `DynamicGump` | `keg.Validate()` value passed as `~1_CHARGES~` arg (cliloc-arg rule) | | `DecorativeShield.InternalGump` | `DecorativeShieldGump` | `StaticGump<T>` | Fixed item picker over a constant range | | `DecorativeShield.FacingGump` | `DecorativeShieldFacingGump` | `DynamicGump` | Item ids depend on instance state | | `HangingSkeleton.InternalGump` | `HangingSkeletonGump` | `StaticGump<T>` | Fixed item picker (5 hard-coded ids) | | `PottedCactus.InternalGump` | `PottedCactusGump` | `StaticGump<T>` | Fixed 6-item picker | | `StoneAnkh.InternalGump` | `StoneAnkhGump` | `StaticGump<T>` | Fixed two-direction picker | | `WallBanner.InternalGump` | `WallBannerGump` | `StaticGump<T>` | Fixed 30-banner picker across 5 pages | | `WeaponEngravingTool.InternalGump` | `WeaponEngravingToolGump` | `StaticGump<T>` | Fixed text-entry dialog | | `WeaponEngravingTool.ConfirmGump` | `WeaponEngravingToolConfirmGump` | `DynamicGump` | Layout branches on `guildmaster != null` | ### External callers updated `RewardSystem`, `CharacterStatue`, `FireFliesDeed`, `FlamingHead`, `Banner`, `DecorativeShield`, `HangingSkeleton`, `StoneAnkh` (RewardDemolitionGump callers); `AnkhOfSacrifice`, `Cannon`, `MiningCart`, `MinotaurStatue`, `TreeStump` (RewardOptionGump callers); `TinkerGuildmaster` (engraver confirm gump). The pre-existing `FacingGump` inside `Banner.cs` (already `DynamicGump`) was left as-is — it is private, nested inside `InternalTarget`, and never referenced outside.
137 lines
3.3 KiB
C#
137 lines
3.3 KiB
C#
using ModernUO.Serialization;
|
|
using Server.Gumps;
|
|
using Server.Mobiles;
|
|
using Server.Multis;
|
|
|
|
namespace Server.Items;
|
|
|
|
[SerializationGenerator(0)]
|
|
public partial class CharacterStatuePlinth : Static, IAddon
|
|
{
|
|
[SerializableField(0, setter: "private")]
|
|
private CharacterStatue _statue;
|
|
|
|
public CharacterStatuePlinth(CharacterStatue statue) : base(0x32F2)
|
|
{
|
|
_statue = statue;
|
|
|
|
InvalidateHue();
|
|
}
|
|
|
|
public override int LabelNumber => 1076201; // Character Statue
|
|
public Item Deed => new CharacterStatueDeed(_statue);
|
|
|
|
public virtual bool CouldFit(IPoint3D p, Map map)
|
|
{
|
|
var point = new Point3D(p.X, p.Y, p.Z);
|
|
|
|
if (map?.CanFit(point, 20) != true)
|
|
{
|
|
return false;
|
|
}
|
|
|
|
var house = BaseHouse.FindHouseAt(point, map, 20);
|
|
|
|
if (house == null)
|
|
{
|
|
return false;
|
|
}
|
|
|
|
var result = CharacterStatueTarget.CheckDoors(point, 20, house);
|
|
|
|
if (result == AddonFitResult.Valid)
|
|
{
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
public override void OnAfterDelete()
|
|
{
|
|
base.OnAfterDelete();
|
|
|
|
if (_statue?.Deleted == false)
|
|
{
|
|
_statue.Delete();
|
|
}
|
|
}
|
|
|
|
public override void OnMapChange()
|
|
{
|
|
if (_statue != null)
|
|
{
|
|
_statue.Map = Map;
|
|
}
|
|
}
|
|
|
|
public override void OnLocationChange(Point3D oldLocation)
|
|
{
|
|
if (_statue != null)
|
|
{
|
|
_statue.Location = new Point3D(X, Y, Z + 5);
|
|
}
|
|
}
|
|
|
|
public override void OnDoubleClick(Mobile from)
|
|
{
|
|
if (_statue != null)
|
|
{
|
|
CharacterPlinthGump.DisplayTo(from, _statue);
|
|
}
|
|
}
|
|
|
|
[AfterDeserialization(false)]
|
|
private void AfterDeserialization()
|
|
{
|
|
if (string.IsNullOrEmpty(_statue?.SculptedBy) || Map == Map.Internal)
|
|
{
|
|
Delete();
|
|
}
|
|
}
|
|
|
|
public void InvalidateHue()
|
|
{
|
|
if (_statue != null)
|
|
{
|
|
Hue = 0xB8F + (int)_statue.StatueType * 4 + (int)_statue.Material;
|
|
}
|
|
}
|
|
|
|
private class CharacterPlinthGump : DynamicGump
|
|
{
|
|
private readonly CharacterStatue _statue;
|
|
|
|
public override bool Singleton => true;
|
|
|
|
private CharacterPlinthGump(CharacterStatue statue) : base(60, 30) => _statue = statue;
|
|
|
|
public static void DisplayTo(Mobile from, CharacterStatue statue)
|
|
{
|
|
if (from?.NetState == null || statue == null || statue.Deleted)
|
|
{
|
|
return;
|
|
}
|
|
|
|
from.SendGump(new CharacterPlinthGump(statue));
|
|
}
|
|
|
|
protected override void BuildLayout(ref DynamicGumpBuilder builder)
|
|
{
|
|
builder.AddPage();
|
|
builder.AddImage(0, 0, 0x24F4);
|
|
builder.AddHtml(55, 50, 150, 20, _statue.Name);
|
|
builder.AddHtml(55, 75, 150, 20, _statue.SculptedOn.ToString());
|
|
builder.AddHtmlLocalized(55, 100, 150, 20, GetTypeNumber(_statue.StatueType), 0);
|
|
}
|
|
|
|
public static int GetTypeNumber(StatueType type) =>
|
|
type switch
|
|
{
|
|
StatueType.Marble => 1076181,
|
|
StatueType.Jade => 1076180,
|
|
StatueType.Bronze => 1076230,
|
|
_ => 1076181
|
|
};
|
|
}
|
|
}
|